All of lore.kernel.org
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] ARM: imx: add gpu device
Date: Thu, 31 Mar 2011 12:00:44 +0200	[thread overview]
Message-ID: <20110331100044.GX30938@pengutronix.de> (raw)
In-Reply-To: <AANLkTikf63wTfM1z2cpV+GuK28y1wrT7UWvw4TanBj4R@mail.gmail.com>

Hello Matt,

On Wed, Mar 30, 2011 at 05:23:12PM -0500, Matt Sealey wrote:
> I have a serious problem with the way the "new"
> "imx_add_this_and_that" platform devices are done. Why is there so
> much done in little helper functions and defines?
The reason for that is to get rid of these static struct
platform_devices (and some more things) to save memory.

For example look at commit

	a5fcfef (ARM: mx5: dynamically allocate imx-keypad devices)

. It get's rid of mxc_kpp_resources[] (= 2 * 28 Byte, .data) and
mxc_keypad_device (= 320 Byte, .data).
It only adds imx51_imx_keypad_data (= 12 Byte, .init.rodata). Moreover
it allows to move platform data (here: mbimx51_map_data and
mx51_3ds_map_data) from .data to .init.rodata. And you need some
.init.text memory for the imx_add_this_and_that function.

So if you consider a kernel that supports mx51_3ds, eukrea_cpuimx51 and
mx51_babbage. On mx51_3ds and eukrea_cpuimx51 the saving at runtime
isn't that big, they only save the platform data of the other machine.
But on mx51_babbage you profit from the whole stuff that is 376 Bytes.
Up to you to do the same calculation for e.g. imx-uart that has up to 6
instances on i.MX27 with usually only two or three used on a single
machine.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

      parent reply	other threads:[~2011-03-31 10:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30  6:05 [PATCH v2 1/1] ARM: imx: add gpu device Richard Zhao
2011-03-30  7:16 ` Uwe Kleine-König
2011-03-30  8:16   ` Richard Zhao
2011-03-30  9:03     ` Eric Miao
2011-03-30  9:12       ` Uwe Kleine-König
2011-03-30  9:16         ` Wolfram Sang
2011-03-30  7:36 ` Sascha Hauer
2011-03-30  7:52   ` Arnaud Patard (Rtp)
2011-03-30  8:00     ` Richard Zhao
2011-03-30  8:05     ` Sascha Hauer
2011-03-30 22:23   ` Matt Sealey
2011-03-31  5:38     ` Richard Zhao
2011-04-01  0:29       ` Matt Sealey
2011-03-31  8:26     ` Sascha Hauer
2011-04-01  0:36       ` Matt Sealey
2011-04-01 13:30         ` Sascha Hauer
2011-03-31 10:00     ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110331100044.GX30938@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.