All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, jaxboe@fusionio.com,
	paulmck@linux.vnet.ibm.com, oleg@redhat.com
Subject: Re: [PATCH] blk-throttle: don't call xchg on bool
Date: Wed, 30 Mar 2011 12:53:42 -0400	[thread overview]
Message-ID: <20110330165342.GF1291@redhat.com> (raw)
In-Reply-To: <m3vcz0ra1l.fsf@linux-m68k.org>

On Wed, Mar 30, 2011 at 03:51:34PM +0200, Andreas Schwab wrote:
> Vivek Goyal <vgoyal@redhat.com> writes:
> 
> > Which arch creates the problem and what's the issue here if data type
> > is smaller than 32bit?
> 
> Just look at the various implementations in arch/*/include/asm/system.h:
> 
> - arm: supports only one and 4 byte xchg
> - avr32: supports only 4 byte xchg
> - frv: supports only 4 byte xchg
> - m32r: SMP supports only 4 byte xchg
> - microblaze: supports only one and 4 byte xchg
> 
> etc.
> 
> > Is it a compile time warning?
> 
> Most implementations turn the use of xchg with a bad pointer into a link
> error.

Thanks Andreas. I get it. I did check arm and it is supporting only one
and 4 byte xchg.

Vivek

  reply	other threads:[~2011-03-30 16:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-15 21:07 [PATCH 0/2] blk-throttle: Couple of more fixes Vivek Goyal
2010-12-15 21:07 ` [PATCH 1/2] blk-throttle: process limit change only through one function Vivek Goyal
2010-12-15 21:07 ` [PATCH 2/2] blk-throttle: Some cleanups and race fixes in limit update code Vivek Goyal
2010-12-16 14:49   ` Oleg Nesterov
2010-12-17 22:28   ` Paul E. McKenney
2010-12-17 22:34     ` Vivek Goyal
2011-03-29 23:14   ` [PATCH] blk-throttle: don't call xchg on bool Andreas Schwab
2011-03-30 10:21     ` Jens Axboe
2011-03-30 13:19     ` Vivek Goyal
2011-03-30 13:51       ` Andreas Schwab
2011-03-30 16:53         ` Vivek Goyal [this message]
2011-03-30 16:06       ` Andreas Schwab
2010-12-21 16:05 ` [PATCH 0/2] blk-throttle: Couple of more fixes Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110330165342.GF1291@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.