From: Andreas Schwab <schwab@linux-m68k.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-kernel@vger.kernel.org, jaxboe@fusionio.com,
paulmck@linux.vnet.ibm.com, oleg@redhat.com
Subject: Re: [PATCH] blk-throttle: don't call xchg on bool
Date: Wed, 30 Mar 2011 18:06:16 +0200 [thread overview]
Message-ID: <m2mxkcfv9j.fsf@igel.home> (raw)
In-Reply-To: <20110330131936.GA1291@redhat.com> (Vivek Goyal's message of "Wed, 30 Mar 2011 09:19:36 -0400")
Vivek Goyal <vgoyal@redhat.com> writes:
> Also, you also probably need to chagne ->limits_changed assignments?
> Instead of using true/false use 1/0.
That's rather a cosmetical change that can be added on top if it is
deemed useful.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-03-30 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 21:07 [PATCH 0/2] blk-throttle: Couple of more fixes Vivek Goyal
2010-12-15 21:07 ` [PATCH 1/2] blk-throttle: process limit change only through one function Vivek Goyal
2010-12-15 21:07 ` [PATCH 2/2] blk-throttle: Some cleanups and race fixes in limit update code Vivek Goyal
2010-12-16 14:49 ` Oleg Nesterov
2010-12-17 22:28 ` Paul E. McKenney
2010-12-17 22:34 ` Vivek Goyal
2011-03-29 23:14 ` [PATCH] blk-throttle: don't call xchg on bool Andreas Schwab
2011-03-30 10:21 ` Jens Axboe
2011-03-30 13:19 ` Vivek Goyal
2011-03-30 13:51 ` Andreas Schwab
2011-03-30 16:53 ` Vivek Goyal
2011-03-30 16:06 ` Andreas Schwab [this message]
2010-12-21 16:05 ` [PATCH 0/2] blk-throttle: Couple of more fixes Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mxkcfv9j.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.