* Re: [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT
2011-03-30 23:24 [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT Tomàs Deltell Bonell
@ 2011-03-30 23:51 ` Guenter Roeck
2011-03-31 8:06 ` Jean Delvare
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2011-03-30 23:51 UTC (permalink / raw)
To: lm-sensors
On Wed, Mar 30, 2011 at 07:24:08PM -0400, Tomàs Deltell Bonell wrote:
> I'm trying to install w83627ehf driver on my Asrock ION 330 HT with Mandriva
> 2010.2, kernel 2.6.33.7 and lm-sensors 3.1.2. When i try to compile i get this
> error:
>
> $ make
> CC [M] /home/user/w83627ehf/w83627ehf.o
> /home/user/w83627ehf/w83627ehf.c: on function ‘w83627ehf_find’:
> /home/user/w83627ehf/w83627ehf.c:2385: error: implicit declaration of
> ‘pr_warn’ function
> make[2]: *** [/home/user/w83627ehf/w83627ehf.o] Error 1
> make[1]: *** [_module_/home/user/w83627ehf] Error 2
> make: *** [modules] Error 2
>
> and i don't know how to continue
>
Just replace pr_warn with pr_warning. Looks like pr_warn was only introduced
in a later kernel version. It maps to pr_warning, so it is ok to replace it.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT
2011-03-30 23:24 [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT Tomàs Deltell Bonell
2011-03-30 23:51 ` Guenter Roeck
@ 2011-03-31 8:06 ` Jean Delvare
2011-03-31 13:58 ` Guenter Roeck
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2011-03-31 8:06 UTC (permalink / raw)
To: lm-sensors
On Thu, 31 Mar 2011 01:24:08 +0200, Tomàs Deltell Bonell wrote:
> I'm trying to install w83627ehf driver on my Asrock ION 330 HT with Mandriva
> 2010.2, kernel 2.6.33.7 and lm-sensors 3.1.2. When i try to compile i get this
> error:
>
> $ make
> CC [M] /home/user/w83627ehf/w83627ehf.o
> /home/user/w83627ehf/w83627ehf.c: on function ‘w83627ehf_find’:
> /home/user/w83627ehf/w83627ehf.c:2385: error: implicit declaration of
> ‘pr_warn’ function
> make[2]: *** [/home/user/w83627ehf/w83627ehf.o] Error 1
> make[1]: *** [_module_/home/user/w83627ehf] Error 2
> make: *** [modules] Error 2
>
> and i don't know how to continue
Where do you get this driver from? The one I host at
http://khali.linux-fr.org/devel/misc/w83627ehf/
includes a compatibility patch for the problem you are reporting. And
the one Guenter is hosting at
http://roeck-us.net/linux/drivers/w83627ehf/
includes variants for older kernels (2.6.18 and RHEL 5.4 as I
understand it.)
BTW, Guenter, I don't think it makes sense that we both maintain a
standalone w83627ehf driver. Mine is lagging behind these days (lacks
support for the NCT6776F) but yours is less user-friendly IMHO (separate
source files for older kernels.) Maybe we can combine our efforts to
have a single, up-to-date and user-friendly driver? First question
being: do you plan to keep your driver alive at all, or was it just
there for the times when you were working on adding NCT6776F support?
FYI, I am using quilt to maintain my standalone drivers. This lets me
keep the compatibility layer separated from the original driver code.
That way it is very easy for me to update to a new base version of the
driver - I simply pop the compatibility patch, update the driver, push
the compatibility patch again and refresh it as needed. Then I upload
the result to my website. I don't know if you have such a workflow on
your side.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT
2011-03-30 23:24 [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT Tomàs Deltell Bonell
2011-03-30 23:51 ` Guenter Roeck
2011-03-31 8:06 ` Jean Delvare
@ 2011-03-31 13:58 ` Guenter Roeck
2011-04-07 17:59 ` Tomàs Deltell Bonell
2011-04-07 19:00 ` Jean Delvare
4 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2011-03-31 13:58 UTC (permalink / raw)
To: lm-sensors
On Thu, Mar 31, 2011 at 04:06:28AM -0400, Jean Delvare wrote:
> On Thu, 31 Mar 2011 01:24:08 +0200, Tomàs Deltell Bonell wrote:
> > I'm trying to install w83627ehf driver on my Asrock ION 330 HT with Mandriva
> > 2010.2, kernel 2.6.33.7 and lm-sensors 3.1.2. When i try to compile i get this
> > error:
> >
> > $ make
> > CC [M] /home/user/w83627ehf/w83627ehf.o
> > /home/user/w83627ehf/w83627ehf.c: on function ‘w83627ehf_find’:
> > /home/user/w83627ehf/w83627ehf.c:2385: error: implicit declaration of
> > ‘pr_warn’ function
> > make[2]: *** [/home/user/w83627ehf/w83627ehf.o] Error 1
> > make[1]: *** [_module_/home/user/w83627ehf] Error 2
> > make: *** [modules] Error 2
> >
> > and i don't know how to continue
>
> Where do you get this driver from? The one I host at
> http://khali.linux-fr.org/devel/misc/w83627ehf/
> includes a compatibility patch for the problem you are reporting. And
> the one Guenter is hosting at
> http://roeck-us.net/linux/drivers/w83627ehf/
> includes variants for older kernels (2.6.18 and RHEL 5.4 as I
> understand it.)
>
> BTW, Guenter, I don't think it makes sense that we both maintain a
> standalone w83627ehf driver. Mine is lagging behind these days (lacks
> support for the NCT6776F) but yours is less user-friendly IMHO (separate
> source files for older kernels.) Maybe we can combine our efforts to
> have a single, up-to-date and user-friendly driver? First question
> being: do you plan to keep your driver alive at all, or was it just
> there for the times when you were working on adding NCT6776F support?
>
It was only intended for the NCT6775F/NCT6776F support, so, no, I did
not plan to keep it alive.
> FYI, I am using quilt to maintain my standalone drivers. This lets me
> keep the compatibility layer separated from the original driver code.
> That way it is very easy for me to update to a new base version of the
> driver - I simply pop the compatibility patch, update the driver, push
> the compatibility patch again and refresh it as needed. Then I upload
> the result to my website. I don't know if you have such a workflow on
> your side.
>
I could do the same with git - just create separate branches for
the different versions. So far I just copied the standalone drivers from
the actual trees, though. In my development flow, I have a separate branch
for each of the drivers I am working on, and sometimes even multiple branches
(eg one for bug fixes, one for cleanup, and one for new development).
I agree that we should only maintain a single version of the standalone driver.
Let me know your preference - I can delete mine and have it point to yours.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT
2011-03-30 23:24 [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT Tomàs Deltell Bonell
` (2 preceding siblings ...)
2011-03-31 13:58 ` Guenter Roeck
@ 2011-04-07 17:59 ` Tomàs Deltell Bonell
2011-04-07 19:00 ` Jean Delvare
4 siblings, 0 replies; 6+ messages in thread
From: Tomàs Deltell Bonell @ 2011-04-07 17:59 UTC (permalink / raw)
To: lm-sensors
El 31/03/2011 10:06, Jean Delvare escribió:
> On Thu, 31 Mar 2011 01:24:08 +0200, Tomàs Deltell Bonell wrote:
>> I'm trying to install w83627ehf driver on my Asrock ION 330 HT with Mandriva
>> 2010.2, kernel 2.6.33.7 and lm-sensors 3.1.2. When i try to compile i get this
>> error:
>>
>> $ make
>> CC [M] /home/user/w83627ehf/w83627ehf.o
>> /home/user/w83627ehf/w83627ehf.c: on function ‘w83627ehf_find’:
>> /home/user/w83627ehf/w83627ehf.c:2385: error: implicit declaration of
>> ‘pr_warn’ function
>> make[2]: *** [/home/user/w83627ehf/w83627ehf.o] Error 1
>> make[1]: *** [_module_/home/user/w83627ehf] Error 2
>> make: *** [modules] Error 2
>>
>> and i don't know how to continue
> Where do you get this driver from? The one I host at
> http://khali.linux-fr.org/devel/misc/w83627ehf/
> includes a compatibility patch for the problem you are reporting. And
> the one Guenter is hosting at
> http://roeck-us.net/linux/drivers/w83627ehf/
> includes variants for older kernels (2.6.18 and RHEL 5.4 as I
> understand it.)
>
> BTW, Guenter, I don't think it makes sense that we both maintain a
> standalone w83627ehf driver. Mine is lagging behind these days (lacks
> support for the NCT6776F) but yours is less user-friendly IMHO (separate
> source files for older kernels.) Maybe we can combine our efforts to
> have a single, up-to-date and user-friendly driver? First question
> being: do you plan to keep your driver alive at all, or was it just
> there for the times when you were working on adding NCT6776F support?
>
> FYI, I am using quilt to maintain my standalone drivers. This lets me
> keep the compatibility layer separated from the original driver code.
> That way it is very easy for me to update to a new base version of the
> driver - I simply pop the compatibility patch, update the driver, push
> the compatibility patch again and refresh it as needed. Then I upload
> the result to my website. I don't know if you have such a workflow on
> your side.
>
I was using the Guenter's driver. But last night I tried your driver and
compiled correctly. This is the result:
$ sensors
w83667hg-isa-0290
Adapter: ISA adapter
in0: +1.14 V (min = +0.00 V, max = +1.74 V)
in1: +0.59 V (min = +0.00 V, max = +0.00 V) ALARM
in2: +3.42 V (min = +0.00 V, max = +0.00 V) ALARM
in3: +3.42 V (min = +0.00 V, max = +0.00 V) ALARM
in4: +1.31 V (min = +0.00 V, max = +0.00 V) ALARM
in5: +1.29 V (min = +0.00 V, max = +0.00 V) ALARM
in7: +3.47 V (min = +0.00 V, max = +0.00 V) ALARM
in8: +3.20 V (min = +0.00 V, max = +0.00 V) ALARM
fan1: 0 RPM (min = 0 RPM, div = 1)
fan2: 0 RPM (min = 0 RPM, div = 1)
fan3: 0 RPM (min = 0 RPM, div = 1)
fan4: 0 RPM (min = 0 RPM, div = 1)
temp1: +54.0°C (high = +0.0°C, hyst = +0.0°C) ALARM sensor =
diode
temp2: +53.5°C (high = +80.0°C, hyst = +75.0°C) sensor = diode
temp3: +67.5°C (high = +80.0°C, hyst = +75.0°C) sensor = diode
cpu0_vid: +0.000 V
coretemp-isa-0000
Adapter: ISA adapter
Core 0: +22.0°C (crit = +90.0°C)
coretemp-isa-0001
Adapter: ISA adapter
Core 1: +31.0°C (crit = +90.0°C)
Temperatures of the new adapter is displayed correctly (in accordance
with the information that BIOS shows)
These are the results that should be shown?
There are any plan to include support for these chips on lm-sensors?
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT
2011-03-30 23:24 [lm-sensors] testing "w83627ehf" on Asrock ION 330 HT Tomàs Deltell Bonell
` (3 preceding siblings ...)
2011-04-07 17:59 ` Tomàs Deltell Bonell
@ 2011-04-07 19:00 ` Jean Delvare
4 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2011-04-07 19:00 UTC (permalink / raw)
To: lm-sensors
On Thu, 07 Apr 2011 19:59:22 +0200, Tomàs Deltell Bonell wrote:
> I was using the Guenter's driver. But last night I tried your driver and
> compiled correctly. This is the result:
These are essentially the same driver, both are based on the kernel
version, with support for new chips added.
>
> $ sensors
> w83667hg-isa-0290
> Adapter: ISA adapter
> in0: +1.14 V (min = +0.00 V, max = +1.74 V)
> in1: +0.59 V (min = +0.00 V, max = +0.00 V) ALARM
> in2: +3.42 V (min = +0.00 V, max = +0.00 V) ALARM
> in3: +3.42 V (min = +0.00 V, max = +0.00 V) ALARM
> in4: +1.31 V (min = +0.00 V, max = +0.00 V) ALARM
> in5: +1.29 V (min = +0.00 V, max = +0.00 V) ALARM
> in7: +3.47 V (min = +0.00 V, max = +0.00 V) ALARM
> in8: +3.20 V (min = +0.00 V, max = +0.00 V) ALARM
> fan1: 0 RPM (min = 0 RPM, div = 1)
> fan2: 0 RPM (min = 0 RPM, div = 1)
> fan3: 0 RPM (min = 0 RPM, div = 1)
> fan4: 0 RPM (min = 0 RPM, div = 1)
> temp1: +54.0°C (high = +0.0°C, hyst = +0.0°C) ALARM sensor = diode
> temp2: +53.5°C (high = +80.0°C, hyst = +75.0°C) sensor = diode
> temp3: +67.5°C (high = +80.0°C, hyst = +75.0°C) sensor = diode
> cpu0_vid: +0.000 V
>
> coretemp-isa-0000
> Adapter: ISA adapter
> Core 0: +22.0°C (crit = +90.0°C)
>
> coretemp-isa-0001
> Adapter: ISA adapter
> Core 1: +31.0°C (crit = +90.0°C)
>
> Temperatures of the new adapter is displayed correctly (in accordance
> with the information that BIOS shows)
Great.
> These are the results that should be shown?
You'd get a better output with the latest version of the default
configuration file:
http://www.lm-sensors.org/export/5959/lm-sensors/trunk/etc/sensors.conf.default
The missing fan speeds is surprising too, as are the divisor values of
1. Maybe the driver will increase them on later reads, and at some
point you get valid fan speed readings? Unless this is a fanless system
of course.
But anyway, these days Guenter's copy of the driver is ahead of mine
for the chip you have, so you should really be using his driver, not
mine, until I merge his code (that's on my to-do list, but has low
priority.)
> There are any plan to include support for these chips on lm-sensors?
Support is already in the upstream kernel.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread