From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org,
linux-mm@kvack.org, Michal Nazarewicz <mina86@mina86.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ankita Garg <ankita@in.ibm.com>,
Daniel Walker <dwalker@codeaurora.org>,
Johan MOSSBERG <johan.xx.mossberg@stericsson.com>,
Mel Gorman <mel@csn.ul.ie>, Pawel Osciak <pawel@osciak.com>
Subject: Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added
Date: Thu, 31 Mar 2011 15:24:30 -0400 [thread overview]
Message-ID: <20110331192429.GD14441@home.goodmis.org> (raw)
In-Reply-To: <1301587083.31087.1032.camel@nimitz>
On Thu, Mar 31, 2011 at 08:58:03AM -0700, Dave Hansen wrote:
> On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote:
> >
> > +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long end,
> > + gfp_t flag)
> > +{
> > + unsigned long pfn = start, count;
> > + struct page *page;
> > + struct zone *zone;
> > + int order;
> > +
> > + VM_BUG_ON(!pfn_valid(start));
>
> This seems kinda mean. Could we return an error? I understand that
> this is largely going to be an early-boot thing, but surely trying to
> punt on crappy input beats a full-on BUG().
>
> if (!pfn_valid(start))
> return -1;
But still keep the warning?
if (WARN_ON(!pfn_valid(start))
return -1;
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: rostedt@goodmis.org (Steven Rostedt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/12] mm: alloc_contig_freed_pages() added
Date: Thu, 31 Mar 2011 15:24:30 -0400 [thread overview]
Message-ID: <20110331192429.GD14441@home.goodmis.org> (raw)
In-Reply-To: <1301587083.31087.1032.camel@nimitz>
On Thu, Mar 31, 2011 at 08:58:03AM -0700, Dave Hansen wrote:
> On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote:
> >
> > +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long end,
> > + gfp_t flag)
> > +{
> > + unsigned long pfn = start, count;
> > + struct page *page;
> > + struct zone *zone;
> > + int order;
> > +
> > + VM_BUG_ON(!pfn_valid(start));
>
> This seems kinda mean. Could we return an error? I understand that
> this is largely going to be an early-boot thing, but surely trying to
> punt on crappy input beats a full-on BUG().
>
> if (!pfn_valid(start))
> return -1;
But still keep the warning?
if (WARN_ON(!pfn_valid(start))
return -1;
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org,
linux-mm@kvack.org, Michal Nazarewicz <mina86@mina86.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ankita Garg <ankita@in.ibm.com>,
Daniel Walker <dwalker@codeaurora.org>,
Johan MOSSBERG <johan.xx.mossberg@stericsson.com>,
Mel Gorman <mel@csn.ul.ie>, Pawel Osciak <pawel@osciak.com>
Subject: Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added
Date: Thu, 31 Mar 2011 15:24:30 -0400 [thread overview]
Message-ID: <20110331192429.GD14441@home.goodmis.org> (raw)
In-Reply-To: <1301587083.31087.1032.camel@nimitz>
On Thu, Mar 31, 2011 at 08:58:03AM -0700, Dave Hansen wrote:
> On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote:
> >
> > +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long end,
> > + gfp_t flag)
> > +{
> > + unsigned long pfn = start, count;
> > + struct page *page;
> > + struct zone *zone;
> > + int order;
> > +
> > + VM_BUG_ON(!pfn_valid(start));
>
> This seems kinda mean. Could we return an error? I understand that
> this is largely going to be an early-boot thing, but surely trying to
> punt on crappy input beats a full-on BUG().
>
> if (!pfn_valid(start))
> return -1;
But still keep the warning?
if (WARN_ON(!pfn_valid(start))
return -1;
-- Steve
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-31 19:24 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 13:15 [PATCHv9 0/12] Contiguous Memory Allocator Marek Szyprowski
2011-03-31 13:15 ` Marek Szyprowski
2011-03-31 13:15 ` Marek Szyprowski
2011-03-31 13:15 ` [PATCH 01/12] lib: bitmap: Added alignment offset for bitmap_find_next_zero_area() Marek Szyprowski
2011-03-31 13:15 ` Marek Szyprowski
2011-03-31 13:15 ` Marek Szyprowski
2011-03-31 13:15 ` [PATCH 02/12] lib: genalloc: Generic allocator improvements Marek Szyprowski
2011-03-31 13:15 ` Marek Szyprowski
2011-03-31 13:15 ` Marek Szyprowski
2011-03-31 13:15 ` [PATCH 03/12] mm: move some functions from memory_hotplug.c to page_isolation.c Marek Szyprowski
2011-03-31 13:15 ` Marek Szyprowski
2011-03-31 13:15 ` Marek Szyprowski
2011-03-31 13:16 ` [PATCH 04/12] mm: alloc_contig_freed_pages() added Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 15:58 ` Dave Hansen
2011-03-31 15:58 ` Dave Hansen
2011-03-31 15:58 ` Dave Hansen
2011-03-31 19:24 ` Steven Rostedt [this message]
2011-03-31 19:24 ` Steven Rostedt
2011-03-31 19:24 ` Steven Rostedt
2011-03-31 20:33 ` Dave Hansen
2011-03-31 20:33 ` Dave Hansen
2011-03-31 20:33 ` Dave Hansen
2011-03-31 21:09 ` Michal Nazarewicz
2011-03-31 21:09 ` Michal Nazarewicz
2011-03-31 21:09 ` Michal Nazarewicz
2011-03-31 21:14 ` Dave Hansen
2011-03-31 21:14 ` Dave Hansen
2011-03-31 21:14 ` Dave Hansen
2011-03-31 22:18 ` Michal Nazarewicz
2011-03-31 22:18 ` Michal Nazarewicz
2011-03-31 22:18 ` Michal Nazarewicz
2011-03-31 22:26 ` Dave Hansen
2011-03-31 22:26 ` Dave Hansen
2011-03-31 22:26 ` Dave Hansen
2011-03-31 22:51 ` Michal Nazarewicz
2011-03-31 22:51 ` Michal Nazarewicz
2011-03-31 22:51 ` Michal Nazarewicz
2011-04-01 14:03 ` Dave Hansen
2011-04-01 14:03 ` Dave Hansen
2011-04-01 14:03 ` Dave Hansen
2011-04-04 13:15 ` Michal Nazarewicz
2011-04-04 13:15 ` Michal Nazarewicz
2011-04-04 13:15 ` Michal Nazarewicz
2011-04-05 7:23 ` Marek Szyprowski
2011-04-05 7:23 ` Marek Szyprowski
2011-04-05 7:23 ` Marek Szyprowski
2011-03-31 13:16 ` [PATCH 05/12] mm: alloc_contig_range() added Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 16:02 ` Dave Hansen
2011-03-31 16:02 ` Dave Hansen
2011-03-31 16:02 ` Dave Hansen
2011-03-31 16:26 ` Michal Nazarewicz
2011-03-31 16:26 ` Michal Nazarewicz
2011-03-31 16:26 ` Michal Nazarewicz
2011-03-31 19:28 ` Steven Rostedt
2011-03-31 19:28 ` Steven Rostedt
2011-03-31 19:28 ` Steven Rostedt
2011-03-31 19:52 ` Michal Nazarewicz
2011-03-31 19:52 ` Michal Nazarewicz
2011-03-31 19:52 ` Michal Nazarewicz
2011-03-31 20:28 ` Dave Hansen
2011-03-31 20:28 ` Dave Hansen
2011-03-31 20:28 ` Dave Hansen
2011-03-31 21:17 ` Michal Nazarewicz
2011-03-31 21:17 ` Michal Nazarewicz
2011-03-31 21:17 ` Michal Nazarewicz
2011-03-31 19:26 ` Steven Rostedt
2011-03-31 19:26 ` Steven Rostedt
2011-03-31 19:26 ` Steven Rostedt
2011-03-31 16:04 ` Dave Hansen
2011-03-31 16:04 ` Dave Hansen
2011-03-31 16:04 ` Dave Hansen
2011-03-31 13:16 ` [PATCH 06/12] mm: cma: Contiguous Memory Allocator added Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` [PATCH 07/12] mm: MIGRATE_CMA migration type added Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` [PATCH 08/12] mm: MIGRATE_CMA isolation functions added Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` [PATCH 09/12] mm: MIGRATE_CMA support added to CMA Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` [PATCH 10/12] mm: cma: add CMA 'regions style' API (for testing) Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` [PATCH 11/12] v4l: videobuf2: add CMA allocator " Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` [PATCH 12/12] ARM: S5PC110: Added CMA regions to Aquila and Goni boards Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
2011-03-31 13:16 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331192429.GD14441@home.goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=ankita@in.ibm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=dwalker@codeaurora.org \
--cc=johan.xx.mossberg@stericsson.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mel@csn.ul.ie \
--cc=mina86@mina86.com \
--cc=pawel@osciak.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.