All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yjwei@cn.fujitsu.com
Cc: vladislav.yasevich@hp.com, linux-sctp@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] sctp: malloc enough room for asconf-ack chunk
Date: Sat, 02 Apr 2011 04:46:10 +0000	[thread overview]
Message-ID: <20110401.214610.200375443.davem@davemloft.net> (raw)
In-Reply-To: <4D959E1F.80504@cn.fujitsu.com>

From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Fri, 01 Apr 2011 17:42:55 +0800

> Sometime the ASCONF_ACK parameters can equal to the fourfold of
> ASCONF parameters, this only happend in some special case:
> 
>   ASCONF parameter is :
>     Unrecognized Parameter (4 bytes)
>   ASCONF_ACK parameter should be:
>     Error Cause Indication parameter (8 bytes header)
>      + Error Cause (4 bytes header)
>        + Unrecognized Parameter (4bytes)
> 
> Four 4bytes Unrecognized Parameters in ASCONF chunk will cause panic.
 ...
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>

Applied.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: yjwei@cn.fujitsu.com
Cc: vladislav.yasevich@hp.com, linux-sctp@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] sctp: malloc enough room for asconf-ack chunk
Date: Fri, 01 Apr 2011 21:46:10 -0700 (PDT)	[thread overview]
Message-ID: <20110401.214610.200375443.davem@davemloft.net> (raw)
In-Reply-To: <4D959E1F.80504@cn.fujitsu.com>

From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Fri, 01 Apr 2011 17:42:55 +0800

> Sometime the ASCONF_ACK parameters can equal to the fourfold of
> ASCONF parameters, this only happend in some special case:
> 
>   ASCONF parameter is :
>     Unrecognized Parameter (4 bytes)
>   ASCONF_ACK parameter should be:
>     Error Cause Indication parameter (8 bytes header)
>      + Error Cause (4 bytes header)
>        + Unrecognized Parameter (4bytes)
> 
> Four 4bytes Unrecognized Parameters in ASCONF chunk will cause panic.
 ...
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>

Applied.

  reply	other threads:[~2011-04-02  4:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-01  9:38 [PATCH 1/2] sctp: fix auth_hmacs field's length of struct sctp_cookie Wei Yongjun
2011-04-01  9:38 ` Wei Yongjun
2011-04-01  9:42 ` [PATCH 2/2] sctp: malloc enough room for asconf-ack chunk Wei Yongjun
2011-04-01  9:42   ` Wei Yongjun
2011-04-02  4:46   ` David Miller [this message]
2011-04-02  4:46     ` David Miller
2011-04-02  4:46 ` [PATCH 1/2] sctp: fix auth_hmacs field's length of struct David Miller
2011-04-02  4:46   ` [PATCH 1/2] sctp: fix auth_hmacs field's length of struct sctp_cookie David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110401.214610.200375443.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vladislav.yasevich@hp.com \
    --cc=yjwei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.