* [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS
@ 2011-04-01 5:59 Len Brown
2011-04-01 6:21 ` Dave Jones
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Len Brown @ 2011-04-01 5:59 UTC (permalink / raw)
To: x86; +Cc: linux-kernel, linux-pm
From: Len Brown <len.brown@intel.com>
Since 2.6.36 (23016bf0d25), Linux prints the existence of "epb" in /proc/cpuinfo,
Since 2.6.38 (d5532ee7b40), the x86_energy_perf_policy(8) utility has
been available in-tree to update MSR_IA32_ENERGY_PERF_BIAS.
However, the typical BIOS fails to initialize the MSR, presumably
because this is handled by high-volume shrink-wrap operating systems...
Linux distros, on the other hand, do not yet invoke x86_energy_perf_policy(8).
As a result, WSM-EP, SNB, and later hardware from Intel will run in its
default hardware power-on state (performance), which assumes that users
care for performance at all costs and not for energy efficiency.
While that is fine for performance benchmarks, the hardware's intended default
operating point is "normal" mode...
Initialize the MSR to the "normal" by default during kernel boot.
x86_energy_perf_policy(8) is available to change the default after boot,
should the user have a different preference.
cc: stable@kernel.org
Signed-off-by: Len Brown <len.brown@intel.com>
---
arch/x86/include/asm/msr-index.h | 3 +++
arch/x86/kernel/cpu/intel.c | 14 ++++++++++++++
2 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
index 43a18c7..91fedd9 100644
--- a/arch/x86/include/asm/msr-index.h
+++ b/arch/x86/include/asm/msr-index.h
@@ -250,6 +250,9 @@
#define MSR_IA32_TEMPERATURE_TARGET 0x000001a2
#define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0
+#define ENERGY_PERF_BIAS_PERFORMANCE 0
+#define ENERGY_PERF_BIAS_NORMAL 6
+#define ENERGY_PERF_BIAS_POWERSWAVE 15
#define MSR_IA32_PACKAGE_THERM_STATUS 0x000001b1
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index d16c2c5..48cca4a 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -448,6 +448,20 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c)
if (cpu_has(c, X86_FEATURE_VMX))
detect_vmx_virtcap(c);
+
+ /*
+ * Initialize MSR_IA32_ENERGY_PERF_BIAS if BIOS did not.
+ * x86_energy_perf_policy(8) is available to change it at run-time
+ */
+ if (cpu_has(c, X86_FEATURE_EPB)) {
+ u64 epb;
+
+ rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
+ if ((epb & 0xF) == 0) {
+ epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
+ wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
+ }
+ }
}
#ifdef CONFIG_X86_32
--
1.7.4.2.406.gbe91
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS
@ 2011-04-01 5:59 Len Brown
0 siblings, 0 replies; 6+ messages in thread
From: Len Brown @ 2011-04-01 5:59 UTC (permalink / raw)
To: x86; +Cc: linux-pm, linux-kernel
From: Len Brown <len.brown@intel.com>
Since 2.6.36 (23016bf0d25), Linux prints the existence of "epb" in /proc/cpuinfo,
Since 2.6.38 (d5532ee7b40), the x86_energy_perf_policy(8) utility has
been available in-tree to update MSR_IA32_ENERGY_PERF_BIAS.
However, the typical BIOS fails to initialize the MSR, presumably
because this is handled by high-volume shrink-wrap operating systems...
Linux distros, on the other hand, do not yet invoke x86_energy_perf_policy(8).
As a result, WSM-EP, SNB, and later hardware from Intel will run in its
default hardware power-on state (performance), which assumes that users
care for performance at all costs and not for energy efficiency.
While that is fine for performance benchmarks, the hardware's intended default
operating point is "normal" mode...
Initialize the MSR to the "normal" by default during kernel boot.
x86_energy_perf_policy(8) is available to change the default after boot,
should the user have a different preference.
cc: stable@kernel.org
Signed-off-by: Len Brown <len.brown@intel.com>
---
arch/x86/include/asm/msr-index.h | 3 +++
arch/x86/kernel/cpu/intel.c | 14 ++++++++++++++
2 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
index 43a18c7..91fedd9 100644
--- a/arch/x86/include/asm/msr-index.h
+++ b/arch/x86/include/asm/msr-index.h
@@ -250,6 +250,9 @@
#define MSR_IA32_TEMPERATURE_TARGET 0x000001a2
#define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0
+#define ENERGY_PERF_BIAS_PERFORMANCE 0
+#define ENERGY_PERF_BIAS_NORMAL 6
+#define ENERGY_PERF_BIAS_POWERSWAVE 15
#define MSR_IA32_PACKAGE_THERM_STATUS 0x000001b1
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index d16c2c5..48cca4a 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -448,6 +448,20 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c)
if (cpu_has(c, X86_FEATURE_VMX))
detect_vmx_virtcap(c);
+
+ /*
+ * Initialize MSR_IA32_ENERGY_PERF_BIAS if BIOS did not.
+ * x86_energy_perf_policy(8) is available to change it at run-time
+ */
+ if (cpu_has(c, X86_FEATURE_EPB)) {
+ u64 epb;
+
+ rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
+ if ((epb & 0xF) == 0) {
+ epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
+ wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
+ }
+ }
}
#ifdef CONFIG_X86_32
--
1.7.4.2.406.gbe91
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS
2011-04-01 5:59 [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS Len Brown
@ 2011-04-01 6:21 ` Dave Jones
2011-04-01 6:21 ` Dave Jones
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Dave Jones @ 2011-04-01 6:21 UTC (permalink / raw)
To: Len Brown; +Cc: linux-pm, x86, linux-kernel
On Fri, Apr 01, 2011 at 01:59:01AM -0400, Len Brown wrote:
> +#define ENERGY_PERF_BIAS_POWERSWAVE 15
Typo I assume.
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS
2011-04-01 5:59 [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS Len Brown
2011-04-01 6:21 ` Dave Jones
@ 2011-04-01 6:21 ` Dave Jones
2011-04-01 6:39 ` Ingo Molnar
2011-04-01 6:39 ` Ingo Molnar
3 siblings, 0 replies; 6+ messages in thread
From: Dave Jones @ 2011-04-01 6:21 UTC (permalink / raw)
To: Len Brown; +Cc: x86, linux-kernel, linux-pm
On Fri, Apr 01, 2011 at 01:59:01AM -0400, Len Brown wrote:
> +#define ENERGY_PERF_BIAS_POWERSWAVE 15
Typo I assume.
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS
2011-04-01 5:59 [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS Len Brown
` (2 preceding siblings ...)
2011-04-01 6:39 ` Ingo Molnar
@ 2011-04-01 6:39 ` Ingo Molnar
3 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2011-04-01 6:39 UTC (permalink / raw)
To: Len Brown; +Cc: linux-pm, x86, Thomas Gleixner, linux-kernel, H. Peter Anvin
* Len Brown <lenb@kernel.org> wrote:
> From: Len Brown <len.brown@intel.com>
>
> Since 2.6.36 (23016bf0d25), Linux prints the existence of "epb" in /proc/cpuinfo,
> Since 2.6.38 (d5532ee7b40), the x86_energy_perf_policy(8) utility has
> been available in-tree to update MSR_IA32_ENERGY_PERF_BIAS.
>
> However, the typical BIOS fails to initialize the MSR, presumably
> because this is handled by high-volume shrink-wrap operating systems...
>
> Linux distros, on the other hand, do not yet invoke x86_energy_perf_policy(8).
> As a result, WSM-EP, SNB, and later hardware from Intel will run in its
> default hardware power-on state (performance), which assumes that users
> care for performance at all costs and not for energy efficiency.
> While that is fine for performance benchmarks, the hardware's intended default
> operating point is "normal" mode...
>
> Initialize the MSR to the "normal" by default during kernel boot.
>
> x86_energy_perf_policy(8) is available to change the default after boot,
> should the user have a different preference.
>
> cc: stable@kernel.org
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> arch/x86/include/asm/msr-index.h | 3 +++
> arch/x86/kernel/cpu/intel.c | 14 ++++++++++++++
> 2 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
> index 43a18c7..91fedd9 100644
> --- a/arch/x86/include/asm/msr-index.h
> +++ b/arch/x86/include/asm/msr-index.h
> @@ -250,6 +250,9 @@
> #define MSR_IA32_TEMPERATURE_TARGET 0x000001a2
>
> #define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0
> +#define ENERGY_PERF_BIAS_PERFORMANCE 0
> +#define ENERGY_PERF_BIAS_NORMAL 6
> +#define ENERGY_PERF_BIAS_POWERSWAVE 15
>
> #define MSR_IA32_PACKAGE_THERM_STATUS 0x000001b1
>
> diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
> index d16c2c5..48cca4a 100644
> --- a/arch/x86/kernel/cpu/intel.c
> +++ b/arch/x86/kernel/cpu/intel.c
> @@ -448,6 +448,20 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c)
>
> if (cpu_has(c, X86_FEATURE_VMX))
> detect_vmx_virtcap(c);
> +
> + /*
> + * Initialize MSR_IA32_ENERGY_PERF_BIAS if BIOS did not.
> + * x86_energy_perf_policy(8) is available to change it at run-time
> + */
> + if (cpu_has(c, X86_FEATURE_EPB)) {
> + u64 epb;
This should be moved into a helper inline function, why complicate init_intel()
with an open-coded workaround for a BIOS bug?
> +
> + rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
> + if ((epb & 0xF) == 0) {
> + epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
So we first check that the 0xf portion of ebp is zero, then when we mask out
the 0xf portion - why? Something like this should be equivalent:
epb |= ENERGY_PERF_BIAS_NORMAL;
> + wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
> + }
> + }
Also, at minimum the kernel should printk a warning that the powersaving mode
has been reduced from 'performance' (BIOS programmed default) to 'normal'
(Intel intended default), and the message should also mention the specific
utility that can be used to set it back to 'performance'.
We risk here people reporting performance regressions to us and they will have
absolutely no chance to see what happened - the v2.6.39 kernel will just
silently be slower for them.
Also, do distributions package tools/power/x86/x86_energy_perf_policy/ for easy
access to developers? What if a user sets the BIOS to 'performance' explicitly
(is this possible?) and *expects* Linux to boot up in fast mode?
Also, will BIOSes be fixed eventually?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS
2011-04-01 5:59 [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS Len Brown
2011-04-01 6:21 ` Dave Jones
2011-04-01 6:21 ` Dave Jones
@ 2011-04-01 6:39 ` Ingo Molnar
2011-04-01 6:39 ` Ingo Molnar
3 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2011-04-01 6:39 UTC (permalink / raw)
To: Len Brown; +Cc: x86, linux-kernel, linux-pm, Thomas Gleixner, H. Peter Anvin
* Len Brown <lenb@kernel.org> wrote:
> From: Len Brown <len.brown@intel.com>
>
> Since 2.6.36 (23016bf0d25), Linux prints the existence of "epb" in /proc/cpuinfo,
> Since 2.6.38 (d5532ee7b40), the x86_energy_perf_policy(8) utility has
> been available in-tree to update MSR_IA32_ENERGY_PERF_BIAS.
>
> However, the typical BIOS fails to initialize the MSR, presumably
> because this is handled by high-volume shrink-wrap operating systems...
>
> Linux distros, on the other hand, do not yet invoke x86_energy_perf_policy(8).
> As a result, WSM-EP, SNB, and later hardware from Intel will run in its
> default hardware power-on state (performance), which assumes that users
> care for performance at all costs and not for energy efficiency.
> While that is fine for performance benchmarks, the hardware's intended default
> operating point is "normal" mode...
>
> Initialize the MSR to the "normal" by default during kernel boot.
>
> x86_energy_perf_policy(8) is available to change the default after boot,
> should the user have a different preference.
>
> cc: stable@kernel.org
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> arch/x86/include/asm/msr-index.h | 3 +++
> arch/x86/kernel/cpu/intel.c | 14 ++++++++++++++
> 2 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
> index 43a18c7..91fedd9 100644
> --- a/arch/x86/include/asm/msr-index.h
> +++ b/arch/x86/include/asm/msr-index.h
> @@ -250,6 +250,9 @@
> #define MSR_IA32_TEMPERATURE_TARGET 0x000001a2
>
> #define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0
> +#define ENERGY_PERF_BIAS_PERFORMANCE 0
> +#define ENERGY_PERF_BIAS_NORMAL 6
> +#define ENERGY_PERF_BIAS_POWERSWAVE 15
>
> #define MSR_IA32_PACKAGE_THERM_STATUS 0x000001b1
>
> diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
> index d16c2c5..48cca4a 100644
> --- a/arch/x86/kernel/cpu/intel.c
> +++ b/arch/x86/kernel/cpu/intel.c
> @@ -448,6 +448,20 @@ static void __cpuinit init_intel(struct cpuinfo_x86 *c)
>
> if (cpu_has(c, X86_FEATURE_VMX))
> detect_vmx_virtcap(c);
> +
> + /*
> + * Initialize MSR_IA32_ENERGY_PERF_BIAS if BIOS did not.
> + * x86_energy_perf_policy(8) is available to change it at run-time
> + */
> + if (cpu_has(c, X86_FEATURE_EPB)) {
> + u64 epb;
This should be moved into a helper inline function, why complicate init_intel()
with an open-coded workaround for a BIOS bug?
> +
> + rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
> + if ((epb & 0xF) == 0) {
> + epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
So we first check that the 0xf portion of ebp is zero, then when we mask out
the 0xf portion - why? Something like this should be equivalent:
epb |= ENERGY_PERF_BIAS_NORMAL;
> + wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
> + }
> + }
Also, at minimum the kernel should printk a warning that the powersaving mode
has been reduced from 'performance' (BIOS programmed default) to 'normal'
(Intel intended default), and the message should also mention the specific
utility that can be used to set it back to 'performance'.
We risk here people reporting performance regressions to us and they will have
absolutely no chance to see what happened - the v2.6.39 kernel will just
silently be slower for them.
Also, do distributions package tools/power/x86/x86_energy_perf_policy/ for easy
access to developers? What if a user sets the BIOS to 'performance' explicitly
(is this possible?) and *expects* Linux to boot up in fast mode?
Also, will BIOSes be fixed eventually?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-01 6:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-01 5:59 [PATCH 2.6.39 & -stable] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS Len Brown
2011-04-01 6:21 ` Dave Jones
2011-04-01 6:21 ` Dave Jones
2011-04-01 6:39 ` Ingo Molnar
2011-04-01 6:39 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2011-04-01 5:59 Len Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.