From: Greg KH <greg@kroah.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Abhishek Kane <v-abkane@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
virtualization@lists.osdl.org,
Mike Sterling <mike.sterling@microsoft.com>,
devel@linuxdriverproject.org
Subject: Re: [PATCH 01/12] Staging: hv: Make vmbus driver a pci driver
Date: Mon, 4 Apr 2011 21:16:00 -0700 [thread overview]
Message-ID: <20110405041600.GA8090@kroah.com> (raw)
In-Reply-To: <1300226624-27004-1-git-send-email-kys@microsoft.com>
On Tue, Mar 15, 2011 at 03:03:32PM -0700, K. Y. Srinivasan wrote:
> Make vmbus driver a pci driver. This is
> in preparation to cleaning up the root device
> management as well as the irq allocation for this
> driver.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Mike Sterling <mike.sterling@microsoft.com>
> Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
> Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
> ---
> drivers/staging/hv/vmbus_drv.c | 63 +++++++++++++++++++++++-----------------
> 1 files changed, 36 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
> index b473f46..1ef2f0f 100644
> --- a/drivers/staging/hv/vmbus_drv.c
> +++ b/drivers/staging/hv/vmbus_drv.c
> @@ -40,6 +40,8 @@
> #define VMBUS_IRQ 0x5
> #define VMBUS_IRQ_VECTOR IRQ5_VECTOR
>
> +struct pci_dev *hv_pci_dev;
Why is this global?
Have you forgot to run 'sparse' on your changes?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Mike Sterling <mike.sterling@microsoft.com>,
Abhishek Kane <v-abkane@microsoft.com>
Subject: Re: [PATCH 01/12] Staging: hv: Make vmbus driver a pci driver
Date: Mon, 4 Apr 2011 21:16:00 -0700 [thread overview]
Message-ID: <20110405041600.GA8090@kroah.com> (raw)
In-Reply-To: <1300226624-27004-1-git-send-email-kys@microsoft.com>
On Tue, Mar 15, 2011 at 03:03:32PM -0700, K. Y. Srinivasan wrote:
> Make vmbus driver a pci driver. This is
> in preparation to cleaning up the root device
> management as well as the irq allocation for this
> driver.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Signed-off-by: Mike Sterling <mike.sterling@microsoft.com>
> Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
> Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
> ---
> drivers/staging/hv/vmbus_drv.c | 63 +++++++++++++++++++++++-----------------
> 1 files changed, 36 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
> index b473f46..1ef2f0f 100644
> --- a/drivers/staging/hv/vmbus_drv.c
> +++ b/drivers/staging/hv/vmbus_drv.c
> @@ -40,6 +40,8 @@
> #define VMBUS_IRQ 0x5
> #define VMBUS_IRQ_VECTOR IRQ5_VECTOR
>
> +struct pci_dev *hv_pci_dev;
Why is this global?
Have you forgot to run 'sparse' on your changes?
thanks,
greg k-h
next prev parent reply other threads:[~2011-04-05 4:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 22:02 [PATCH 00/12] Staging: hv: Cleanup vmbus driver - Phase II K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 01/12] Staging: hv: Make vmbus driver a pci driver K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 02/12] Staging: hv: Cleanup root device handling K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 03/12] Staging: hv: Cleanup irq management K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 04/12] Staging: hv: Rename vmbus_driver_context structure K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 05/12] Get rid of the forward declaration for vmbus_uevent K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 05/12] Staging: hv: " K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 06/12] Staging: hv: Get rid of the forward declaration for vmbus_match K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 07/12] Staging: hv: Get rid of the forward declaration for vmbus_probe K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 08/12] Staging: hv: Get rid of the forward declaration for vmbus_remove K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 09/12] Staging: hv: Get rid of the forward declaration for vmbus_shutdown K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 10/12] Staging: hv: Get rid of the forward declaration for vmbus_device_release K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 11/12] Staging: hv: Get rid of the forward declaration for vmbus_isr K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:03 ` [PATCH 12/12] Staging: hv: Get rid of the forward declaration for vmbus_show_device_attr K. Y. Srinivasan
2011-03-15 22:03 ` K. Y. Srinivasan
2011-03-15 22:22 ` [PATCH 05/12] Staging: hv: Get rid of the forward declaration for vmbus_uevent Greg KH
2011-03-15 22:23 ` Greg KH
2011-03-15 22:39 ` KY Srinivasan
2011-03-15 22:51 ` Greg KH
2011-04-05 4:22 ` [PATCH 04/12] Staging: hv: Rename vmbus_driver_context structure Greg KH
2011-04-05 4:19 ` [PATCH 03/12] Staging: hv: Cleanup irq management Greg KH
2011-04-05 4:16 ` Greg KH [this message]
2011-04-05 4:16 ` [PATCH 01/12] Staging: hv: Make vmbus driver a pci driver Greg KH
2011-03-15 22:04 ` [PATCH 00/12] Staging: hv: Cleanup vmbus driver - Phase II Greg KH
2011-03-15 22:24 ` KY Srinivasan
2011-03-15 22:30 ` Greg KH
2011-03-17 21:39 ` Valdis.Kletnieks
2011-03-17 21:45 ` Greg KH
2011-03-17 22:58 ` Valdis.Kletnieks
2011-04-16 0:34 ` Greg KH
2011-04-16 0:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405041600.GA8090@kroah.com \
--to=greg@kroah.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.sterling@microsoft.com \
--cc=v-abkane@microsoft.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.