All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Natarajan Gurumoorthy <natg@google.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	Wim Van Sebroeck <wim@iguana.be>,
	Mike Waychison <mikew@google.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH] Make all it87 drivers SMP safe.
Date: Tue, 5 Apr 2011 17:05:28 -0700	[thread overview]
Message-ID: <20110406000528.GB21350@ericsson.com> (raw)
In-Reply-To: <BANLkTimQDVYe53K-M173iQtmkHzKg6Djyg@mail.gmail.com>

On Tue, Apr 05, 2011 at 07:03:35PM -0400, Natarajan Gurumoorthy wrote:
> Guenter,
>        This patch patch applies a common fix to all IT87 driver. Separating it
> into 2 patches (one for drivers/hwmon and one for drivers/watchdog) does not
> seem to be the right thing to do. I think having all the patches in one file
> makes it easier to understand the rationale behind the patch. The
> it87_io_lock.c and it87_io_lock.h files are in drivers/watchdog directory and
> the lock defined in it is needed by the changes in drivers/hwmon/it87.c
> 

I dislike the idea of a single patch crossing multiple subsystems. Maybe you'll
find another maintainer accepting your change as a single patch, but I won't.

That doesn't mean that the patches would have to be committed into multiple trees.
That is for the subsystem maintainers to sort out, and a different issue.

Thanks,
Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Natarajan Gurumoorthy <natg@google.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	Wim Van Sebroeck <wim@iguana.be>,
	Mike Waychison <mikew@google.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH] Make all it87 drivers SMP safe.
Date: Wed, 06 Apr 2011 00:05:28 +0000	[thread overview]
Message-ID: <20110406000528.GB21350@ericsson.com> (raw)
In-Reply-To: <BANLkTimQDVYe53K-M173iQtmkHzKg6Djyg@mail.gmail.com>

On Tue, Apr 05, 2011 at 07:03:35PM -0400, Natarajan Gurumoorthy wrote:
> Guenter,
>        This patch patch applies a common fix to all IT87 driver. Separating it
> into 2 patches (one for drivers/hwmon and one for drivers/watchdog) does not
> seem to be the right thing to do. I think having all the patches in one file
> makes it easier to understand the rationale behind the patch. The
> it87_io_lock.c and it87_io_lock.h files are in drivers/watchdog directory and
> the lock defined in it is needed by the changes in drivers/hwmon/it87.c
> 

I dislike the idea of a single patch crossing multiple subsystems. Maybe you'll
find another maintainer accepting your change as a single patch, but I won't.

That doesn't mean that the patches would have to be committed into multiple trees.
That is for the subsystem maintainers to sort out, and a different issue.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2011-04-06  0:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 21:24 [PATCH] Make all it87 drivers SMP safe Nat Gurumoorthy
2011-04-05 21:24 ` [lm-sensors] " Nat Gurumoorthy
2011-04-05 22:38 ` Guenter Roeck
2011-04-05 22:38   ` [lm-sensors] " Guenter Roeck
2011-04-05 23:05   ` Natarajan Gurumoorthy
2011-04-05 23:05     ` [lm-sensors] " Natarajan Gurumoorthy
2011-04-05 23:03 ` Natarajan Gurumoorthy
2011-04-06  0:05   ` Guenter Roeck [this message]
2011-04-06  0:05     ` Guenter Roeck
2011-04-06  0:13     ` Natarajan Gurumoorthy
2011-04-06  0:13       ` [lm-sensors] " Natarajan Gurumoorthy
2011-04-06  0:43       ` Guenter Roeck
2011-04-06  0:43         ` [lm-sensors] " Guenter Roeck
2011-04-06  2:50         ` Natarajan Gurumoorthy
2011-04-06  2:50           ` [lm-sensors] " Natarajan Gurumoorthy
2011-04-06  3:02           ` Guenter Roeck
2011-04-06  3:02             ` [lm-sensors] " Guenter Roeck
2011-04-06  7:04             ` Natarajan Gurumoorthy
2011-04-06  7:04               ` [lm-sensors] " Natarajan Gurumoorthy
2011-04-06 21:35               ` Paul Gortmaker
2011-04-06 21:35                 ` [lm-sensors] " Paul Gortmaker
2011-04-06 21:45                 ` Natarajan Gurumoorthy
2011-04-06 21:45                   ` [lm-sensors] " Natarajan Gurumoorthy
2011-04-06  7:19             ` Jean Delvare
2011-04-06  7:19               ` [lm-sensors] " Jean Delvare
2011-04-08 12:25 ` Alan Cox
2011-04-08 12:25   ` [lm-sensors] " Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110406000528.GB21350@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mikew@google.com \
    --cc=natg@google.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.