All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: "achew@nvidia.com" <achew@nvidia.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"w30289@motorola.com" <w30289@motorola.com>,
	"toddpoynor@google.com" <toddpoynor@google.com>,
	"wni@nvidia.com" <wni@nvidia.com>,
	"olofj@chromium.org" <olofj@chromium.org>
Subject: Re: [lm-sensors] [PATCH 1/1] [hwmon] nct1008: Initial NCT1008 driver
Date: Wed, 06 Apr 2011 07:32:22 +0000	[thread overview]
Message-ID: <20110406073222.GD23562@ericsson.com> (raw)
In-Reply-To: <20110406092358.07e8ca78@endymion.delvare>

Hi Jean,

On Wed, Apr 06, 2011 at 03:23:58AM -0400, Jean Delvare wrote:
> Hi Andrew,
> 
[ ... ]
> > +
> > +/* Register Addresses */
> > +#define LOCAL_TEMP_RD			0x00
> > +#define EXT_HI_TEMP_RD			0x01
> > +#define EXT_LO_TEMP_RD			0x10
> > +#define STATUS_RD			0x02
> > +#define CONFIG_RD			0x03
> > +
> > +#define CONFIG_WR			0x09
> > +#define CONV_RATE_WR			0x0A
> > +#define LOCAL_TEMP_HI_LIMIT_WR		0x0B
> > +#define EXT_TEMP_HI_LIMIT_HI_BYTE	0x0D
> > +#define OFFSET_WR			0x11
> > +#define EXT_THERM_LIMIT_WR		0x19
> > +#define LOCAL_THERM_LIMIT_WR		0x20
> > +#define THERM_HYSTERESIS_WR		0x21
> 
> These register definitions look very familiar to me. Have you looked at
> the lm90 driver to check has difficult it would be to add support for
> the NCT1008? I bet it will only take a few lines of code.
> 
After I spent a couple of hours reviewing the driver, I noticed that the chip is functionally
identical to ADT7461A (the only difference is the package; even the chip ID is the same),
and the ADT7461A is in turn functionally identical to ADT7461. Sigh :(.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: "achew@nvidia.com" <achew@nvidia.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"w30289@motorola.com" <w30289@motorola.com>,
	"toddpoynor@google.com" <toddpoynor@google.com>,
	"wni@nvidia.com" <wni@nvidia.com>,
	"olofj@chromium.org" <olofj@chromium.org>
Subject: Re: [PATCH 1/1] [hwmon] nct1008: Initial NCT1008 driver
Date: Wed, 6 Apr 2011 00:32:22 -0700	[thread overview]
Message-ID: <20110406073222.GD23562@ericsson.com> (raw)
In-Reply-To: <20110406092358.07e8ca78@endymion.delvare>

Hi Jean,

On Wed, Apr 06, 2011 at 03:23:58AM -0400, Jean Delvare wrote:
> Hi Andrew,
> 
[ ... ]
> > +
> > +/* Register Addresses */
> > +#define LOCAL_TEMP_RD			0x00
> > +#define EXT_HI_TEMP_RD			0x01
> > +#define EXT_LO_TEMP_RD			0x10
> > +#define STATUS_RD			0x02
> > +#define CONFIG_RD			0x03
> > +
> > +#define CONFIG_WR			0x09
> > +#define CONV_RATE_WR			0x0A
> > +#define LOCAL_TEMP_HI_LIMIT_WR		0x0B
> > +#define EXT_TEMP_HI_LIMIT_HI_BYTE	0x0D
> > +#define OFFSET_WR			0x11
> > +#define EXT_THERM_LIMIT_WR		0x19
> > +#define LOCAL_THERM_LIMIT_WR		0x20
> > +#define THERM_HYSTERESIS_WR		0x21
> 
> These register definitions look very familiar to me. Have you looked at
> the lm90 driver to check has difficult it would be to add support for
> the NCT1008? I bet it will only take a few lines of code.
> 
After I spent a couple of hours reviewing the driver, I noticed that the chip is functionally
identical to ADT7461A (the only difference is the package; even the chip ID is the same),
and the ADT7461A is in turn functionally identical to ADT7461. Sigh :(.

Guenter

  reply	other threads:[~2011-04-06  7:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06  3:06 [lm-sensors] [PATCH 1/1] [hwmon] nct1008: Initial NCT1008 driver achew
2011-04-06  3:06 ` achew
2011-04-06  5:09 ` [lm-sensors] " Guenter Roeck
2011-04-06  5:09   ` Guenter Roeck
2011-04-06  6:50   ` [lm-sensors] " Guenter Roeck
2011-04-06  6:50     ` Guenter Roeck
2011-04-06  8:01     ` Jean Delvare
2011-04-06  8:01       ` Jean Delvare
2011-04-06  7:23 ` Jean Delvare
2011-04-06  7:23   ` Jean Delvare
2011-04-06  7:32   ` Guenter Roeck [this message]
2011-04-06  7:32     ` Guenter Roeck
2011-04-06  8:15     ` [lm-sensors] " Jean Delvare
2011-04-06  8:15       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110406073222.GD23562@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=achew@nvidia.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=olofj@chromium.org \
    --cc=toddpoynor@google.com \
    --cc=w30289@motorola.com \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.