All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Avinash.H.M." <avinashhm@ti.com>
To: "Gulati, Shweta" <shweta.gulati@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Rajendra Nayak <rnayak@ti.com>, Paul Walmsley <paul@pwsan.com>,
	Benoit Cousson <b-cousson@ti.com>, Kevin Hilman <khilman@ti.com>
Subject: Re: [PATCH 2/2 v2] OMAP2/3: hwmod: fix gpio-reset timeouts seen during bootup.
Date: Thu, 7 Apr 2011 12:15:50 +0530	[thread overview]
Message-ID: <20110407064550.GA19781@avinash-laptop> (raw)
In-Reply-To: <BANLkTikwyk6b+d-QAz5LxuU_Lxgo4-A-hg@mail.gmail.com>

On Wed, Apr 06, 2011 at 11:28:00AM +0530, Gulati, Shweta wrote:
> Hi,
> 
> On Tue, Apr 5, 2011 at 9:10 PM, Avinash.H.M <avinashhm@ti.com> wrote:
> > GPIO module expects the debounce clocks to be enabled during reset. It doesn't
> > reset properly and timeouts are seen, if this clock isn't enabled during
> > reset. Add the HWMOD_CONTROL_OPT_CLKS_IN_RESET flags to the GPIO HWMODs, with
> > which the debounce clocks are enabled during reset.
> Minor comment,
> Rephrase as " GPIO module doesn't reset properly and timeouts are seen
> during bootup, if
> debounce clock is not enabled"
> to make commit log more clear.


Hi Shweta ,

thanks for the review.

i will fix the rephrase the change log .

br ,

- avinash

> > Cc: Rajendra Nayak <rnayak@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Benoit Cousson <b-cousson@ti.com>
> > Cc: Kevin Hilman <khilman@ti.com>
> > Signed-off-by: Avinash.H.M <avinashhm@ti.com>

WARNING: multiple messages have this Message-ID (diff)
From: avinashhm@ti.com (Avinash.H.M.)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2 v2] OMAP2/3: hwmod: fix gpio-reset timeouts seen during bootup.
Date: Thu, 7 Apr 2011 12:15:50 +0530	[thread overview]
Message-ID: <20110407064550.GA19781@avinash-laptop> (raw)
In-Reply-To: <BANLkTikwyk6b+d-QAz5LxuU_Lxgo4-A-hg@mail.gmail.com>

On Wed, Apr 06, 2011 at 11:28:00AM +0530, Gulati, Shweta wrote:
> Hi,
> 
> On Tue, Apr 5, 2011 at 9:10 PM, Avinash.H.M <avinashhm@ti.com> wrote:
> > GPIO module expects the debounce clocks to be enabled during reset. It doesn't
> > reset properly and timeouts are seen, if this clock isn't enabled during
> > reset. Add the HWMOD_CONTROL_OPT_CLKS_IN_RESET flags to the GPIO HWMODs, with
> > which the debounce clocks are enabled during reset.
> Minor comment,
> Rephrase as " GPIO module doesn't reset properly and timeouts are seen
> during bootup, if
> debounce clock is not enabled"
> to make commit log more clear.


Hi Shweta ,

thanks for the review.

i will fix the rephrase the change log .

br ,

- avinash

> > Cc: Rajendra Nayak <rnayak@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Benoit Cousson <b-cousson@ti.com>
> > Cc: Kevin Hilman <khilman@ti.com>
> > Signed-off-by: Avinash.H.M <avinashhm@ti.com>

  reply	other threads:[~2011-04-07  6:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 15:40 [PATCH 0/2 v2] OMAP2/3: fix the i2c,gpio reset timeouts during boot Avinash.H.M
2011-04-05 15:40 ` Avinash.H.M
2011-04-05 15:40 ` [PATCH 1/2 v2] OMAP2/3: hwmod: fix the i2c-reset timeout during bootup Avinash.H.M
2011-04-05 15:40   ` Avinash.H.M
2011-04-05 18:27   ` Kevin Hilman
2011-04-05 18:27     ` Kevin Hilman
2011-04-07  6:42     ` Mahadeva, Avinash
2011-04-07  6:42       ` Mahadeva, Avinash
2011-04-05 15:40 ` [PATCH 2/2 v2] OMAP2/3: hwmod: fix gpio-reset timeouts seen " Avinash.H.M
2011-04-05 15:40   ` Avinash.H.M
2011-04-06  5:58   ` Gulati, Shweta
2011-04-06  5:58     ` Gulati, Shweta
2011-04-07  6:45     ` Avinash.H.M. [this message]
2011-04-07  6:45       ` Avinash.H.M.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110407064550.GA19781@avinash-laptop \
    --to=avinashhm@ti.com \
    --cc=b-cousson@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    --cc=shweta.gulati@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.