* [PATCH] ASoC: sn95031: decorate function with __devexit_p()
@ 2011-04-09 15:03 Lu Guanqun
2011-04-11 19:55 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Lu Guanqun @ 2011-04-09 15:03 UTC (permalink / raw)
To: ALSA, Lu Guanqun
Cc: Koul Vinod, Takashi Iwai, Liam Girdwood, Harsha Priya, Mark Brown
According to the comments in include/linux/init.h:
"Pointers to __devexit functions must use __devexit_p(function_name), the
wrapper will insert either the function_name or NULL, depending on the config
options."
Fix this issue in codecs sn95031.
Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
---
sound/soc/codecs/sn95031.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/sn95031.c b/sound/soc/codecs/sn95031.c
index 569555f..f70977d 100644
--- a/sound/soc/codecs/sn95031.c
+++ b/sound/soc/codecs/sn95031.c
@@ -918,7 +918,7 @@ static struct platform_driver sn95031_codec_driver = {
.owner = THIS_MODULE,
},
.probe = sn95031_device_probe,
- .remove = sn95031_device_remove,
+ .remove = __devexit_p(sn95031_device_remove),
};
static int __init sn95031_init(void)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: sn95031: decorate function with __devexit_p()
2011-04-09 15:03 [PATCH] ASoC: sn95031: decorate function with __devexit_p() Lu Guanqun
@ 2011-04-11 19:55 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2011-04-11 19:55 UTC (permalink / raw)
To: Lu Guanqun; +Cc: ALSA, Koul Vinod, Brown, Mark, Takashi Iwai, Harsha Priya
On Sat, 2011-04-09 at 23:03 +0800, Lu Guanqun wrote:
> According to the comments in include/linux/init.h:
>
> "Pointers to __devexit functions must use __devexit_p(function_name), the
> wrapper will insert either the function_name or NULL, depending on the config
> options."
>
> Fix this issue in codecs sn95031.
>
> Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
> ---
> sound/soc/codecs/sn95031.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/sn95031.c b/sound/soc/codecs/sn95031.c
> index 569555f..f70977d 100644
> --- a/sound/soc/codecs/sn95031.c
> +++ b/sound/soc/codecs/sn95031.c
> @@ -918,7 +918,7 @@ static struct platform_driver sn95031_codec_driver = {
> .owner = THIS_MODULE,
> },
> .probe = sn95031_device_probe,
> - .remove = sn95031_device_remove,
> + .remove = __devexit_p(sn95031_device_remove),
> };
>
> static int __init sn95031_init(void)
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-11 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-09 15:03 [PATCH] ASoC: sn95031: decorate function with __devexit_p() Lu Guanqun
2011-04-11 19:55 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.