Re: [RFT] p54: implement multicast + arp req PS filter

[Max Filippov <jcmvbkbc@gmail.com>]

> > > > In the multicast case filter seems to work correctly, but it treats broadcast
> > > > as subject to that filtering too. By default only 01:00:5e:00:00:01 gets into
> > > > priv->mc_maclist, so we miss all broadcasts.
> > > ok, so we have to reserve a spot for ff:ff:ff:ff:ff:ff.
> > 
> > But currently that cancels ARP filtering completely.
> 
> Ok, so we can't have both [atm] and we can't really choose between them either.
> Or do you think it's worth salvaging the multicast filter for a [PATCH]?

Well, multicast filtering appears to work good with that additional broadcast entry. So, why not.

> > > interesting, well a unnamed [but trustworthy] source told us that ST identified
> > > a problem with the arp/multicast filter some time ago, unfortunately I haven't
> > > seen any updated p54spi firmwares lately. Maybe this sagred stuff works?
> > 
> > "sagred stuff" ?
> yeah, it was a while ago... 
> "p54spi (STLC4560) with Marvel XScale CPU (kernel 2.6.25.4)"
> http://www.spinics.net/lists/linux-wireless/msg55967.html
> 
> AFAIK they have another p54spi firmware
> "phy0: FW rev 2.19.0.0.A.14 Private - Softmac protocol 5.6"

Ok, I'll try to test it with firmware images other than nokia's native.

Thanks.
-- Max