From: Wolfram Sang <w.sang@pengutronix.de>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v4] mmc: sdhci: add error checking for mmc_add_host
Date: Mon, 11 Apr 2011 07:59:59 +0200 [thread overview]
Message-ID: <20110411055959.GE20437@pengutronix.de> (raw)
In-Reply-To: <4DA289D2.7010501@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
> You means that didn't run start_host() before add_host failed.
> I think that need not to run stop_host. right?
Right, and other stuff like registering the pm_notifier.
> To use mmc_free_host, better than mmc_remove_host.
That would be true for most drivers. However, sdhci has encapsulated this in
its own sdhci_free_host. So, you don't need to call this as well.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2011-04-11 6:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 2:11 [PATCH v4] mmc: sdhci: add error checking for mmc_add_host Jaehoon Chung
2011-04-11 3:04 ` Wolfram Sang
2011-04-11 4:16 ` Jaehoon Chung
2011-04-11 4:40 ` Wolfram Sang
2011-04-11 4:55 ` Jaehoon Chung
2011-04-11 5:59 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411055959.GE20437@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.