From: Jaehoon Chung <jh80.chung@samsung.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v4] mmc: sdhci: add error checking for mmc_add_host
Date: Mon, 11 Apr 2011 13:55:46 +0900 [thread overview]
Message-ID: <4DA289D2.7010501@samsung.com> (raw)
In-Reply-To: <20110411044022.GD20437@pengutronix.de>
Wolfram Sang wrote:
>> I just think good that remove the host...(any crash didn't occur).
>> there is not special reason.
>
> Look at the mmc-core code, please (host.c). Compare what remove_host does and
> what add_host does before it fails. What do you think?
Ok..i'm looking at the mmc-core code(host.c)
mmc_add_host does devices_add(), then run start_host().
mmc_remove_host does stop_host().
You means that didn't run start_host() before add_host failed.
I think that need not to run stop_host. right?
To use mmc_free_host, better than mmc_remove_host.
Regards,
Jaehoon Chung
>
> Regards,
>
> Wolfram
>
next prev parent reply other threads:[~2011-04-11 4:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 2:11 [PATCH v4] mmc: sdhci: add error checking for mmc_add_host Jaehoon Chung
2011-04-11 3:04 ` Wolfram Sang
2011-04-11 4:16 ` Jaehoon Chung
2011-04-11 4:40 ` Wolfram Sang
2011-04-11 4:55 ` Jaehoon Chung [this message]
2011-04-11 5:59 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA289D2.7010501@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.