Re: [PATCH V3 1/5] sound: asoc: Adding support for STA529 Audio Codec

[Lu Guanqun <guanqun.lu@intel.com>]

On Mon, Apr 11, 2011 at 09:35:01PM +0800, Mark Brown wrote:
> On Mon, Apr 11, 2011 at 08:53:18PM +0800, Lu Guanqun wrote:
> 
> Please *always* delete irrelevant context from replies - it makes it
> much easier to find the new text.

Sure.

> > > +static int __init sta529_modinit(void)
> > > +{
> > > +       int ret = 0;
> > > +
> > > +       ret = i2c_add_driver(&sta529_i2c_driver);
> > 
> > As an idiom, I often see the above code surrounded with an #ifdef, see
> > below code snippet from sound/soc/codecs/wm8974.c
> 
> This is only for devices that support more than one control interface.
> If the device only supports one control interface there is no need to
> make anything conditional.

Well, but there are many codecs which support only one control interface
while having this #ifdef condition...

-- 
guanqun