Re: [PATCH V3 1/5] sound: asoc: Adding support for STA529 Audio Codec

[rajeev <rajeev-dlh.kumar@st.com>]

Hi Mark
     
On 4/20/2011 4:26 PM, Mark Brown wrote:
> On Wed, Apr 20, 2011 at 09:54:47AM +0530, rajeev wrote:
>> On 4/11/2011 8:26 PM, Mark Brown wrote:
>>> On Mon, Apr 11, 2011 at 11:00:00AM +0530, Rajeev Kumar wrote:
> 
>>>> +static const char *op_mode_text[] = { "slave", "master"};
> 
>>> What is op_mode?  This sounds like it should be configured by
>>> set_dai_fmt()...
> 
>> OK, I will change the name.
> 
> You're missing the point here.  The name isn't an issue.
> 
Oops
Got the point, ThanX

>> This patch set has been compiled and tested for Linux-kernel-version 2.6.38-rc4,
>> since SPEAr patches for this linux version are already under review in Russel King's
>> ARM branch.This version does not have snd_soc_cache_sync() function. 
> 
> This isn't how mainline works.  You're not submitting code against some
> old, released kernel version.  You're submitting code for the
> development version of the kernel and need to fit in with that.  Code
> for an older kernel may not even compile with current development
> kernels.  For integration testing -next is often a good bet.
> .
> 
OK, I will do the changes as per your guidelines.

best rgds
Rajeev