All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: stefano.stabellini@eu.citrix.com
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	jeremy@goop.org, yinghai@kernel.org, hpa@linux.intel.com,
	mingo@elte.hu
Subject: Re: [PATCH 1/4] xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf_top
Date: Tue, 12 Apr 2011 12:47:45 -0400	[thread overview]
Message-ID: <20110412164745.GB1067@dumpdata.com> (raw)
In-Reply-To: <1302607192-21355-1-git-send-email-stefano.stabellini@eu.citrix.com>

On Tue, Apr 12, 2011 at 12:19:49PM +0100, stefano.stabellini@eu.citrix.com wrote:
> From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> mask_rw_pte is currently checking if a pfn is a pagetable page if it
> falls in the range pgt_buf_start - pgt_buf_end but that is incorrect
> because pgt_buf_end is a moving target: pgt_buf_top is the real
> boundary.

OK. Stuck it on the queue for rc3.

> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
>  arch/x86/xen/mmu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index c82df6c..6b833db 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -1491,7 +1491,7 @@ static __init pte_t mask_rw_pte(pte_t *ptep, pte_t pte)
>  	 * it is RO.
>  	 */
>  	if (((!is_early_ioremap_ptep(ptep) &&
> -			pfn >= pgt_buf_start && pfn < pgt_buf_end)) ||
> +			pfn >= pgt_buf_start && pfn < pgt_buf_top)) ||
>  			(is_early_ioremap_ptep(ptep) && pfn != (pgt_buf_end - 1)))
>  		pte = pte_wrprotect(pte);
>  
> -- 
> 1.7.2.3

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: stefano.stabellini@eu.citrix.com
Cc: jeremy@goop.org, xen-devel@lists.xensource.com,
	linux-kernel@vger.kernel.org, mingo@elte.hu, hpa@linux.intel.com,
	yinghai@kernel.org
Subject: Re: [PATCH 1/4] xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf_top
Date: Tue, 12 Apr 2011 12:47:45 -0400	[thread overview]
Message-ID: <20110412164745.GB1067@dumpdata.com> (raw)
In-Reply-To: <1302607192-21355-1-git-send-email-stefano.stabellini@eu.citrix.com>

On Tue, Apr 12, 2011 at 12:19:49PM +0100, stefano.stabellini@eu.citrix.com wrote:
> From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> mask_rw_pte is currently checking if a pfn is a pagetable page if it
> falls in the range pgt_buf_start - pgt_buf_end but that is incorrect
> because pgt_buf_end is a moving target: pgt_buf_top is the real
> boundary.

OK. Stuck it on the queue for rc3.

> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
>  arch/x86/xen/mmu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index c82df6c..6b833db 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -1491,7 +1491,7 @@ static __init pte_t mask_rw_pte(pte_t *ptep, pte_t pte)
>  	 * it is RO.
>  	 */
>  	if (((!is_early_ioremap_ptep(ptep) &&
> -			pfn >= pgt_buf_start && pfn < pgt_buf_end)) ||
> +			pfn >= pgt_buf_start && pfn < pgt_buf_top)) ||
>  			(is_early_ioremap_ptep(ptep) && pfn != (pgt_buf_end - 1)))
>  		pte = pte_wrprotect(pte);
>  
> -- 
> 1.7.2.3

  reply	other threads:[~2011-04-12 16:48 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 11:16 [PATCH 0/4] xen: critical bug fixes for 2.6.39-rc3 Stefano Stabellini
2011-04-12 11:16 ` Stefano Stabellini
2011-04-12 11:19 ` [PATCH 1/4] xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf_top stefano.stabellini
2011-04-12 16:47   ` Konrad Rzeszutek Wilk [this message]
2011-04-12 16:47     ` Konrad Rzeszutek Wilk
2011-04-13 10:24     ` Stefano Stabellini
2011-04-12 11:19 ` [PATCH 2/4] x86,xen: introduce x86_init.mapping.pagetable_reserve stefano.stabellini
2011-04-12 11:50   ` [Xen-devel] [PATCH 2/4] x86, xen: " Jan Beulich
2011-04-12 11:50     ` Jan Beulich
2011-04-12 17:41     ` Stefano Stabellini
2011-04-12 17:41       ` Stefano Stabellini
2011-04-12 17:40   ` [PATCH 2/4] x86,xen: " Yinghai Lu
2011-04-13 10:35     ` Stefano Stabellini
2011-04-13 10:35       ` Stefano Stabellini
2011-04-13 18:28       ` H. Peter Anvin
2011-04-14 11:05         ` Stefano Stabellini
2011-04-13 18:03     ` Konrad Rzeszutek Wilk
2011-04-13 18:35       ` H. Peter Anvin
2011-04-13 18:35         ` [PATCH 2/4] x86, xen: " H. Peter Anvin
2011-04-13 20:19         ` [PATCH 2/4] x86,xen: " Konrad Rzeszutek Wilk
2011-04-13 18:26   ` H. Peter Anvin
2011-04-14 11:30     ` Stefano Stabellini
2011-04-14 14:49       ` Stefano Stabellini
2011-04-14 14:49         ` Stefano Stabellini
2011-04-14 14:52       ` H. Peter Anvin
2011-04-14 18:09         ` Stefano Stabellini
2011-04-18 14:09           ` Stefano Stabellini
2011-04-18 14:42             ` H. Peter Anvin
2011-04-18 17:21               ` Stefano Stabellini
2011-04-20 16:50               ` Jeremy Fitzhardinge
2011-04-12 11:19 ` [PATCH 3/4] xen: more debugging in the e820 parsing stefano.stabellini
2011-04-12 16:39   ` Konrad Rzeszutek Wilk
2011-04-13 10:24     ` Stefano Stabellini
2011-04-13 17:54       ` Konrad Rzeszutek Wilk
2011-04-14 10:35         ` Stefano Stabellini
2011-04-12 11:19 ` [PATCH 4/4] xen: do not create the extra e820 region at an addr lower than 4G stefano.stabellini
2011-04-12 16:48   ` Konrad Rzeszutek Wilk
2011-04-12 16:48     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110412164745.GB1067@dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=hpa@linux.intel.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.