All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Yogesh Ashok Powar <yogeshp@marvell.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH] mwl8k: Fix checkpatch.pl and sparse warnings and errors
Date: Tue, 12 Apr 2011 16:28:32 -0400	[thread overview]
Message-ID: <20110412202831.GC24309@tuxdriver.com> (raw)
In-Reply-To: <20110408185529.GA26751@hertz.marvell.com>

On Sat, Apr 09, 2011 at 12:25:37AM +0530, Yogesh Ashok Powar wrote:
> Fix checkpatch errors and warnings comprising of indent errors, spaces and
> __packed warnings. Also fix 'make C = 2' warnings.
> 
> Signed-off-by: Yogesh Ashok Powar <yogeshp@marvell.com>
> ---
>  drivers/net/wireless/mwl8k.c |   27 +++++++++++++--------------
>  1 files changed, 13 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c
> index 8913180..fb472f4 100644
> --- a/drivers/net/wireless/mwl8k.c
> +++ b/drivers/net/wireless/mwl8k.c
> @@ -701,7 +701,7 @@ static int mwl8k_load_firmware(struct ieee80211_hw *hw)
>  			       "helper image\n", pci_name(priv->pdev));
>  			return rc;
>  		}
> -		msleep(5);
> +		msleep(20);
>  
>  		rc = mwl8k_feed_fw_image(priv, fw->data, fw->size);
>  	} else {

Is this an indent error, a space, or a __packed warning??

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2011-04-12 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 18:55 [PATCH] mwl8k: Fix checkpatch.pl and sparse warnings and errors Yogesh Ashok Powar
2011-04-12 20:28 ` John W. Linville [this message]
2011-04-13  3:59   ` Yogesh Ashok Powar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110412202831.GC24309@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=buytenh@wantstofly.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=yogeshp@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.