From: Christoph Egger <Christoph.Egger@amd.com>
To: xen-devel@lists.xensource.com
Cc: Keir Fraser <keir.xen@gmail.com>
Subject: Re: [PATCH] nestedhvm: ASID emulation (cleanup)
Date: Wed, 13 Apr 2011 15:20:21 +0200 [thread overview]
Message-ID: <201104131520.23648.Christoph.Egger@amd.com> (raw)
In-Reply-To: <C9CB5E73.1644B%keir.xen@gmail.com>
On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote:
> On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> > Cleanup for ASID emulation:
> > - Use C99 integer types for asid numbers
> >
> > - asid.c: consistently use 'v' instead of 'curr'
>
> On what planet is that an improvement??
>
> We use 'curr' as a convenient idiom to represent cached current. Whereas
> 'v' is supposed to represent an arbitrary vcpu.
Oh, that's the difference. I thought 'curr' is just another random name for an
arbitrary vcpu.
I will resend the patch w/o that hunk.
>
> I know it costs three extra characters per use, but it does make code
> easier to understand.
>
> -- Keir
>
> > - Introduce svm_invlpga() used in ASID emulation patch
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-04-13 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 10:35 [PATCH] nestedhvm: ASID emulation (cleanup) Christoph Egger
2011-04-13 13:06 ` Keir Fraser
2011-04-13 13:20 ` Christoph Egger [this message]
2011-04-13 13:28 ` Keir Fraser
2011-04-13 14:27 ` Christoph Egger
2011-04-13 13:49 ` Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104131520.23648.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.