From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/5] ASoC: Call snd_soc_new_widgets() after registering cards DAPM widgets
Date: Wed, 13 Apr 2011 10:32:49 -0700 [thread overview]
Message-ID: <20110413173249.GC18008@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4DA597E3.807@metafoo.de>
On Wed, Apr 13, 2011 at 02:32:35PM +0200, Lars-Peter Clausen wrote:
> But snd_soc_dapm_new_widgets also calls dapm_power_widgets which operates on
> the passed dapm_context, will it be without any effect on the DAPM context,
> when it is called on a newly allocated context?
Yup.
> Otherwise I would say call snd_soc_dapm_new_widgets once for the cards
> dapm_context and snd_soc_dapm_sync for each codec context.
There's no point in repeatedly syncing - it may cause audible issues if
we power things off due to incomplete information. If the sync isn't
propagating over the entire system we should fix that.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ASoC: Call snd_soc_new_widgets() after registering cards DAPM widgets
Date: Wed, 13 Apr 2011 10:32:49 -0700 [thread overview]
Message-ID: <20110413173249.GC18008@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4DA597E3.807@metafoo.de>
On Wed, Apr 13, 2011 at 02:32:35PM +0200, Lars-Peter Clausen wrote:
> But snd_soc_dapm_new_widgets also calls dapm_power_widgets which operates on
> the passed dapm_context, will it be without any effect on the DAPM context,
> when it is called on a newly allocated context?
Yup.
> Otherwise I would say call snd_soc_dapm_new_widgets once for the cards
> dapm_context and snd_soc_dapm_sync for each codec context.
There's no point in repeatedly syncing - it may cause audible issues if
we power things off due to incomplete information. If the sync isn't
propagating over the entire system we should fix that.
next prev parent reply other threads:[~2011-04-13 17:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 17:31 [PATCH 1/5] ASoC: Make struct snd_soc_card's dapm_widgets and dapm_routes const Lars-Peter Clausen
2011-04-12 17:31 ` Lars-Peter Clausen
2011-04-12 17:31 ` [PATCH 2/5] ASoC: Call snd_soc_new_widgets() after registering cards DAPM widgets Lars-Peter Clausen
2011-04-12 17:31 ` Lars-Peter Clausen
2011-04-13 0:38 ` Mark Brown
2011-04-13 0:38 ` Mark Brown
2011-04-13 12:32 ` Lars-Peter Clausen
2011-04-13 12:32 ` Lars-Peter Clausen
2011-04-13 17:32 ` Mark Brown [this message]
2011-04-13 17:32 ` Mark Brown
2011-04-13 19:26 ` Lars-Peter Clausen
2011-04-12 17:31 ` [PATCH 3/5] ASoC: JZ4740: Convert qi_lb60 codec to table based DAPM setup Lars-Peter Clausen
2011-04-12 17:31 ` Lars-Peter Clausen
2011-04-12 17:31 ` [PATCH 4/5] ASoC: JZ4740: qi_lb60: Use gpio_request_array to request and setup gpios Lars-Peter Clausen
2011-04-12 17:31 ` Lars-Peter Clausen
2011-04-12 17:31 ` [PATCH 5/5] ASoC: JZ4740: qi_lb60: Use the SND_SOC_DAPM_EVENT_OFF for the speakers status Lars-Peter Clausen
2011-04-12 17:31 ` Lars-Peter Clausen
2011-04-13 7:39 ` [PATCH 1/5] ASoC: Make struct snd_soc_card's dapm_widgets and dapm_routes const Liam Girdwood
2011-04-13 7:39 ` [alsa-devel] " Liam Girdwood
2011-04-13 17:36 ` Mark Brown
2011-04-13 17:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413173249.GC18008@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.