From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Huang Shijie <b32955@freescale.com>
Cc: s.hauer@pengutronix.de, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: mxs: add GPMI support for imx23/imx28
Date: Fri, 15 Apr 2011 10:42:30 +0200 [thread overview]
Message-ID: <20110415084230.GN31990@pengutronix.de> (raw)
In-Reply-To: <4DA7FE37.7030808@freescale.com>
On Fri, Apr 15, 2011 at 04:13:43PM +0800, Huang Shijie wrote:
> >On Fri, Apr 15, 2011 at 04:01:47PM +0800, Huang Shijie wrote:
> >>+#define GPMI_NFC_DRIVER_NAME "gpmi-nfc"
> >>+#define GPMI_NFC_DRIVER_MX23 "imx23-gpmi-nfc"
> >>+#define GPMI_NFC_DRIVER_MX28 "imx28-gpmi-nfc"
> >>+#define GPMI_NFC_DRIVER_MX50 "imx50-gpmi-nfc"
> >Is it sensible to keep these when they are only used in a single .c
> >file?
> >
> I also use these in gpmi driver for distinguish platform id.
> Do i have to remove these lines , and use the hardcode?
Ah, I missed the usage in the header. *shrug*, I don't care much, but
I'd use hardcoding.
BTW, as the driver name is gpmi-nfc this should be used for the various
names introduced in this patch set. (i.e. mx28_add_gpmi_nfc,
MXS_HAS_PLATFORM_GPMI_NFC etc.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: mxs: add GPMI support for imx23/imx28
Date: Fri, 15 Apr 2011 10:42:30 +0200 [thread overview]
Message-ID: <20110415084230.GN31990@pengutronix.de> (raw)
In-Reply-To: <4DA7FE37.7030808@freescale.com>
On Fri, Apr 15, 2011 at 04:13:43PM +0800, Huang Shijie wrote:
> >On Fri, Apr 15, 2011 at 04:01:47PM +0800, Huang Shijie wrote:
> >>+#define GPMI_NFC_DRIVER_NAME "gpmi-nfc"
> >>+#define GPMI_NFC_DRIVER_MX23 "imx23-gpmi-nfc"
> >>+#define GPMI_NFC_DRIVER_MX28 "imx28-gpmi-nfc"
> >>+#define GPMI_NFC_DRIVER_MX50 "imx50-gpmi-nfc"
> >Is it sensible to keep these when they are only used in a single .c
> >file?
> >
> I also use these in gpmi driver for distinguish platform id.
> Do i have to remove these lines , and use the hardcode?
Ah, I missed the usage in the header. *shrug*, I don't care much, but
I'd use hardcoding.
BTW, as the driver name is gpmi-nfc this should be used for the various
names introduced in this patch set. (i.e. mx28_add_gpmi_nfc,
MXS_HAS_PLATFORM_GPMI_NFC etc.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-04-15 8:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 8:01 [PATCH 1/2] ARM: mxs: add GPMI support for imx23/imx28 Huang Shijie
2011-04-15 8:01 ` Huang Shijie
2011-04-15 8:01 ` [PATCH 2/2] ARM: mxs: add GPMI device " Huang Shijie
2011-04-15 8:01 ` Huang Shijie
2011-04-15 8:12 ` Uwe Kleine-König
2011-04-15 8:12 ` Uwe Kleine-König
2011-04-15 8:33 ` Huang Shijie
2011-04-15 8:33 ` Huang Shijie
2011-04-15 8:06 ` [PATCH 1/2] ARM: mxs: add GPMI support " Uwe Kleine-König
2011-04-15 8:06 ` Uwe Kleine-König
2011-04-15 8:13 ` Huang Shijie
2011-04-15 8:13 ` Huang Shijie
2011-04-15 8:42 ` Uwe Kleine-König [this message]
2011-04-15 8:42 ` Uwe Kleine-König
2011-04-15 8:50 ` Huang Shijie
2011-04-15 8:50 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415084230.GN31990@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.