From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "wni@nvidia.com" <wni@nvidia.com>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"olofj@chromium.org" <olofj@chromium.org>,
"achew@nvidia.com" <achew@nvidia.com>
Subject: Re: [lm-sensors] [PATCH 2/3] hwmon (lm90) Support to configure
Date: Fri, 15 Apr 2011 15:46:08 +0000 [thread overview]
Message-ID: <20110415154608.GA24844@ericsson.com> (raw)
In-Reply-To: <1302865228-7185-3-git-send-email-wni@nvidia.com>
On Fri, Apr 15, 2011 at 07:00:27AM -0400, wni@nvidia.com wrote:
> From: Wei Ni <wni@nvidia.com>
>
> This patch add support to configure nct1008 from platform data.
>
In my opinion those enhancments should not only be for nct1008 but
apply to all chips, ie be made generic. Not even supporting the functionally
identical chips does not make sense to me at all.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "wni@nvidia.com" <wni@nvidia.com>
Cc: "khali@linux-fr.org" <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"olofj@chromium.org" <olofj@chromium.org>,
"achew@nvidia.com" <achew@nvidia.com>
Subject: Re: [PATCH 2/3] hwmon (lm90) Support to configure nct1008 from platform data
Date: Fri, 15 Apr 2011 08:46:08 -0700 [thread overview]
Message-ID: <20110415154608.GA24844@ericsson.com> (raw)
In-Reply-To: <1302865228-7185-3-git-send-email-wni@nvidia.com>
On Fri, Apr 15, 2011 at 07:00:27AM -0400, wni@nvidia.com wrote:
> From: Wei Ni <wni@nvidia.com>
>
> This patch add support to configure nct1008 from platform data.
>
In my opinion those enhancments should not only be for nct1008 but
apply to all chips, ie be made generic. Not even supporting the functionally
identical chips does not make sense to me at all.
Guenter
next prev parent reply other threads:[~2011-04-15 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 11:00 [lm-sensors] [PATCH 0/3] hwmon (lm90) add some function for lm90 wni
2011-04-15 11:00 ` wni
2011-04-15 11:00 ` [lm-sensors] [PATCH 1/3] hwmon: (lm90) Add suspend/resume support wni
2011-04-15 11:00 ` wni
2011-04-15 11:00 ` [lm-sensors] [PATCH 2/3] hwmon (lm90) Support to configure nct1008 wni
2011-04-15 11:00 ` [PATCH 2/3] hwmon (lm90) Support to configure nct1008 from platform data wni
2011-04-15 15:46 ` Guenter Roeck [this message]
2011-04-15 15:46 ` Guenter Roeck
2011-04-15 11:00 ` [lm-sensors] [PATCH 3/3] hwmon (lm90) Add alarm function for nct1008 wni
2011-04-15 11:00 ` wni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110415154608.GA24844@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=achew@nvidia.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=olofj@chromium.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.