From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (jc42) Change I2C detection class
Date: Sat, 16 Apr 2011 15:45:00 +0000 [thread overview]
Message-ID: <20110416154500.GA31343@ericsson.com> (raw)
In-Reply-To: <20110416141713.333d6e51@endymion.delvare>
On Sat, Apr 16, 2011 at 10:58:24AM -0400, Guenter Roeck wrote:
> On Sat, Apr 16, 2011 at 08:17:13AM -0400, Jean Delvare wrote:
> > While the JC42-compatible chips are temperature sensors, I2C_CLASS_SPD
> > makes more sense because these chips always live on memory modules.
> >
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > ---
> > Guenter, what do you think?
> >
> I don't know. Seems odd to define a device based on its location instead of its functionality.
>
> What is the device class used for anyway ? I browsed through the code, but did not find it.
>
Never mind, I found it, and understand your reasoning now. Ok with me.
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-04-16 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-16 12:17 [lm-sensors] [PATCH] hwmon: (jc42) Change I2C detection class Jean Delvare
2011-04-16 14:58 ` Guenter Roeck
2011-04-16 15:45 ` Guenter Roeck [this message]
2011-04-16 16:06 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110416154500.GA31343@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.