From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] leds: provide helper to register "leds-gpio" devices
Date: Tue, 19 Apr 2011 16:19:13 -0700 [thread overview]
Message-ID: <20110419161913.a1c18599.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110405163338.GA11832@n2100.arm.linux.org.uk>
On Tue, 5 Apr 2011 17:33:39 +0100
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Tue, Apr 05, 2011 at 10:37:35AM +0200, Uwe Kleine-K__nig wrote:
> > +struct platform_device *__init gpio_led_register_device(
> > + const struct gpio_led_platform_data *pdata);
>
> Please don't add __init annotations to declarations.
Reasons?
A year or so ago we had to *add* an __init to a declaration, because
one architecture was generating a short-mode-addressing relative branch
to the callee, assuming the target was in the same section as the call
site. When the linker went to resolve the branch, it discovered that
the target was in fact in a different section and was too far away to
be able to use the short-mode addressing. IIRC, that architecture was
arm.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Richard Purdie" <rpurdie@rpsys.net>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"H Hartley Sweeten" <hartleys@visionengravers.com>,
"Fabio Estevam" <fabio.estevam@freescale.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
kernel@pengutronix.de
Subject: Re: [PATCH] leds: provide helper to register "leds-gpio" devices
Date: Tue, 19 Apr 2011 16:19:13 -0700 [thread overview]
Message-ID: <20110419161913.a1c18599.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110405163338.GA11832@n2100.arm.linux.org.uk>
On Tue, 5 Apr 2011 17:33:39 +0100
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Tue, Apr 05, 2011 at 10:37:35AM +0200, Uwe Kleine-K__nig wrote:
> > +struct platform_device *__init gpio_led_register_device(
> > + const struct gpio_led_platform_data *pdata);
>
> Please don't add __init annotations to declarations.
Reasons?
A year or so ago we had to *add* an __init to a declaration, because
one architecture was generating a short-mode-addressing relative branch
to the callee, assuming the target was in the same section as the call
site. When the linker went to resolve the branch, it discovered that
the target was in fact in a different section and was too far away to
be able to use the short-mode addressing. IIRC, that architecture was
arm.
next prev parent reply other threads:[~2011-04-19 23:19 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 17:06 [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds Fabio Estevam
2011-04-04 17:06 ` [PATCH v2 2/2] ARM: mx5/mx53_evk.c: Add LED support Fabio Estevam
2011-04-04 17:19 ` [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds Sascha Hauer
2011-04-04 17:42 ` Uwe Kleine-König
2011-04-04 17:52 ` Russell King - ARM Linux
2011-04-04 18:06 ` H Hartley Sweeten
2011-04-04 18:17 ` Russell King - ARM Linux
2011-04-04 21:52 ` H Hartley Sweeten
2011-04-05 7:30 ` Uwe Kleine-König
2011-04-05 7:40 ` Russell King - ARM Linux
2011-04-05 7:43 ` Uwe Kleine-König
2011-04-05 7:47 ` Russell King - ARM Linux
2011-04-05 7:51 ` Uwe Kleine-König
2011-04-05 7:59 ` Russell King - ARM Linux
2011-04-05 8:32 ` Uwe Kleine-König
2011-04-05 8:43 ` Russell King - ARM Linux
2011-04-05 8:46 ` Uwe Kleine-König
2011-04-05 8:37 ` [PATCH] leds: provide helper to register "leds-gpio" devices Uwe Kleine-König
2011-04-05 8:37 ` Uwe Kleine-König
2011-04-05 16:13 ` Fabio Estevam
2011-04-05 16:13 ` Fabio Estevam
2011-04-05 16:29 ` Fabio Estevam
2011-04-05 16:29 ` Fabio Estevam
2011-04-05 18:12 ` H Hartley Sweeten
2011-04-05 18:12 ` H Hartley Sweeten
2011-04-05 16:33 ` Russell King - ARM Linux
2011-04-05 16:33 ` Russell King - ARM Linux
2011-04-05 20:24 ` [PATCH v2] " Uwe Kleine-König
2011-04-05 20:24 ` Uwe Kleine-König
2011-04-06 11:45 ` Fabio Estevam
2011-04-06 11:45 ` Fabio Estevam
2011-04-06 11:52 ` Richard Purdie
2011-04-06 11:52 ` Richard Purdie
2011-04-06 12:33 ` Uwe Kleine-König
2011-04-06 12:33 ` Uwe Kleine-König
2011-04-06 13:38 ` Richard Purdie
2011-04-06 13:38 ` Richard Purdie
2011-04-11 20:35 ` [PATCH v3] " Uwe Kleine-König
2011-04-11 20:35 ` Uwe Kleine-König
2011-04-12 21:48 ` Russell King - ARM Linux
2011-04-12 21:48 ` Russell King - ARM Linux
2011-04-13 6:23 ` Uwe Kleine-König
2011-04-13 6:23 ` Uwe Kleine-König
2011-05-06 21:03 ` Richard Purdie
2011-05-06 21:03 ` Richard Purdie
2011-05-09 8:00 ` Uwe Kleine-König
2011-05-09 8:00 ` Uwe Kleine-König
2011-04-26 15:08 ` Uwe Kleine-König
2011-04-26 15:08 ` Uwe Kleine-König
2011-05-06 8:25 ` Uwe Kleine-König
2011-05-06 8:25 ` Uwe Kleine-König
2011-05-09 22:02 ` Andrew Morton
2011-05-09 22:02 ` Andrew Morton
2011-05-09 22:17 ` Russell King - ARM Linux
2011-05-09 22:17 ` Russell King - ARM Linux
2011-05-10 6:45 ` Uwe Kleine-König
2011-05-10 6:45 ` Uwe Kleine-König
2011-05-10 7:31 ` Uwe Kleine-König
2011-05-10 7:31 ` Uwe Kleine-König
2011-05-10 8:50 ` [PATCH v4] " Uwe Kleine-König
2011-05-10 8:50 ` Uwe Kleine-König
2011-05-10 8:50 ` [PATCH] [wip] ARM: imx: register "leds-gpio" device using new helper function Uwe Kleine-König
2011-05-10 8:50 ` Uwe Kleine-König
2011-05-10 22:26 ` H Hartley Sweeten
2011-05-10 22:26 ` H Hartley Sweeten
2011-05-11 6:22 ` Uwe Kleine-König
2011-05-11 6:22 ` Uwe Kleine-König
2011-05-10 23:02 ` H Hartley Sweeten
2011-05-10 23:02 ` H Hartley Sweeten
2011-04-19 23:19 ` Andrew Morton [this message]
2011-04-19 23:19 ` [PATCH] leds: provide helper to register "leds-gpio" devices Andrew Morton
2011-04-19 23:24 ` Russell King - ARM Linux
2011-04-19 23:24 ` Russell King - ARM Linux
2011-04-19 23:50 ` Andrew Morton
2011-04-19 23:50 ` Andrew Morton
2011-04-05 16:41 ` [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419161913.a1c18599.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.