From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"yoshikawa.takuya@oss.ntt.co.jp" <yoshikawa.takuya@oss.ntt.co.jp>
Subject: Re: [PATCH 2/3] KVM: MMU: Introduce a helper to read guest pte
Date: Wed, 20 Apr 2011 13:06:31 +0200 [thread overview]
Message-ID: <20110420110630.GZ2192@amd.com> (raw)
In-Reply-To: <4DAEAFD4.1050609@redhat.com>
On Wed, Apr 20, 2011 at 06:05:08AM -0400, Avi Kivity wrote:
> On 04/20/2011 12:35 PM, Roedel, Joerg wrote:
> > This patch seems only to introduce another wrapper around
> > kvm_read_guest_page_mmu(), so I don't see a problem in this patch.
>
> By patch 3, ptep_user will be computed in this function and no longer
> available for setting the accessed bit later on.
>
> > The kvm_read_guest_page_mmu takes care whether it gets a l1-gfn or
> > l2-gfn (by calling mmu->translate_gpa).
>
> But cmpxchg_gpte() does not.
You are right, cmpxchg_gpte needs to handle this too. But the bug is not
introduced with this patch-set it was there before.
The cmpxchg_gpte function treats all table_gfns as l1-gfns. I'll send a
fix soon.
Regards,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-04-20 11:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 18:32 [PATCH 1/3] KVM: Introduce a helper to check if gfn is in memslot Takuya Yoshikawa
2011-04-18 18:34 ` [PATCH 2/3] KVM: MMU: Introduce a helper to read guest pte Takuya Yoshikawa
2011-04-20 9:07 ` Avi Kivity
2011-04-20 9:35 ` Roedel, Joerg
2011-04-20 10:05 ` Avi Kivity
2011-04-20 11:06 ` Roedel, Joerg [this message]
2011-04-20 11:18 ` Avi Kivity
2011-04-20 13:33 ` [PATCH] KVM: MMU: Make cmpxchg_gpte aware of nesting too Roedel, Joerg
2011-04-21 1:02 ` Takuya Yoshikawa
2011-04-21 8:11 ` Avi Kivity
2011-04-21 1:07 ` [PATCH 2/3] KVM: MMU: Introduce a helper to read guest pte Takuya Yoshikawa
2011-04-18 18:38 ` [RFC PATCH 3/3] KVM: MMU: Optimize guest page table walk Takuya Yoshikawa
2011-04-18 18:52 ` Joerg Roedel
2011-04-19 1:24 ` Takuya Yoshikawa
2011-04-19 6:20 ` Joerg Roedel
2011-04-19 1:42 ` Xiao Guangrong
2011-04-19 3:47 ` Takuya Yoshikawa
2011-04-20 9:09 ` Avi Kivity
2011-04-20 9:02 ` Avi Kivity
2011-04-29 2:46 ` Andi Kleen
2011-04-29 5:38 ` Takuya Yoshikawa
2011-04-29 6:30 ` Takuya Yoshikawa
2011-04-29 6:59 ` Andi Kleen
2011-04-29 13:51 ` Takuya Yoshikawa
2011-04-29 16:05 ` Andi Kleen
2011-05-01 13:32 ` Avi Kivity
2011-05-01 20:51 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420110630.GZ2192@amd.com \
--to=joerg.roedel@amd.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.