From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: "Roedel, Joerg" <Joerg.Roedel@amd.com>,
Takuya Yoshikawa <takuya.yoshikawa@gmail.com>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: MMU: Make cmpxchg_gpte aware of nesting too
Date: Thu, 21 Apr 2011 11:11:19 +0300 [thread overview]
Message-ID: <4DAFE6A7.2010700@redhat.com> (raw)
In-Reply-To: <20110421100210.b704066f.yoshikawa.takuya@oss.ntt.co.jp>
On 04/21/2011 04:02 AM, Takuya Yoshikawa wrote:
> On Wed, 20 Apr 2011 15:33:16 +0200
> "Roedel, Joerg"<Joerg.Roedel@amd.com> wrote:
>
> > @@ -245,13 +257,17 @@ walk:
> > goto error;
> >
> > if (write_fault&& !is_dirty_gpte(pte)) {
> > - bool ret;
> > + int ret;
> >
> > trace_kvm_mmu_set_dirty_bit(table_gfn, index, sizeof(pte));
> > - ret = FNAME(cmpxchg_gpte)(vcpu->kvm, table_gfn, index, pte,
> > + ret = FNAME(cmpxchg_gpte)(vcpu, mmu, table_gfn, index, pte,
> > pte|PT_DIRTY_MASK);
> > - if (ret)
> > + if (ret< 0) {
> > + present = false;
> > + goto error;
> > + } if (ret)
> > goto walk;
>
> Preferably else if or another line ? :)
Yes, I added an 'else' and applied. Thanks.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-04-21 8:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 18:32 [PATCH 1/3] KVM: Introduce a helper to check if gfn is in memslot Takuya Yoshikawa
2011-04-18 18:34 ` [PATCH 2/3] KVM: MMU: Introduce a helper to read guest pte Takuya Yoshikawa
2011-04-20 9:07 ` Avi Kivity
2011-04-20 9:35 ` Roedel, Joerg
2011-04-20 10:05 ` Avi Kivity
2011-04-20 11:06 ` Roedel, Joerg
2011-04-20 11:18 ` Avi Kivity
2011-04-20 13:33 ` [PATCH] KVM: MMU: Make cmpxchg_gpte aware of nesting too Roedel, Joerg
2011-04-21 1:02 ` Takuya Yoshikawa
2011-04-21 8:11 ` Avi Kivity [this message]
2011-04-21 1:07 ` [PATCH 2/3] KVM: MMU: Introduce a helper to read guest pte Takuya Yoshikawa
2011-04-18 18:38 ` [RFC PATCH 3/3] KVM: MMU: Optimize guest page table walk Takuya Yoshikawa
2011-04-18 18:52 ` Joerg Roedel
2011-04-19 1:24 ` Takuya Yoshikawa
2011-04-19 6:20 ` Joerg Roedel
2011-04-19 1:42 ` Xiao Guangrong
2011-04-19 3:47 ` Takuya Yoshikawa
2011-04-20 9:09 ` Avi Kivity
2011-04-20 9:02 ` Avi Kivity
2011-04-29 2:46 ` Andi Kleen
2011-04-29 5:38 ` Takuya Yoshikawa
2011-04-29 6:30 ` Takuya Yoshikawa
2011-04-29 6:59 ` Andi Kleen
2011-04-29 13:51 ` Takuya Yoshikawa
2011-04-29 16:05 ` Andi Kleen
2011-05-01 13:32 ` Avi Kivity
2011-05-01 20:51 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAFE6A7.2010700@redhat.com \
--to=avi@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.