From: gregkh@suse.de (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] driver core: let dev_set_drvdata return int instead of void as it can fail
Date: Wed, 20 Apr 2011 09:17:33 -0700 [thread overview]
Message-ID: <20110420161733.GB25396@suse.de> (raw)
In-Reply-To: <20110420074248.GS31131@pengutronix.de>
On Wed, Apr 20, 2011 at 09:42:48AM +0200, Uwe Kleine-K?nig wrote:
> On Tue, Apr 19, 2011 at 04:58:12PM -0700, Greg KH wrote:
> > On Mon, Apr 11, 2011 at 08:42:58PM +0200, Uwe Kleine-K?nig wrote:
> > > Before commit
> > >
> > > b402843 (Driver core: move dev_get/set_drvdata to drivers/base/dd.c)
> > >
> > > calling dev_set_drvdata with dev=NULL was an unchecked error. After some
> > > discussion about what to return in this case removing the check (and so
> > > producing a null pointer exception) seems fine.
> > >
> > > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > > ---
> > > Hello,
> > >
> > > @Viresh: as I didn't choose to return -EINVAL I didn't add your Reviewed-by:
> >
> > I'm confused by this thread, care to resend all of these in a series
> > against the latest linux-next tree?
> No problem, here it comes. This are patches 1 to 4 of the original
> series + v2 of patch 5 (that didn't have 5/5 in the subject).
Thanks, I'll queue these up soon.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Greg KH" <greg@kroah.com>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
"Viresh Kumar" <viresh.kumar@st.com>,
linux-arm-kernel@lists.infradead.org, shiraz.hashim@st.com,
"Michał Mirosław" <mirqus@gmail.com>
Subject: Re: [PATCH v2] driver core: let dev_set_drvdata return int instead of void as it can fail
Date: Wed, 20 Apr 2011 09:17:33 -0700 [thread overview]
Message-ID: <20110420161733.GB25396@suse.de> (raw)
In-Reply-To: <20110420074248.GS31131@pengutronix.de>
On Wed, Apr 20, 2011 at 09:42:48AM +0200, Uwe Kleine-König wrote:
> On Tue, Apr 19, 2011 at 04:58:12PM -0700, Greg KH wrote:
> > On Mon, Apr 11, 2011 at 08:42:58PM +0200, Uwe Kleine-König wrote:
> > > Before commit
> > >
> > > b402843 (Driver core: move dev_get/set_drvdata to drivers/base/dd.c)
> > >
> > > calling dev_set_drvdata with dev=NULL was an unchecked error. After some
> > > discussion about what to return in this case removing the check (and so
> > > producing a null pointer exception) seems fine.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> > > Hello,
> > >
> > > @Viresh: as I didn't choose to return -EINVAL I didn't add your Reviewed-by:
> >
> > I'm confused by this thread, care to resend all of these in a series
> > against the latest linux-next tree?
> No problem, here it comes. This are patches 1 to 4 of the original
> series + v2 of patch 5 (that didn't have 5/5 in the subject).
Thanks, I'll queue these up soon.
greg k-h
next prev parent reply other threads:[~2011-04-20 16:17 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 4:33 [RFC] device.h: add device_set_platdata routine Viresh Kumar
2011-03-01 7:59 ` Uwe Kleine-König
2011-03-01 7:59 ` Uwe Kleine-König
2011-03-01 8:27 ` viresh kumar
2011-03-01 8:27 ` viresh kumar
2011-03-01 9:05 ` Uwe Kleine-König
2011-03-01 9:05 ` Uwe Kleine-König
2011-03-01 9:13 ` viresh kumar
2011-03-01 9:13 ` viresh kumar
2011-03-01 15:34 ` Greg KH
2011-03-01 15:34 ` Greg KH
2011-04-06 9:24 ` [PATCH 1/5] driver core/platform_device_add_data: set platform_data to NULL if !data Uwe Kleine-König
2011-04-06 9:24 ` Uwe Kleine-König
2011-04-11 18:50 ` Uwe Kleine-König
2011-04-11 18:50 ` Uwe Kleine-König
2011-04-11 19:07 ` Greg KH
2011-04-11 19:07 ` Greg KH
2011-04-06 9:24 ` [PATCH 2/5] driver core/platform_device_add_data: free platform data before overwriting Uwe Kleine-König
2011-04-06 9:24 ` Uwe Kleine-König
2011-04-06 9:24 ` [PATCH 3/5] driver core/platform_device_add_resources: set resource to NULL if !res Uwe Kleine-König
2011-04-06 9:24 ` Uwe Kleine-König
2011-04-06 9:24 ` [PATCH 4/5] driver core/platform_device_add_resources: free resource before overwriting Uwe Kleine-König
2011-04-06 9:24 ` Uwe Kleine-König
2011-04-06 9:24 ` [PATCH 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail Uwe Kleine-König
2011-04-06 9:24 ` Uwe Kleine-König
2011-04-06 9:36 ` Michał Mirosław
2011-04-06 9:36 ` Michał Mirosław
2011-04-06 11:06 ` Uwe Kleine-König
2011-04-06 11:06 ` Uwe Kleine-König
2011-04-06 11:25 ` Michał Mirosław
2011-04-06 11:25 ` Michał Mirosław
2011-04-11 18:42 ` [PATCH v2] " Uwe Kleine-König
2011-04-11 18:42 ` Uwe Kleine-König
2011-04-19 23:58 ` Greg KH
2011-04-19 23:58 ` Greg KH
2011-04-20 7:42 ` Uwe Kleine-König
2011-04-20 7:42 ` Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 1/5] driver core/platform_device_add_data: set platform_data to NULL if !data Uwe Kleine-König
2011-04-20 7:44 ` Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 2/5] driver core/platform_device_add_data: free platform data before overwriting Uwe Kleine-König
2011-04-20 7:44 ` Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 3/5] driver core/platform_device_add_resources: set resource to NULL if !res Uwe Kleine-König
2011-04-20 7:44 ` Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 4/5] driver core/platform_device_add_resources: free resource before overwriting Uwe Kleine-König
2011-04-20 7:44 ` Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail Uwe Kleine-König
2011-04-20 7:44 ` Uwe Kleine-König
2011-04-29 8:12 ` Russell King - ARM Linux
2011-04-29 8:12 ` Russell King - ARM Linux
2011-04-29 9:16 ` Uwe Kleine-König
2011-04-29 9:16 ` Uwe Kleine-König
2011-04-20 16:17 ` Greg KH [this message]
2011-04-20 16:17 ` [PATCH v2] " Greg KH
2011-04-20 9:09 ` Michał Mirosław
2011-04-20 9:09 ` Michał Mirosław
2011-04-20 16:15 ` Greg KH
2011-04-20 16:15 ` Greg KH
2011-04-20 17:59 ` Michał Mirosław
2011-04-20 17:59 ` Michał Mirosław
2011-04-06 10:10 ` [PATCH 5/5] " viresh kumar
2011-04-06 10:10 ` viresh kumar
2011-04-06 11:41 ` Michał Mirosław
2011-04-06 11:41 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420161733.GB25396@suse.de \
--to=gregkh@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.