From: Stanislaw Gruszka <sgruszka@redhat.com>
To: David Decotigny <decot@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Ben Hutchings <bhutchings@solarflare.com>,
mirq-linux@rere.qmqm.pl,
Alexander Duyck <alexander.h.duyck@intel.com>,
Eilon Greenstein <eilong@broadcom.com>,
Grant Grundler <grundler@parisc-linux.org>,
e1000-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCHv4 2/7] ethtool: Call ethtool's get/set_settings callbacks with cleaned data
Date: Thu, 28 Apr 2011 09:34:18 +0200 [thread overview]
Message-ID: <20110428073417.GA2220@redhat.com> (raw)
In-Reply-To: <1303965163-8198-3-git-send-email-decot@google.com>
On Wed, Apr 27, 2011 at 09:32:38PM -0700, David Decotigny wrote:
> --- a/drivers/net/stmmac/stmmac_ethtool.c
> +++ b/drivers/net/stmmac/stmmac_ethtool.c
> @@ -237,13 +237,12 @@ stmmac_set_pauseparam(struct net_device *netdev,
>
> if (phy->autoneg) {
> if (netif_running(netdev)) {
> - struct ethtool_cmd cmd;
> + struct ethtool_cmd cmd = { .cmd = ETHTOOL_SSET };
> /* auto-negotiation automatically restarted */
> - cmd.cmd = ETHTOOL_NWAY_RST;
Why did you change ETHTOOL_NWAY_RST to ETHTOOL_SSET ?
WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: David Decotigny <decot@google.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
e1000-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
Eilon Greenstein <eilong@broadcom.com>,
mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org,
Ben Hutchings <bhutchings@solarflare.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCHv4 2/7] ethtool: Call ethtool's get/set_settings callbacks with cleaned data
Date: Thu, 28 Apr 2011 09:34:18 +0200 [thread overview]
Message-ID: <20110428073417.GA2220@redhat.com> (raw)
In-Reply-To: <1303965163-8198-3-git-send-email-decot@google.com>
On Wed, Apr 27, 2011 at 09:32:38PM -0700, David Decotigny wrote:
> --- a/drivers/net/stmmac/stmmac_ethtool.c
> +++ b/drivers/net/stmmac/stmmac_ethtool.c
> @@ -237,13 +237,12 @@ stmmac_set_pauseparam(struct net_device *netdev,
>
> if (phy->autoneg) {
> if (netif_running(netdev)) {
> - struct ethtool_cmd cmd;
> + struct ethtool_cmd cmd = { .cmd = ETHTOOL_SSET };
> /* auto-negotiation automatically restarted */
> - cmd.cmd = ETHTOOL_NWAY_RST;
Why did you change ETHTOOL_NWAY_RST to ETHTOOL_SSET ?
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2011-04-28 7:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 4:32 [PATCHv4 0/7] ethtool: generalize use of ethtool_cmd_speed API David Decotigny
2011-04-28 4:32 ` [PATCHv4 1/7] ethtool: cosmetics: enforce const-ness in ethtool_cmd_speed David Decotigny
2011-04-28 4:32 ` David Decotigny
2011-04-28 4:32 ` [PATCHv4 2/7] ethtool: Call ethtool's get/set_settings callbacks with cleaned data David Decotigny
2011-04-28 7:34 ` Stanislaw Gruszka [this message]
2011-04-28 7:34 ` Stanislaw Gruszka
2011-04-28 12:46 ` Ben Hutchings
2011-04-28 15:16 ` David Decotigny
2011-04-28 4:32 ` David Decotigny
2011-04-28 4:32 ` [PATCHv4 3/7] ethtool: Use full 32 bit speed range in ethtool's set_settings David Decotigny
2011-04-28 4:32 ` David Decotigny
2011-04-28 4:32 ` [PATCHv4 4/7] ethtool: cosmetic: Use ethtool ethtool_cmd_speed API David Decotigny
2011-04-28 4:32 ` David Decotigny
2011-04-28 4:32 ` [PATCHv4 5/7] acenic: Fix using the specified speed when configuring NIC David Decotigny
2011-04-28 4:32 ` David Decotigny
2011-04-28 4:32 ` [PATCHv4 6/7] tulip/de2104x: don't report different speeds depending on port type David Decotigny
2011-04-28 4:32 ` David Decotigny
2011-04-28 4:32 ` [PATCHv4 7/7] net/igb/e1000/e1000e: more robust ethtool duplex/speed configuration David Decotigny
2011-04-28 4:32 ` David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428073417.GA2220@redhat.com \
--to=sgruszka@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.