All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Cong Wang <amwang@redhat.com>
Cc: Simon Horman <horms@verge.net.au>, kexec@lists.infradead.org
Subject: Re: [Patch] kexec: remove duplicated backup_src_start field from struct crash_elf_info
Date: Thu, 28 Apr 2011 09:15:39 -0400	[thread overview]
Message-ID: <20110428131539.GA7883@redhat.com> (raw)
In-Reply-To: <4DB91DFC.4060708@redhat.com>

On Thu, Apr 28, 2011 at 03:57:48PM +0800, Cong Wang wrote:
> 于 2011年04月27日 23:01, Vivek Goyal 写道:
> >Amerigo,
> >
> >Now who will do following initialization for ppc?
> >
> >info->backup_src_start = BACKUP_SRC_START;
> >info->backup_sz = BACKUP_SRC_END - BACKUP_SRC_START + 1;
> >
> >I think I have concern for mips too.
> 
> Right, we need to initialize them in load_crashdump_segments().
> 
> How about the attached patch? It is untested.
> 

> Signed-off-by: WANG Cong <amwang@redhat.com>

Ok, this one looks better.

Vivek

> diff --git a/kexec/arch/mips/crashdump-mips.c b/kexec/arch/mips/crashdump-mips.c
> index 4fd6c30..e90b362 100644
> --- a/kexec/arch/mips/crashdump-mips.c
> +++ b/kexec/arch/mips/crashdump-mips.c
> @@ -374,6 +374,8 @@ int load_crashdump_segments(struct kexec_info *info, char* mod_cmdline,
>  	if (get_crash_memory_ranges(&mem_range, &nr_ranges) < 0)
>  		return -1;
>  
> +	info->backup_src_start = BACKUP_SRC_START;
> +	info->backup_src_size = BACKUP_SRC_SIZE;
>  	/* Create a backup region segment to store backup data*/
>  	sz = (BACKUP_SRC_SIZE + align - 1) & ~(align - 1);
>  	tmp = xmalloc(sz);
> diff --git a/kexec/arch/ppc/crashdump-powerpc.c b/kexec/arch/ppc/crashdump-powerpc.c
> index 371137c..1dd6485 100644
> --- a/kexec/arch/ppc/crashdump-powerpc.c
> +++ b/kexec/arch/ppc/crashdump-powerpc.c
> @@ -328,6 +328,8 @@ int load_crashdump_segments(struct kexec_info *info, char *mod_cmdline,
>  	if (get_crash_memory_ranges(&mem_range, &nr_ranges) < 0)
>  		return -1;
>  
> +	info->backup_src_start = BACKUP_SRC_START;
> +	info->backup_src_size = BACKUP_SRC_SIZE;
>  	/* Create a backup region segment to store backup data*/
>  	sz = (BACKUP_SRC_SIZE + align - 1) & ~(align - 1);
>  	tmp = xmalloc(sz);
> diff --git a/kexec/arch/ppc64/crashdump-ppc64.c b/kexec/arch/ppc64/crashdump-ppc64.c
> index 6a66f2a..d52b438 100644
> --- a/kexec/arch/ppc64/crashdump-ppc64.c
> +++ b/kexec/arch/ppc64/crashdump-ppc64.c
> @@ -390,6 +390,8 @@ int load_crashdump_segments(struct kexec_info *info, char* mod_cmdline,
>  	if (get_crash_memory_ranges(&mem_range, &nr_ranges) < 0)
>  		return -1;
>  
> +	info->backup_src_start = BACKUP_SRC_START;
> +	info->backup_src_size = BACKUP_SRC_SIZE;
>  	/* Create a backup region segment to store backup data*/
>  	sz = (BACKUP_SRC_SIZE + align - 1) & ~(align - 1);
>  	tmp = xmalloc(sz);


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2011-04-28 13:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27  3:33 [Patch] kexec: remove duplicated backup_src_start field from struct crash_elf_info Amerigo Wang
2011-04-27  6:15 ` Simon Horman
2011-04-27 15:01 ` Vivek Goyal
     [not found]   ` <4DB91DFC.4060708@redhat.com>
2011-04-28 13:15     ` Vivek Goyal [this message]
2011-04-28 22:05       ` Simon Horman
2011-04-28 22:10         ` Vivek Goyal
2011-04-29  5:17           ` Simon Horman
2011-04-29  2:59         ` Cong Wang
2011-04-29  5:17           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110428131539.GA7883@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=amwang@redhat.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.