All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: Simon Horman <horms@verge.net.au>
Cc: kexec@lists.infradead.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [Patch] kexec: remove duplicated backup_src_start field from struct crash_elf_info
Date: Fri, 29 Apr 2011 10:59:40 +0800	[thread overview]
Message-ID: <4DBA299C.6020003@redhat.com> (raw)
In-Reply-To: <20110428220515.GI3610@verge.net.au>

于 2011年04月29日 06:05, Simon Horman 写道:
> On Thu, Apr 28, 2011 at 09:15:39AM -0400, Vivek Goyal wrote:
>> On Thu, Apr 28, 2011 at 03:57:48PM +0800, Cong Wang wrote:
>>> 于 2011年04月27日 23:01, Vivek Goyal 写道:
>>>> Amerigo,
>>>>
>>>> Now who will do following initialization for ppc?
>>>>
>>>> info->backup_src_start = BACKUP_SRC_START;
>>>> info->backup_sz = BACKUP_SRC_END - BACKUP_SRC_START + 1;
>>>>
>>>> I think I have concern for mips too.
>>>
>>> Right, we need to initialize them in load_crashdump_segments().
>>>
>>> How about the attached patch? It is untested.
>>>
>>
>>> Signed-off-by: WANG Cong<amwang@redhat.com>
>>
>> Ok, this one looks better.
>
> Vivek, can I take that as an Acked-by?
>
> Cong, can you clarify if I need to revert any of your recent patches or
> not?

No, that attached patch is right to fix the first one, so you don't
need to revert anything.

Thanks!

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2011-04-29  2:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27  3:33 [Patch] kexec: remove duplicated backup_src_start field from struct crash_elf_info Amerigo Wang
2011-04-27  6:15 ` Simon Horman
2011-04-27 15:01 ` Vivek Goyal
     [not found]   ` <4DB91DFC.4060708@redhat.com>
2011-04-28 13:15     ` Vivek Goyal
2011-04-28 22:05       ` Simon Horman
2011-04-28 22:10         ` Vivek Goyal
2011-04-29  5:17           ` Simon Horman
2011-04-29  2:59         ` Cong Wang [this message]
2011-04-29  5:17           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DBA299C.6020003@redhat.com \
    --to=amwang@redhat.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.