* [lm-sensors] [PATCH] hwmon: twl4030-madc-hwmon: Return proper error
@ 2011-05-01 15:34 ` Axel Lin
0 siblings, 0 replies; 4+ messages in thread
From: Axel Lin @ 2011-05-01 15:34 UTC (permalink / raw)
To: linux-kernel; +Cc: J Keerthy, Jean Delvare, Guenter Roeck, lm-sensors
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/hwmon/twl4030-madc-hwmon.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/twl4030-madc-hwmon.c b/drivers/hwmon/twl4030-madc-hwmon.c
index de58191..5724074 100644
--- a/drivers/hwmon/twl4030-madc-hwmon.c
+++ b/drivers/hwmon/twl4030-madc-hwmon.c
@@ -98,7 +98,6 @@ static const struct attribute_group twl4030_madc_group = {
static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
{
int ret;
- int status;
struct device *hwmon;
ret = sysfs_create_group(&pdev->dev.kobj, &twl4030_madc_group);
@@ -107,7 +106,7 @@ static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
hwmon = hwmon_device_register(&pdev->dev);
if (IS_ERR(hwmon)) {
dev_err(&pdev->dev, "hwmon_device_register failed.\n");
- status = PTR_ERR(hwmon);
+ ret = PTR_ERR(hwmon);
goto err_reg;
}
--
1.7.1
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] hwmon: twl4030-madc-hwmon: Return proper error if hwmon_device_register fails
@ 2011-05-01 15:34 ` Axel Lin
0 siblings, 0 replies; 4+ messages in thread
From: Axel Lin @ 2011-05-01 15:34 UTC (permalink / raw)
To: linux-kernel; +Cc: J Keerthy, Jean Delvare, Guenter Roeck, lm-sensors
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/hwmon/twl4030-madc-hwmon.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/twl4030-madc-hwmon.c b/drivers/hwmon/twl4030-madc-hwmon.c
index de58191..5724074 100644
--- a/drivers/hwmon/twl4030-madc-hwmon.c
+++ b/drivers/hwmon/twl4030-madc-hwmon.c
@@ -98,7 +98,6 @@ static const struct attribute_group twl4030_madc_group = {
static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
{
int ret;
- int status;
struct device *hwmon;
ret = sysfs_create_group(&pdev->dev.kobj, &twl4030_madc_group);
@@ -107,7 +106,7 @@ static int __devinit twl4030_madc_hwmon_probe(struct platform_device *pdev)
hwmon = hwmon_device_register(&pdev->dev);
if (IS_ERR(hwmon)) {
dev_err(&pdev->dev, "hwmon_device_register failed.\n");
- status = PTR_ERR(hwmon);
+ ret = PTR_ERR(hwmon);
goto err_reg;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [lm-sensors] [PATCH] hwmon: twl4030-madc-hwmon: Return proper
2011-05-01 15:34 ` [PATCH] hwmon: twl4030-madc-hwmon: Return proper error if hwmon_device_register fails Axel Lin
@ 2011-05-01 15:43 ` Guenter Roeck
-1 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2011-05-01 15:43 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel@vger.kernel.org, J Keerthy, Jean Delvare,
lm-sensors@lm-sensors.org
On Sun, May 01, 2011 at 11:34:55AM -0400, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Good catch. Applied.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-05-01 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-01 15:34 [lm-sensors] [PATCH] hwmon: twl4030-madc-hwmon: Return proper error Axel Lin
2011-05-01 15:34 ` [PATCH] hwmon: twl4030-madc-hwmon: Return proper error if hwmon_device_register fails Axel Lin
2011-05-01 15:43 ` [lm-sensors] [PATCH] hwmon: twl4030-madc-hwmon: Return proper Guenter Roeck
2011-05-01 15:43 ` [PATCH] hwmon: twl4030-madc-hwmon: Return proper error if hwmon_device_register fails Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.