From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/8] arm/dt: probe for platforms via the device tree
Date: Mon, 2 May 2011 08:15:42 -0700 [thread overview]
Message-ID: <20110502151542.GG2092@atomide.com> (raw)
In-Reply-To: <20110429071548.12522.56929.stgit@ponder>
* Grant Likely <grant.likely@secretlab.ca> [110429 00:13]:
> +
> +/**
> + * setup_machine_fdt - Machine setup when an dtb was passed to the kernel
> + * @dt_phys: physical address of dt blob
> + *
> + * If a dtb was passed to the kernel in r2, then use it to choose the
> + * correct machine_desc and to setup the system.
> + */
> +struct machine_desc * __init setup_machine_fdt(unsigned int dt_phys)
> +{
...
> +
> + /* Retrieve various information from the /chosen node */
> + of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
Just to make sure we're considering properly what this change means..
Does this patch require using CONFIG_CMDLINE_FORCE for older bootloaders
with the device tree append patch?
Or should we still somehow get ATAG_CMDLINE let's say in the uncompress
code and use that if nothing else is found?
Otherwise booting old boards with the same kernel will be painful as
it requires a kernel recompile to set the cmdline..
Also, not counting the separate DT append issues, I got things booting
with these patches (and the dts files) on omaps. So for patches 1 - 5,
and patch 8:
Tested-by: Tony Lindgren <tony@atomide.com>
I don't have versatile or tegra, so can't test those :)
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 4/8] arm/dt: probe for platforms via the device tree
Date: Mon, 2 May 2011 08:15:42 -0700 [thread overview]
Message-ID: <20110502151542.GG2092@atomide.com> (raw)
In-Reply-To: <20110429071548.12522.56929.stgit@ponder>
* Grant Likely <grant.likely@secretlab.ca> [110429 00:13]:
> +
> +/**
> + * setup_machine_fdt - Machine setup when an dtb was passed to the kernel
> + * @dt_phys: physical address of dt blob
> + *
> + * If a dtb was passed to the kernel in r2, then use it to choose the
> + * correct machine_desc and to setup the system.
> + */
> +struct machine_desc * __init setup_machine_fdt(unsigned int dt_phys)
> +{
...
> +
> + /* Retrieve various information from the /chosen node */
> + of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
Just to make sure we're considering properly what this change means..
Does this patch require using CONFIG_CMDLINE_FORCE for older bootloaders
with the device tree append patch?
Or should we still somehow get ATAG_CMDLINE let's say in the uncompress
code and use that if nothing else is found?
Otherwise booting old boards with the same kernel will be painful as
it requires a kernel recompile to set the cmdline..
Also, not counting the separate DT append issues, I got things booting
with these patches (and the dts files) on omaps. So for patches 1 - 5,
and patch 8:
Tested-by: Tony Lindgren <tony@atomide.com>
I don't have versatile or tegra, so can't test those :)
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Nicolas Pitre
<nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v5 4/8] arm/dt: probe for platforms via the device tree
Date: Mon, 2 May 2011 08:15:42 -0700 [thread overview]
Message-ID: <20110502151542.GG2092@atomide.com> (raw)
In-Reply-To: <20110429071548.12522.56929.stgit@ponder>
* Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> [110429 00:13]:
> +
> +/**
> + * setup_machine_fdt - Machine setup when an dtb was passed to the kernel
> + * @dt_phys: physical address of dt blob
> + *
> + * If a dtb was passed to the kernel in r2, then use it to choose the
> + * correct machine_desc and to setup the system.
> + */
> +struct machine_desc * __init setup_machine_fdt(unsigned int dt_phys)
> +{
...
> +
> + /* Retrieve various information from the /chosen node */
> + of_scan_flat_dt(early_init_dt_scan_chosen, boot_command_line);
Just to make sure we're considering properly what this change means..
Does this patch require using CONFIG_CMDLINE_FORCE for older bootloaders
with the device tree append patch?
Or should we still somehow get ATAG_CMDLINE let's say in the uncompress
code and use that if nothing else is found?
Otherwise booting old boards with the same kernel will be painful as
it requires a kernel recompile to set the cmdline..
Also, not counting the separate DT append issues, I got things booting
with these patches (and the dts files) on omaps. So for patches 1 - 5,
and patch 8:
Tested-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
I don't have versatile or tegra, so can't test those :)
next prev parent reply other threads:[~2011-05-02 15:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 7:15 [PATCH v5 0/8] Basic ARM devicetree support Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:15 ` [PATCH v5 1/8] arm/dt: Make __vet_atags also accept a dtb image Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:15 ` [PATCH v5 2/8] arm/dt: Allow CONFIG_OF on ARM Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:15 ` [PATCH v5 3/8] arm/dt: consolidate atags setup into setup_machine_atags Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:15 ` [PATCH v5 4/8] arm/dt: probe for platforms via the device tree Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-05-02 15:15 ` Tony Lindgren [this message]
2011-05-02 15:15 ` Tony Lindgren
2011-05-02 15:15 ` Tony Lindgren
2011-05-02 15:34 ` Grant Likely
2011-05-02 15:34 ` Grant Likely
2011-05-02 16:39 ` Tony Lindgren
2011-05-02 16:39 ` Tony Lindgren
2011-05-02 16:39 ` Tony Lindgren
2011-05-02 21:55 ` Grant Likely
2011-05-02 21:55 ` Grant Likely
2011-05-03 10:44 ` Tony Lindgren
2011-05-03 10:44 ` Tony Lindgren
2011-05-03 10:44 ` Tony Lindgren
2011-05-02 21:51 ` Grant Likely
2011-05-02 21:51 ` Grant Likely
2011-04-29 7:15 ` [PATCH v5 5/8] arm/dt: Drop irq_create_of_mapping() from arm code Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-30 0:28 ` Nicolas Pitre
2011-04-30 0:28 ` Nicolas Pitre
2011-04-30 0:28 ` Nicolas Pitre
2011-04-30 6:28 ` Grant Likely
2011-04-30 6:28 ` Grant Likely
2011-04-29 7:15 ` [PATCH v5 6/8] arm/dt: Basic versatile devicetree support Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:15 ` Grant Likely
2011-04-29 7:16 ` [PATCH v5 7/8] arm/dt: Basic tegra " Grant Likely
2011-04-29 7:16 ` Grant Likely
2011-04-29 7:16 ` [PATCH v5 8/8] dt: add documentation of ARM dt boot interface Grant Likely
2011-04-29 7:16 ` Grant Likely
2011-04-30 0:37 ` Nicolas Pitre
2011-04-30 0:37 ` Nicolas Pitre
2011-04-30 6:30 ` Grant Likely
2011-04-30 6:30 ` Grant Likely
2011-04-30 6:30 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502151542.GG2092@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.