All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Oleg Drokin <green@linuxhacker.ru>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Mike Rapoport <mike@compulab.co.il>
Subject: Re: [PATCH 4/4] omap: musb: introduce default baord config
Date: Tue, 3 May 2011 00:50:13 -0700	[thread overview]
Message-ID: <20110503075013.GL2092@atomide.com> (raw)
In-Reply-To: <20110502142533.GJ2529@legolas.emea.dhcp.ti.com>

* Felipe Balbi <balbi@ti.com> [110502 07:22]:
> On Mon, May 02, 2011 at 07:20:52AM -0700, Tony Lindgren wrote:
> > * Oleg Drokin <green@linuxhacker.ru> [110428 09:33]:
> > > 
> > > So to me it looks like something totally in realm of musb driver itself.
> > > Nothing bad happens if you configure your MUSB as say OTG while in fact only
> > > peripheral mode was implemented, it continues to work as it did.
> > > Of course enabling HOST mode may not magically make things work, but
> > > I suspect this could be addressed from Kconfig itself instead.

So based on the discussion it sounds like we still the board specific
configuration for the mode in some cases.

> > I think Felipe already has some patches to remove the various Kconfig
> > options for musb?  In any case, the musb configuration should be a
> > runtime configuration passed in the platform data or cmdline.
> 
> Yeah, I'm planning to get rid of all the ifdeferry and always compile it
> with HOST and Peripheral support. It's only few extra tens of bytes
> anyway. Still, I doubt I can get that done for this merge window, I
> already have pending the debugging rework.

So care to ack the original patch then? It still allows overriding
the default mode from board-*.c file as needed.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] omap: musb: introduce default baord config
Date: Tue, 3 May 2011 00:50:13 -0700	[thread overview]
Message-ID: <20110503075013.GL2092@atomide.com> (raw)
In-Reply-To: <20110502142533.GJ2529@legolas.emea.dhcp.ti.com>

* Felipe Balbi <balbi@ti.com> [110502 07:22]:
> On Mon, May 02, 2011 at 07:20:52AM -0700, Tony Lindgren wrote:
> > * Oleg Drokin <green@linuxhacker.ru> [110428 09:33]:
> > > 
> > > So to me it looks like something totally in realm of musb driver itself.
> > > Nothing bad happens if you configure your MUSB as say OTG while in fact only
> > > peripheral mode was implemented, it continues to work as it did.
> > > Of course enabling HOST mode may not magically make things work, but
> > > I suspect this could be addressed from Kconfig itself instead.

So based on the discussion it sounds like we still the board specific
configuration for the mode in some cases.

> > I think Felipe already has some patches to remove the various Kconfig
> > options for musb?  In any case, the musb configuration should be a
> > runtime configuration passed in the platform data or cmdline.
> 
> Yeah, I'm planning to get rid of all the ifdeferry and always compile it
> with HOST and Peripheral support. It's only few extra tens of bytes
> anyway. Still, I doubt I can get that done for this merge window, I
> already have pending the debugging rework.

So care to ack the original patch then? It still allows overriding
the default mode from board-*.c file as needed.

Regards,

Tony

  reply	other threads:[~2011-05-03  7:50 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-24 22:09 [PATCH 0/4] omap: cleanup board files Mike Rapoport
2011-04-24 22:09 ` Mike Rapoport
2011-04-24 22:09 ` [PATCH 1/4] omap: consolidate touch screen initialization among different boards Mike Rapoport
2011-04-24 22:09   ` Mike Rapoport
2011-05-04  3:10   ` Oleg Drokin
2011-05-04  3:10     ` Oleg Drokin
2011-05-04 14:02   ` Thomas Weber
2011-05-04 14:02     ` Thomas Weber
2011-05-04 15:10     ` Igor Grinberg
2011-05-04 15:10       ` Igor Grinberg
2011-04-24 22:09 ` [PATCH 2/4] omap: use common initialization for PMIC i2c bus Mike Rapoport
2011-04-24 22:09   ` Mike Rapoport
2011-04-24 22:09 ` [PATCH 3/4] omap: move detection of NAND CS to common-board-devices Mike Rapoport
2011-04-24 22:09   ` Mike Rapoport
2011-05-04  3:12   ` Oleg Drokin
2011-05-04  3:12     ` Oleg Drokin
2011-05-04  4:10     ` Oleg Drokin
2011-05-04  4:10       ` Oleg Drokin
2011-05-04  6:38       ` Mike Rapoport
2011-05-04  6:38         ` Mike Rapoport
2011-05-04  6:46         ` Tony Lindgren
2011-05-04  6:46           ` Tony Lindgren
2011-05-04  7:17           ` Mike Rapoport
2011-05-04  7:17             ` Mike Rapoport
2011-05-04  8:38             ` Tony Lindgren
2011-05-04  8:38               ` Tony Lindgren
2011-05-04 15:54         ` Oleg Drokin
2011-05-04 15:54           ` Oleg Drokin
2011-04-24 22:09 ` [PATCH 4/4] omap: musb: introduce default baord config Mike Rapoport
2011-04-24 22:09   ` Mike Rapoport
2011-04-27  4:23   ` Oleg Drokin
2011-04-27  4:23     ` Oleg Drokin
2011-04-27  7:23     ` Mike Rapoport
2011-04-27  7:23       ` Mike Rapoport
2011-04-28 14:18     ` Russell King - ARM Linux
2011-04-28 14:18       ` Russell King - ARM Linux
2011-04-28 16:21       ` Oleg Drokin
2011-04-28 16:21         ` Oleg Drokin
2011-04-28 16:28         ` Russell King - ARM Linux
2011-04-28 16:28           ` Russell King - ARM Linux
2011-04-28 16:36           ` Oleg Drokin
2011-04-28 16:36             ` Oleg Drokin
2011-05-02 14:20             ` Tony Lindgren
2011-05-02 14:20               ` Tony Lindgren
2011-05-02 14:25               ` Felipe Balbi
2011-05-02 14:25                 ` Felipe Balbi
2011-05-03  7:50                 ` Tony Lindgren [this message]
2011-05-03  7:50                   ` Tony Lindgren
2011-04-27  8:56   ` [PATCH v2 4/4] omap: musb: introduce default board config Mike Rapoport
2011-04-27  8:56     ` Mike Rapoport
2011-05-03  8:24     ` Felipe Balbi
2011-05-03  8:24       ` Felipe Balbi
2011-05-02 13:57 ` [PATCH 0/4] omap: cleanup board files Mike Rapoport
2011-05-02 13:57   ` Mike Rapoport
2011-05-02 14:22   ` Tony Lindgren
2011-05-02 14:22     ` Tony Lindgren
2011-05-03 10:25     ` Tony Lindgren
2011-05-03 10:25       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110503075013.GL2092@atomide.com \
    --to=tony@atomide.com \
    --cc=balbi@ti.com \
    --cc=green@linuxhacker.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mike@compulab.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.