From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lrg@slimlogic.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SOC: UDA134x: Enable POWER_OFF_ON_STANDBY define.
Date: Tue, 3 May 2011 12:23:50 +0100 [thread overview]
Message-ID: <20110503112350.GG1762@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTimE_TEzManZb2McLnohqbc27hRZ=w@mail.gmail.com>
On Tue, May 03, 2011 at 01:09:27PM +0200, Belisko Marek wrote:
> On Tue, May 3, 2011 at 12:00 PM, Mark Brown
> > If this is essential why is it optional in the first place?
> Not sure about background. Maybe whole define should be removed
That's exactly what I'm suggesting.
> This change was introduced in commit:f0fba2ad
*Always* include a plain text description of the commit for those of us
who haven't memorised the entire git history. In this case I suspect
you need to do a bit more digging, that commit will just have done some
code motion here.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: tiwai@suse.de, perex@perex.cz, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] SOC: UDA134x: Enable POWER_OFF_ON_STANDBY define.
Date: Tue, 3 May 2011 12:23:50 +0100 [thread overview]
Message-ID: <20110503112350.GG1762@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTimE_TEzManZb2McLnohqbc27hRZ=w@mail.gmail.com>
On Tue, May 03, 2011 at 01:09:27PM +0200, Belisko Marek wrote:
> On Tue, May 3, 2011 at 12:00 PM, Mark Brown
> > If this is essential why is it optional in the first place?
> Not sure about background. Maybe whole define should be removed
That's exactly what I'm suggesting.
> This change was introduced in commit:f0fba2ad
*Always* include a plain text description of the commit for those of us
who haven't memorised the entire git history. In this case I suspect
you need to do a bit more digging, that commit will just have done some
code motion here.
next prev parent reply other threads:[~2011-05-03 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 9:32 [PATCH] SOC: UDA134x: Enable POWER_OFF_ON_STANDBY define Marek Belisko
2011-05-03 10:00 ` Mark Brown
2011-05-03 10:00 ` Mark Brown
2011-05-03 11:09 ` Belisko Marek
2011-05-03 11:23 ` Mark Brown [this message]
2011-05-03 11:23 ` Mark Brown
2011-05-03 11:56 ` Belisko Marek
2011-05-03 12:10 ` Mark Brown
2011-05-03 12:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503112350.GG1762@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=marek.belisko@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.