* [PATCH] ASoC: JZ4740: Fix i2s shutdown
@ 2011-04-30 20:28 Lars-Peter Clausen
2011-05-02 18:33 ` Liam Girdwood
2011-05-03 17:48 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2011-04-30 20:28 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, Lars-Peter Clausen
The i2s shutdown callback has the check whether it should be disabled reversed.
Currently it is disabled if another stream is still active, but kept enabled if
the last stream is closed. This patch fixes it.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/jz4740/jz4740-i2s.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c
index 419bf4f..cd22a54 100644
--- a/sound/soc/jz4740/jz4740-i2s.c
+++ b/sound/soc/jz4740/jz4740-i2s.c
@@ -133,7 +133,7 @@ static void jz4740_i2s_shutdown(struct snd_pcm_substream *substream,
struct jz4740_i2s *i2s = snd_soc_dai_get_drvdata(dai);
uint32_t conf;
- if (!dai->active)
+ if (dai->active)
return;
conf = jz4740_i2s_read(i2s, JZ_REG_AIC_CONF);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: JZ4740: Fix i2s shutdown
2011-04-30 20:28 [PATCH] ASoC: JZ4740: Fix i2s shutdown Lars-Peter Clausen
@ 2011-05-02 18:33 ` Liam Girdwood
2011-05-03 17:48 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-05-02 18:33 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: alsa-devel, Mark Brown
On Sat, 2011-04-30 at 22:28 +0200, Lars-Peter Clausen wrote:
> The i2s shutdown callback has the check whether it should be disabled reversed.
> Currently it is disabled if another stream is still active, but kept enabled if
> the last stream is closed. This patch fixes it.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: JZ4740: Fix i2s shutdown
2011-04-30 20:28 [PATCH] ASoC: JZ4740: Fix i2s shutdown Lars-Peter Clausen
2011-05-02 18:33 ` Liam Girdwood
@ 2011-05-03 17:48 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-05-03 17:48 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: alsa-devel, Liam Girdwood
On Sat, Apr 30, 2011 at 10:28:20PM +0200, Lars-Peter Clausen wrote:
> The i2s shutdown callback has the check whether it should be disabled reversed.
> Currently it is disabled if another stream is still active, but kept enabled if
> the last stream is closed. This patch fixes it.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-03 17:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-30 20:28 [PATCH] ASoC: JZ4740: Fix i2s shutdown Lars-Peter Clausen
2011-05-02 18:33 ` Liam Girdwood
2011-05-03 17:48 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.