From: "Hans J. Koch" <hjk@hansjkoch.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Michal Simek <monstr@monstr.eu>,
devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca,
john.williams@petalogix.com, linux-kernel@vger.kernel.org,
hjk@hansjkoch.de, arnd@arndb.de
Subject: Re: [PATCH v4] uio/pdrv_genirq: Add OF support
Date: Wed, 4 May 2011 00:14:40 +0200 [thread overview]
Message-ID: <20110503221440.GB2737@local> (raw)
In-Reply-To: <20110503203412.GA2119@pengutronix.de>
On Tue, May 03, 2011 at 10:34:12PM +0200, Wolfram Sang wrote:
> On Mon, May 02, 2011 at 08:51:55AM +0200, Michal Simek wrote:
> > Adding OF binding to genirq.
> > Version string is setup to the "devicetree".
> >
> > Compatible string is not setup for now but you can add your
> > custom compatible string to uio_of_genirq_match structure.
> >
> > For example with "vendor,device" compatible string:
> > static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
> > { .compatible = "vendor,device", },
> > { /* empty for now */ },
> > };
> >
> > Signed-off-by: Michal Simek <monstr@monstr.eu>
>
> [...]
>
> > + /* alloc uioinfo for one device */
> > + uioinfo = kzalloc(sizeof(*uioinfo), GFP_KERNEL);
>
> kfree in remove?
Oh yes. Missed that one. It should probably look like the "bad0" case in probe().
Thanks,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: "Hans J. Koch" <hjk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hjk-vqZO0P4V72/QD6PfKP4TzA@public.gmane.org,
john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org
Subject: Re: [PATCH v4] uio/pdrv_genirq: Add OF support
Date: Wed, 4 May 2011 00:14:40 +0200 [thread overview]
Message-ID: <20110503221440.GB2737@local> (raw)
In-Reply-To: <20110503203412.GA2119-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Tue, May 03, 2011 at 10:34:12PM +0200, Wolfram Sang wrote:
> On Mon, May 02, 2011 at 08:51:55AM +0200, Michal Simek wrote:
> > Adding OF binding to genirq.
> > Version string is setup to the "devicetree".
> >
> > Compatible string is not setup for now but you can add your
> > custom compatible string to uio_of_genirq_match structure.
> >
> > For example with "vendor,device" compatible string:
> > static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
> > { .compatible = "vendor,device", },
> > { /* empty for now */ },
> > };
> >
> > Signed-off-by: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
>
> [...]
>
> > + /* alloc uioinfo for one device */
> > + uioinfo = kzalloc(sizeof(*uioinfo), GFP_KERNEL);
>
> kfree in remove?
Oh yes. Missed that one. It should probably look like the "bad0" case in probe().
Thanks,
Hans
next prev parent reply other threads:[~2011-05-03 22:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 6:51 [PATCH v4] uio/pdrv_genirq: Add OF support Michal Simek
2011-05-03 19:57 ` Hans J. Koch
2011-05-03 19:57 ` Hans J. Koch
2011-05-03 20:34 ` Wolfram Sang
2011-05-03 20:34 ` Wolfram Sang
2011-05-03 22:14 ` Hans J. Koch [this message]
2011-05-03 22:14 ` Hans J. Koch
2011-05-04 13:21 ` Michal Simek
2011-05-04 19:47 ` Hans J. Koch
2011-05-04 20:29 ` Grant Likely
2011-05-04 20:29 ` Grant Likely
2011-05-05 5:26 ` Michal Simek
2011-05-06 0:55 ` Hans J. Koch
2011-05-06 0:55 ` Hans J. Koch
2011-05-04 13:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110503221440.GB2737@local \
--to=hjk@hansjkoch.de \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=john.williams@petalogix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.