From: "Matt Carlson" <mcarlson@broadcom.com>
To: "Mahesh Bandewar" <maheshb@google.com>
Cc: "Matthew Carlson" <mcarlson@broadcom.com>,
"David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"Michael Chan" <mchan@broadcom.com>,
"Ben Hutchings" <bhutchings@solarflare.com>,
"Micha? Miros?aw" <mirq-linux@rere.qmqm.pl>,
"Tom Herbert" <therbert@google.com>
Subject: Re: [PATCHv3 2/2] tg3: Allow ethtool to enable/disable loopback.
Date: Tue, 3 May 2011 18:52:06 -0700 [thread overview]
Message-ID: <20110504015206.GA28029@mcarlson.broadcom.com> (raw)
In-Reply-To: <1304471935-402-3-git-send-email-maheshb@google.com>
On Tue, May 03, 2011 at 06:18:55PM -0700, Mahesh Bandewar wrote:
> + /*
> + * Add loopback capability only for a subset of devices that support
> + * MAC-LOOPBACK. Eventually this need to be enhanced to allow INT-PHY
> + * loopback for the remaining devices.
> + */
> + if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5780 ||
> + !tg3_flag(tp, CPMU_PRESENT))
> + /* Add the loopback capability */
> + dev->hw_features |= NETIF_F_LOOPBACK;
s/||/&&/
next prev parent reply other threads:[~2011-05-04 1:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 1:18 [PATCHv3 0/2] Loopback Mahesh Bandewar
2011-05-04 1:18 ` [PATCH 1/2] net: Allow ethtool to set interface in loopback mode Mahesh Bandewar
2011-05-04 1:18 ` [PATCHv3 2/2] tg3: Allow ethtool to enable/disable loopback Mahesh Bandewar
2011-05-04 1:52 ` Matt Carlson [this message]
2011-05-04 11:11 ` Michał Mirosław
2011-05-04 15:04 ` Stephen Hemminger
2011-05-04 16:05 ` Michał Mirosław
2011-05-04 16:08 ` Ben Hutchings
2011-05-05 1:34 ` [PATCHv4 " Mahesh Bandewar
2011-05-05 6:59 ` Michał Mirosław
2011-05-05 17:47 ` Mahesh Bandewar
2011-05-05 18:35 ` Michał Mirosław
2011-05-05 23:16 ` Mahesh Bandewar
2011-05-06 6:35 ` Michał Mirosław
2011-05-07 6:18 ` [PATCHv5 " Mahesh Bandewar
2011-05-07 7:43 ` Michał Mirosław
2011-05-08 16:50 ` Mahesh Bandewar
2011-05-08 16:51 ` [PATCHv6 " Mahesh Bandewar
2011-05-12 22:04 ` David Miller
2011-05-04 11:15 ` [PATCH 1/2] net: Allow ethtool to set interface in loopback mode Michał Mirosław
2011-05-05 1:30 ` [PATCHv2 " Mahesh Bandewar
2011-05-05 1:52 ` Ben Hutchings
2011-05-08 23:00 ` David Miller
2011-05-06 0:12 ` [PATCH net-next-2.6] sfc: Implement NETIF_F_LOOPBACK Ben Hutchings
2011-05-09 7:36 ` Michał Mirosław
2011-05-09 13:47 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504015206.GA28029@mcarlson.broadcom.com \
--to=mcarlson@broadcom.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=maheshb@google.com \
--cc=mchan@broadcom.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.