From: Andi Kleen <andi@firstfloor.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andi Kleen <andi@firstfloor.org>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
rientjes@google.com, Michal Hocko <mhocko@suse.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Balbir Singh <balbir@in.ibm.com>
Subject: Re: [PATCH] Allocate memory cgroup structures in local nodes v2
Date: Wed, 4 May 2011 23:42:56 +0200 [thread overview]
Message-ID: <20110504214256.GA2925@one.firstfloor.org> (raw)
In-Reply-To: <20110504213850.GA16685@cmpxchg.org>
> I don't think any of those mistakes even triggers a compiler warning.
> Wow. This API is so thoroughly fscked beyond belief that I think the
> only way to top this is to have one of the functions invert the bits
> of its return value depending on the parity of the uptime counter.
Yes I must agree. Oops. Ok I'm retracting the patch for now
and do more testing (i think it just hit the fallback)
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andi Kleen <andi@firstfloor.org>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
rientjes@google.com, Michal Hocko <mhocko@suse.cz>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Balbir Singh <balbir@in.ibm.com>
Subject: Re: [PATCH] Allocate memory cgroup structures in local nodes v2
Date: Wed, 4 May 2011 23:42:56 +0200 [thread overview]
Message-ID: <20110504214256.GA2925@one.firstfloor.org> (raw)
In-Reply-To: <20110504213850.GA16685@cmpxchg.org>
> I don't think any of those mistakes even triggers a compiler warning.
> Wow. This API is so thoroughly fscked beyond belief that I think the
> only way to top this is to have one of the functions invert the bits
> of its return value depending on the parity of the uptime counter.
Yes I must agree. Oops. Ok I'm retracting the patch for now
and do more testing (i think it just hit the fallback)
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-04 21:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 20:26 [PATCH] Allocate memory cgroup structures in local nodes v2 Andi Kleen
2011-05-04 20:26 ` Andi Kleen
2011-05-04 21:38 ` Johannes Weiner
2011-05-04 21:38 ` Johannes Weiner
2011-05-04 21:42 ` Andi Kleen [this message]
2011-05-04 21:42 ` Andi Kleen
2011-05-04 22:11 ` [PATCH] Allocate memory cgroup structures in local nodes v2 II Andi Kleen
2011-05-04 22:11 ` Andi Kleen
2011-05-05 6:38 ` [PATCH] Allocate memory cgroup structures in local nodes v2 Michal Hocko
2011-05-05 6:38 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504214256.GA2925@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.