All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: "Figo.zhang" <figo1802@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	mel@csn.ul.ie, kamezawa.hiroyu@jp.fujisu.com,
	Minchan Kim <minchan.kim@gmail.com>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH]mm/page_alloc.c: no need del from lru
Date: Fri, 6 May 2011 20:06:46 +0200	[thread overview]
Message-ID: <20110506180646.GF6330@random.random> (raw)
In-Reply-To: <1304694099.2450.3.camel@figo-desktop>

Hello,

On Fri, May 06, 2011 at 11:01:21PM +0800, Figo.zhang wrote:
> 
> split_free_page() the page is still free page, it is no need del from lru.

This is in the buddy freelist, see the other list_add in
page_alloc.c. It's not the lru as in release_pages. I see little
chance that if this was wrong it could go unnoticed so long without
major mm corruption reported. Removing it also should result in heavy
mm corruption.

Thanks,
Andrea

WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: "Figo.zhang" <figo1802@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	mel@csn.ul.ie, kamezawa.hiroyu@jp.fujisu.com,
	Minchan Kim <minchan.kim@gmail.com>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH]mm/page_alloc.c: no need del from lru
Date: Fri, 6 May 2011 20:06:46 +0200	[thread overview]
Message-ID: <20110506180646.GF6330@random.random> (raw)
In-Reply-To: <1304694099.2450.3.camel@figo-desktop>

Hello,

On Fri, May 06, 2011 at 11:01:21PM +0800, Figo.zhang wrote:
> 
> split_free_page() the page is still free page, it is no need del from lru.

This is in the buddy freelist, see the other list_add in
page_alloc.c. It's not the lru as in release_pages. I see little
chance that if this was wrong it could go unnoticed so long without
major mm corruption reported. Removing it also should result in heavy
mm corruption.

Thanks,
Andrea

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-05-06 18:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 15:01 [PATCH]mm/page_alloc.c: no need del from lru Figo.zhang
2011-05-06 15:01 ` Figo.zhang
2011-05-06 18:06 ` Andrea Arcangeli [this message]
2011-05-06 18:06   ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110506180646.GF6330@random.random \
    --to=aarcange@redhat.com \
    --cc=akpm@osdl.org \
    --cc=figo1802@gmail.com \
    --cc=kamezawa.hiroyu@jp.fujisu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=minchan.kim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.