From: Christoph Hellwig <hch@lst.de>
To: Sage Weil <sage@newdream.net>
Cc: viro@ZenIV.linux.org.uk, hch@lst.de, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 01/18] vfs: dentry_unhash immediately prior to rmdir
Date: Tue, 10 May 2011 10:12:34 +0200 [thread overview]
Message-ID: <20110510081234.GA12154@lst.de> (raw)
In-Reply-To: <1305002616-16782-2-git-send-email-sage@newdream.net>
> - dentry_unhash(dentry);
> if (d_mountpoint(dentry))
> error = -EBUSY;
> else {
> error = security_inode_rmdir(dir, dentry);
> if (!error) {
> + dentry_unhash(dentry);
> error = dir->i_op->rmdir(dir, dentry);
> if (!error) {
> dentry->d_inode->i_flags |= S_DEAD;
> dont_mount(dentry);
> }
> + dput(dentry);
> }
> }
> mutex_unlock(&dentry->d_inode->i_mutex);
> if (!error) {
> d_delete(dentry);
> }
> - dput(dentry);
>
> return error;
It would be nice if you could throw in a patch later in the series to
clean up the code flow, e.g.
error = -EBUSY;
if (d_mountpoint(dentry))
goto out;
error = security_inode_rmdir(dir, dentry);
if (error)
goto out;
dentry_unhash(dentry);
error = dir->i_op->rmdir(dir, dentry);
if (!error) {
dentry->d_inode->i_flags |= S_DEAD;
dont_mount(dentry);
}
dput(dentry);
out:
mutex_unlock(&dentry->d_inode->i_mutex);
if (!error)
d_delete(dentry);
return error;
}
next prev parent reply other threads:[~2011-05-10 8:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 4:43 [PATCH 00/18] clean up VFS dentry_hash (mis)behavior Sage Weil
2011-05-10 4:43 ` [PATCH 01/18] vfs: dentry_unhash immediately prior to rmdir Sage Weil
2011-05-10 8:12 ` Christoph Hellwig [this message]
2011-05-10 4:43 ` [PATCH 02/18] vfs: remove dget() from dentry_unhash() Sage Weil
2011-05-10 4:43 ` [PATCH 03/18] vfs: push dentry_unhash on rmdir into file systems Sage Weil
2011-05-10 4:43 ` [PATCH 04/18] vfs: push dentry_unhash on rename_dir " Sage Weil
2011-05-10 4:43 ` [PATCH 05/18] vfs: update dentry_unhash() comment Sage Weil
2011-05-10 4:43 ` [PATCH 06/18] libfs: drop unneeded dentry_unhash Sage Weil
2011-05-10 4:43 ` [PATCH 07/18] vfs: fix vfs_rename_dir for FS_RENAME_DOES_D_MOVE filesystems Sage Weil
2011-05-10 4:43 ` [PATCH 08/18] ceph: remove unnecessary dentry_unhash calls Sage Weil
2011-05-10 4:43 ` [PATCH 09/18] xfs: remove unnecessary dentry_unhash from rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 10/18] btrfs: remove unnecessary dentry_unhash in rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 11/18] ext4: remove unnecessary dentry_unhash on rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 12/18] ext3: " Sage Weil
2011-05-10 4:43 ` [PATCH 13/18] ext2: " Sage Weil
2011-05-10 4:43 ` [PATCH 14/18] nfs: " Sage Weil
2011-05-10 4:43 ` Sage Weil
2011-05-10 4:43 ` [PATCH 15/18] exofs: " Sage Weil
2011-05-11 12:53 ` Boaz Harrosh
2011-05-10 4:43 ` [Ocfs2-devel] [PATCH 16/18] ocfs2: " Sage Weil
2011-05-10 4:43 ` Sage Weil
2011-05-10 20:24 ` [Ocfs2-devel] " Joel Becker
2011-05-10 20:24 ` Joel Becker
2011-05-10 4:43 ` [PATCH 17/18] gfs2: " Sage Weil
2011-05-10 8:45 ` [Cluster-devel] " Steven Whitehouse
2011-05-10 8:45 ` Steven Whitehouse
2011-05-10 15:47 ` Sage Weil
2011-05-10 4:43 ` [PATCH 18/18] cifs: " Sage Weil
2011-05-11 10:06 ` [PATCH 00/18] clean up VFS dentry_hash (mis)behavior Christoph Hellwig
2011-05-11 17:18 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510081234.GA12154@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.