From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 17/18] gfs2: remove unnecessary dentry_unhash on rmdir/rename_dir
Date: Tue, 10 May 2011 09:45:15 +0100 [thread overview]
Message-ID: <1305017115.2839.2.camel@menhir> (raw)
In-Reply-To: <1305002616-16782-18-git-send-email-sage@newdream.net>
Hi,
On Mon, 2011-05-09 at 21:43 -0700, Sage Weil wrote:
> Gfs2 has no issues with lingering references to unlinked directory
> inodes.
>
> CC: Steven Whitehouse <swhiteho@redhat.com>
> CC: cluster-devel at redhat.com
> Signed-off-by: Sage Weil <sage@newdream.net>
> ---
> fs/gfs2/ops_inode.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> index 4bf862c..09e436a 100644
> --- a/fs/gfs2/ops_inode.c
> +++ b/fs/gfs2/ops_inode.c
> @@ -572,8 +572,6 @@ static int gfs2_rmdir(struct inode *dir, struct dentry *dentry)
> struct gfs2_holder ri_gh;
> int error;
>
> - dentry_unhash(dentry);
> -
> error = gfs2_rindex_hold(sdp, &ri_gh);
> if (error)
> return error;
> @@ -743,9 +741,6 @@ static int gfs2_rename(struct inode *odir, struct dentry *odentry,
> int error;
>
> if (ndentry->d_inode) {
> - if (S_ISDIR(ndentry->d_inode->i_mode))
> - dentry_unhash(ndentry);
> -
> nip = GFS2_I(ndentry->d_inode);
> if (ip == nip)
> return 0;
I recently posted some patches to this area of code, and I was intending
to push them into my GFS2 -nmw tree today, so I wonder if you could
simplify this by not adding the dentry_unhash into gfs2 in the first
place, which would then ensure no conflicts between the two patch sets?
Steve.
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Sage Weil <sage@newdream.net>
Cc: viro@ZenIV.linux.org.uk, hch@lst.de,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [PATCH 17/18] gfs2: remove unnecessary dentry_unhash on rmdir/rename_dir
Date: Tue, 10 May 2011 09:45:15 +0100 [thread overview]
Message-ID: <1305017115.2839.2.camel@menhir> (raw)
In-Reply-To: <1305002616-16782-18-git-send-email-sage@newdream.net>
Hi,
On Mon, 2011-05-09 at 21:43 -0700, Sage Weil wrote:
> Gfs2 has no issues with lingering references to unlinked directory
> inodes.
>
> CC: Steven Whitehouse <swhiteho@redhat.com>
> CC: cluster-devel@redhat.com
> Signed-off-by: Sage Weil <sage@newdream.net>
> ---
> fs/gfs2/ops_inode.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> index 4bf862c..09e436a 100644
> --- a/fs/gfs2/ops_inode.c
> +++ b/fs/gfs2/ops_inode.c
> @@ -572,8 +572,6 @@ static int gfs2_rmdir(struct inode *dir, struct dentry *dentry)
> struct gfs2_holder ri_gh;
> int error;
>
> - dentry_unhash(dentry);
> -
> error = gfs2_rindex_hold(sdp, &ri_gh);
> if (error)
> return error;
> @@ -743,9 +741,6 @@ static int gfs2_rename(struct inode *odir, struct dentry *odentry,
> int error;
>
> if (ndentry->d_inode) {
> - if (S_ISDIR(ndentry->d_inode->i_mode))
> - dentry_unhash(ndentry);
> -
> nip = GFS2_I(ndentry->d_inode);
> if (ip == nip)
> return 0;
I recently posted some patches to this area of code, and I was intending
to push them into my GFS2 -nmw tree today, so I wonder if you could
simplify this by not adding the dentry_unhash into gfs2 in the first
place, which would then ensure no conflicts between the two patch sets?
Steve.
next prev parent reply other threads:[~2011-05-10 8:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 4:43 [PATCH 00/18] clean up VFS dentry_hash (mis)behavior Sage Weil
2011-05-10 4:43 ` [PATCH 01/18] vfs: dentry_unhash immediately prior to rmdir Sage Weil
2011-05-10 8:12 ` Christoph Hellwig
2011-05-10 4:43 ` [PATCH 02/18] vfs: remove dget() from dentry_unhash() Sage Weil
2011-05-10 4:43 ` [PATCH 03/18] vfs: push dentry_unhash on rmdir into file systems Sage Weil
2011-05-10 4:43 ` [PATCH 04/18] vfs: push dentry_unhash on rename_dir " Sage Weil
2011-05-10 4:43 ` [PATCH 05/18] vfs: update dentry_unhash() comment Sage Weil
2011-05-10 4:43 ` [PATCH 06/18] libfs: drop unneeded dentry_unhash Sage Weil
2011-05-10 4:43 ` [PATCH 07/18] vfs: fix vfs_rename_dir for FS_RENAME_DOES_D_MOVE filesystems Sage Weil
2011-05-10 4:43 ` [PATCH 08/18] ceph: remove unnecessary dentry_unhash calls Sage Weil
2011-05-10 4:43 ` [PATCH 09/18] xfs: remove unnecessary dentry_unhash from rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 10/18] btrfs: remove unnecessary dentry_unhash in rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 11/18] ext4: remove unnecessary dentry_unhash on rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 12/18] ext3: " Sage Weil
2011-05-10 4:43 ` [PATCH 13/18] ext2: " Sage Weil
2011-05-10 4:43 ` [PATCH 14/18] nfs: " Sage Weil
2011-05-10 4:43 ` Sage Weil
2011-05-10 4:43 ` [PATCH 15/18] exofs: " Sage Weil
2011-05-11 12:53 ` Boaz Harrosh
2011-05-10 4:43 ` [Ocfs2-devel] [PATCH 16/18] ocfs2: " Sage Weil
2011-05-10 4:43 ` Sage Weil
2011-05-10 20:24 ` [Ocfs2-devel] " Joel Becker
2011-05-10 20:24 ` Joel Becker
2011-05-10 4:43 ` [PATCH 17/18] gfs2: " Sage Weil
2011-05-10 8:45 ` Steven Whitehouse [this message]
2011-05-10 8:45 ` Steven Whitehouse
2011-05-10 15:47 ` Sage Weil
2011-05-10 4:43 ` [PATCH 18/18] cifs: " Sage Weil
2011-05-11 10:06 ` [PATCH 00/18] clean up VFS dentry_hash (mis)behavior Christoph Hellwig
2011-05-11 17:18 ` Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305017115.2839.2.camel@menhir \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.