From: Todd Poynor <toddpoynor@google.com>
To: Shweta Gulati <shweta.gulati@ti.com>
Cc: linux-omap@vger.kernel.org, Nishanth Menon <nm@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3] OMAP3+: SR Layer Cleanup
Date: Wed, 11 May 2011 11:27:42 -0700 [thread overview]
Message-ID: <20110511182742.GA9409@google.com> (raw)
In-Reply-To: <BANLkTin07ZkWwhMtqUEMhLtwugKNmhku9g@mail.gmail.com>
[Another try with a different email client, sorry for any dups.]
...
> diff --git a/arch/arm/mach-omap2/sr_device.c
> b/arch/arm/mach-omap2/sr_device.c
> index 2782d3f..65b2aae 100644
> --- a/arch/arm/mach-omap2/sr_device.c
> +++ b/arch/arm/mach-omap2/sr_device.c
> @@ -82,6 +82,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user)
> struct omap_sr_data *sr_data;
> struct omap_device *od;
> struct omap_volt_data *volt_data;
> + struct omap_sr_dev_attr *sr_dev_attr;
> char *name = "smartreflex";
> static int i;
>
> @@ -92,9 +93,11 @@ static int sr_dev_init(struct omap_hwmod *oh, void
> *user)
> return -ENOMEM;
> }
>
> - if (!oh->vdd_name) {
> + sr_dev_attr = (struct omap_sr_dev_attr *)oh->dev_attr;
> + if (!sr_dev_attr->voltdm_name) {
> pr_err("%s: No voltage domain specified for %s."
>
Suggest if (!sr_dev_attr || !sr_dev_attr->voltdm_name) to catch this error.
> - "Cannot initialize\n", __func__, oh->name);
> + "Cannot initialize\n", __func__,
> + sr_dev_attr->voltdm_name);
>
Should leave the hwmod's oh->name as the pr_err param, sr_dev_attr->voltdm_name
has just been verified bogus.
Todd
WARNING: multiple messages have this Message-ID (diff)
From: toddpoynor@google.com (Todd Poynor)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] OMAP3+: SR Layer Cleanup
Date: Wed, 11 May 2011 11:27:42 -0700 [thread overview]
Message-ID: <20110511182742.GA9409@google.com> (raw)
In-Reply-To: <BANLkTin07ZkWwhMtqUEMhLtwugKNmhku9g@mail.gmail.com>
[Another try with a different email client, sorry for any dups.]
...
> diff --git a/arch/arm/mach-omap2/sr_device.c
> b/arch/arm/mach-omap2/sr_device.c
> index 2782d3f..65b2aae 100644
> --- a/arch/arm/mach-omap2/sr_device.c
> +++ b/arch/arm/mach-omap2/sr_device.c
> @@ -82,6 +82,7 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user)
> struct omap_sr_data *sr_data;
> struct omap_device *od;
> struct omap_volt_data *volt_data;
> + struct omap_sr_dev_attr *sr_dev_attr;
> char *name = "smartreflex";
> static int i;
>
> @@ -92,9 +93,11 @@ static int sr_dev_init(struct omap_hwmod *oh, void
> *user)
> return -ENOMEM;
> }
>
> - if (!oh->vdd_name) {
> + sr_dev_attr = (struct omap_sr_dev_attr *)oh->dev_attr;
> + if (!sr_dev_attr->voltdm_name) {
> pr_err("%s: No voltage domain specified for %s."
>
Suggest if (!sr_dev_attr || !sr_dev_attr->voltdm_name) to catch this error.
> - "Cannot initialize\n", __func__, oh->name);
> + "Cannot initialize\n", __func__,
> + sr_dev_attr->voltdm_name);
>
Should leave the hwmod's oh->name as the pr_err param, sr_dev_attr->voltdm_name
has just been verified bogus.
Todd
next prev parent reply other threads:[~2011-05-11 18:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 9:12 [PATCH V3] OMAP3+: SR Layer Cleanup Shweta Gulati
2011-05-11 9:12 ` Shweta Gulati
2011-05-11 11:15 ` Menon, Nishanth
2011-05-11 11:15 ` Menon, Nishanth
2011-05-12 9:50 ` Kevin Hilman
2011-05-12 9:50 ` Kevin Hilman
2011-05-12 12:48 ` Gulati, Shweta
2011-05-12 12:48 ` Gulati, Shweta
2011-05-12 17:37 ` Menon, Nishanth
2011-05-12 17:37 ` Menon, Nishanth
2011-05-11 16:36 ` Todd Poynor
2011-05-11 16:36 ` Todd Poynor
2011-05-11 18:27 ` Todd Poynor [this message]
2011-05-11 18:27 ` Todd Poynor
2011-05-12 5:04 ` Gulati, Shweta
2011-05-12 5:04 ` Gulati, Shweta
2011-05-12 11:41 ` Cousson, Benoit
2011-05-12 11:41 ` Cousson, Benoit
2011-05-12 12:49 ` Gulati, Shweta
2011-05-12 12:49 ` Gulati, Shweta
2011-05-12 13:23 ` Gulati, Shweta
2011-05-12 13:23 ` Gulati, Shweta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511182742.GA9409@google.com \
--to=toddpoynor@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=shweta.gulati@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.