[PATCH] pcsc-lite: make configuration file a separate package

[PATCH] pcsc-lite: make configuration file a separate package

[Chase Maupin]

* Move the reader.conf file to be part of a separate package
  so that it is not installed by default.
* This is done because individual readers that implements an
  IFDHandler library need to be able to install their reader.conf
  file in the /etc/reader.conf.d directory.  Without this change
  those packages will conflict with the reader.conf file installed
  by the pcsc-lite package:
    * NOTE: the reader.conf file in the package is a commented out
            template file, not an actual working configuration
            file.
* Using this change IFDHandler packages can use RCONFLICT with
  the pcsc-lite-collateral package to let users know that these
  packages cannot co-exist.
* Mark the configuration file an such so that when the package is
  updated the user's changes are not lost.
* Bump the PR.

Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
---
 recipes/pcsc-lite/pcsc-lite_1.5.2.bb |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/recipes/pcsc-lite/pcsc-lite_1.5.2.bb b/recipes/pcsc-lite/pcsc-lite_1.5.2.bb
index b4af08d..88401b6 100644
--- a/recipes/pcsc-lite/pcsc-lite_1.5.2.bb
+++ b/recipes/pcsc-lite/pcsc-lite_1.5.2.bb
@@ -5,6 +5,8 @@ LICENSE = "BSD"
 DEPENDS = "hal"
 RDEPENDS_${PN} = "hal"
 
+PR = "r1"
+
 SRC_URI = "https://alioth.debian.org/frs/download.php/2795/pcsc-lite-${PV}.tar.bz2 \
            file://pcscd.init "
 
@@ -26,8 +28,11 @@ do_install() {
 }
 
 PACKAGES =+ "libpcsclite"
+PACKAGES =+ "${PN}-collateral"
 
 FILES_libpcsclite = "${libdir}/libpcsclite.so.*"
+FILES_${PN}-collateral = "${sysconfdir}/reader.conf.d/*"
+CONFFILES_${PN}-collateral = "${sysconfdir}/reader.conf.d/*"
 
 SRC_URI[md5sum] = "d7d466621bec39354351f09349f6374c"
 SRC_URI[sha256sum] = "a0c11b0b5cc46d4c4ec499b875cfdc4e766fdf12fe2f6ea635e1b11ab7b8821e"
-- 
1.7.0.4

Re: [PATCH] pcsc-lite: make configuration file a separate package

[Denys Dmytriyenko]

On Tue, May 10, 2011 at 05:17:42PM -0500, Chase Maupin wrote:
> * Move the reader.conf file to be part of a separate package
>   so that it is not installed by default.
> * This is done because individual readers that implements an
>   IFDHandler library need to be able to install their reader.conf
>   file in the /etc/reader.conf.d directory.  Without this change

Chase,

Sorry, it did not occur to me yesterday, when helping with the patch, but I 
just realised now that /etc/reader.conf.d (like any other dir.d denotion) 
should expect a set of config files and not just one specific one.

So, I started checking the sources and the ChangeLog from pcsc-lite and got it 
confirmed - you can pretty much drop a set of files into that directory and 
all of them will be parsed for the configuration. So, since the default file 
is only a template with all the configuration commented out, you should be 
safe to install your own config files in that directory with different names. 
That way you don't need any changes to the pcsc-lite recipe...

One of the relative enties from ChangeLog:
- Add the ability to parse all the configuration files of a directory
  instead of just one configuration file. update-reader.conf is then now
  obsolete.

-- 
Denys

>   those packages will conflict with the reader.conf file installed
>   by the pcsc-lite package:
>     * NOTE: the reader.conf file in the package is a commented out
>             template file, not an actual working configuration
>             file.
> * Using this change IFDHandler packages can use RCONFLICT with
>   the pcsc-lite-collateral package to let users know that these
>   packages cannot co-exist.
> * Mark the configuration file an such so that when the package is
>   updated the user's changes are not lost.
> * Bump the PR.
> 
> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> ---
>  recipes/pcsc-lite/pcsc-lite_1.5.2.bb |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/pcsc-lite/pcsc-lite_1.5.2.bb b/recipes/pcsc-lite/pcsc-lite_1.5.2.bb
> index b4af08d..88401b6 100644
> --- a/recipes/pcsc-lite/pcsc-lite_1.5.2.bb
> +++ b/recipes/pcsc-lite/pcsc-lite_1.5.2.bb
> @@ -5,6 +5,8 @@ LICENSE = "BSD"
>  DEPENDS = "hal"
>  RDEPENDS_${PN} = "hal"
>  
> +PR = "r1"
> +
>  SRC_URI = "https://alioth.debian.org/frs/download.php/2795/pcsc-lite-${PV}.tar.bz2 \
>             file://pcscd.init "
>  
> @@ -26,8 +28,11 @@ do_install() {
>  }
>  
>  PACKAGES =+ "libpcsclite"
> +PACKAGES =+ "${PN}-collateral"
>  
>  FILES_libpcsclite = "${libdir}/libpcsclite.so.*"
> +FILES_${PN}-collateral = "${sysconfdir}/reader.conf.d/*"
> +CONFFILES_${PN}-collateral = "${sysconfdir}/reader.conf.d/*"
>  
>  SRC_URI[md5sum] = "d7d466621bec39354351f09349f6374c"
>  SRC_URI[sha256sum] = "a0c11b0b5cc46d4c4ec499b875cfdc4e766fdf12fe2f6ea635e1b11ab7b8821e"
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [PATCH] pcsc-lite: make configuration file a separate package

[Maupin, Chase]

> -----Original Message-----
> From: Denys Dmytriyenko [mailto:denis@denix.org]
> Sent: Thursday, May 12, 2011 10:43 AM
> To: openembedded-devel@lists.openembedded.org
> Cc: Maupin, Chase
> Subject: Re: [oe] [PATCH] pcsc-lite: make configuration file a separate
> package
> 
> On Tue, May 10, 2011 at 05:17:42PM -0500, Chase Maupin wrote:
> > * Move the reader.conf file to be part of a separate package
> >   so that it is not installed by default.
> > * This is done because individual readers that implements an
> >   IFDHandler library need to be able to install their reader.conf
> >   file in the /etc/reader.conf.d directory.  Without this change
> 
> Chase,
> 
> Sorry, it did not occur to me yesterday, when helping with the patch,
> but I
> just realised now that /etc/reader.conf.d (like any other dir.d
> denotion)
> should expect a set of config files and not just one specific one.
> 
> So, I started checking the sources and the ChangeLog from pcsc-lite and
> got it
> confirmed - you can pretty much drop a set of files into that directory
> and
> all of them will be parsed for the configuration. So, since the default
> file
> is only a template with all the configuration commented out, you should
> be
> safe to install your own config files in that directory with different
> names.
> That way you don't need any changes to the pcsc-lite recipe...

Denys,

Thanks.  The documentation I was reading for pcsc-lite made it sound like you needed the file to be called reader.conf.  I guess ignore this patch for now then and we'll try having a separate reader.conf.pru file installed and see if pcsc-lite can find it.  Thanks for the info.

> 
> One of the relative enties from ChangeLog:
> - Add the ability to parse all the configuration files of a directory
>   instead of just one configuration file. update-reader.conf is then
> now
>   obsolete.
> 
> --
> Denys
> 
> >   those packages will conflict with the reader.conf file installed
> >   by the pcsc-lite package:
> >     * NOTE: the reader.conf file in the package is a commented out
> >             template file, not an actual working configuration
> >             file.
> > * Using this change IFDHandler packages can use RCONFLICT with
> >   the pcsc-lite-collateral package to let users know that these
> >   packages cannot co-exist.
> > * Mark the configuration file an such so that when the package is
> >   updated the user's changes are not lost.
> > * Bump the PR.
> >
> > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> > ---
> >  recipes/pcsc-lite/pcsc-lite_1.5.2.bb |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/recipes/pcsc-lite/pcsc-lite_1.5.2.bb b/recipes/pcsc-
> lite/pcsc-lite_1.5.2.bb
> > index b4af08d..88401b6 100644
> > --- a/recipes/pcsc-lite/pcsc-lite_1.5.2.bb
> > +++ b/recipes/pcsc-lite/pcsc-lite_1.5.2.bb
> > @@ -5,6 +5,8 @@ LICENSE = "BSD"
> >  DEPENDS = "hal"
> >  RDEPENDS_${PN} = "hal"
> >
> > +PR = "r1"
> > +
> >  SRC_URI = "https://alioth.debian.org/frs/download.php/2795/pcsc-
> lite-${PV}.tar.bz2 \
> >             file://pcscd.init "
> >
> > @@ -26,8 +28,11 @@ do_install() {
> >  }
> >
> >  PACKAGES =+ "libpcsclite"
> > +PACKAGES =+ "${PN}-collateral"
> >
> >  FILES_libpcsclite = "${libdir}/libpcsclite.so.*"
> > +FILES_${PN}-collateral = "${sysconfdir}/reader.conf.d/*"
> > +CONFFILES_${PN}-collateral = "${sysconfdir}/reader.conf.d/*"
> >
> >  SRC_URI[md5sum] = "d7d466621bec39354351f09349f6374c"
> >  SRC_URI[sha256sum] =
> "a0c11b0b5cc46d4c4ec499b875cfdc4e766fdf12fe2f6ea635e1b11ab7b8821e"
> > --
> > 1.7.0.4
> >
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-
> devel