From: "Avinash.H.M." <avinashhm@ti.com>
To: Vladimir Zapolskiy <vzapolskiy@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
Benoit Cousson <b-cousson@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 2/2] [RFC] OMAP4: clock data: shrink more clock data.
Date: Mon, 16 May 2011 12:23:01 +0530 [thread overview]
Message-ID: <20110516065301.GA12703@avinash-laptop> (raw)
In-Reply-To: <1305495958-2236-3-git-send-email-vzapolskiy@gmail.com>
On Mon, May 16, 2011 at 12:45:58AM +0300, Vladimir Zapolskiy wrote:
> This mass change continues the reduction of homogeneous data chunks
> along clock definitions. No semantical difference is added in the
> change.
>
> Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
> ---
[ ... ]
> +DEFINE_CLOCK_DM(gpu_fck, dpll_core_m7x2_ck, l3_gfx_clkdm,
> + CLOCK_OPS_DFLT_SW(CM_GFX_GFX),
> + CLOCK_CLKSEL0(sgx_clk_mux_sel,
> + CM_GFX_GFX_CLKCTRL, CLKSEL_SGX_FCLK));
>
Hi Vladimir ,
With this the rate wouldn't get initialised and it throws a warning at
boot.
[ 0.000000] ------------[ cut here ]------------
[ 0.000000] WARNING: at arch/arm/mach-omap2/clkt_clksel.c:194 omap2_clksel_recalc+0xd4/0xe4()
[ 0.000000] clock: Could not find fieldval 1 for clock gpu_fck parent dpll_core_m7x2_ck
[ 0.000000] Modules linked in:
[ 0.000000] [<c005fd5c>] (unwind_backtrace+0x0/0xe4) from [<c00921b4>] (warn_slowpath_common+0x4c/0x64)
[ 0.000000] [<c00921b4>] (warn_slowpath_common+0x4c/0x64) from [<c009224c>] (warn_slowpath_fmt+0x2c/0x3c)
[ 0.000000] [<c009224c>] (warn_slowpath_fmt+0x2c/0x3c) from [<c0072594>] (omap2_clksel_recalc+0xd4/0xe4)
[ 0.000000] [<c0072594>] (omap2_clksel_recalc+0xd4/0xe4) from [<c007712c>] (propagate_rate+0x24/0x50)
[ 0.000000] [<c007712c>] (propagate_rate+0x24/0x50) from [<c0077138>] (propagate_rate+0x30/0x50)
[ 0.000000] ---[ end trace 1b75b31a2719ed1c ]---
Will be fixed with this change below :
- CLOCK_CLKSEL0(sgx_clk_mux_sel,
+ CLOCK_CLKSEL_INIT(sgx_clk_mux_sel,
May be CLOCK_CLKSEL0 is not required altogether. I see it used only to
initialise gpu_fck. May be can remove this.
I boot tested it on 4430 sdp. FWIW , you can add
Tested-by: Avinash.H.M. <avinashhm@ti.com>
thanks,
- Avinash
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: avinashhm@ti.com (Avinash.H.M.)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/2] [RFC] OMAP4: clock data: shrink more clock data.
Date: Mon, 16 May 2011 12:23:01 +0530 [thread overview]
Message-ID: <20110516065301.GA12703@avinash-laptop> (raw)
In-Reply-To: <1305495958-2236-3-git-send-email-vzapolskiy@gmail.com>
On Mon, May 16, 2011 at 12:45:58AM +0300, Vladimir Zapolskiy wrote:
> This mass change continues the reduction of homogeneous data chunks
> along clock definitions. No semantical difference is added in the
> change.
>
> Signed-off-by: Vladimir Zapolskiy <vzapolskiy@gmail.com>
> ---
[ ... ]
> +DEFINE_CLOCK_DM(gpu_fck, dpll_core_m7x2_ck, l3_gfx_clkdm,
> + CLOCK_OPS_DFLT_SW(CM_GFX_GFX),
> + CLOCK_CLKSEL0(sgx_clk_mux_sel,
> + CM_GFX_GFX_CLKCTRL, CLKSEL_SGX_FCLK));
>
Hi Vladimir ,
With this the rate wouldn't get initialised and it throws a warning at
boot.
[ 0.000000] ------------[ cut here ]------------
[ 0.000000] WARNING: at arch/arm/mach-omap2/clkt_clksel.c:194 omap2_clksel_recalc+0xd4/0xe4()
[ 0.000000] clock: Could not find fieldval 1 for clock gpu_fck parent dpll_core_m7x2_ck
[ 0.000000] Modules linked in:
[ 0.000000] [<c005fd5c>] (unwind_backtrace+0x0/0xe4) from [<c00921b4>] (warn_slowpath_common+0x4c/0x64)
[ 0.000000] [<c00921b4>] (warn_slowpath_common+0x4c/0x64) from [<c009224c>] (warn_slowpath_fmt+0x2c/0x3c)
[ 0.000000] [<c009224c>] (warn_slowpath_fmt+0x2c/0x3c) from [<c0072594>] (omap2_clksel_recalc+0xd4/0xe4)
[ 0.000000] [<c0072594>] (omap2_clksel_recalc+0xd4/0xe4) from [<c007712c>] (propagate_rate+0x24/0x50)
[ 0.000000] [<c007712c>] (propagate_rate+0x24/0x50) from [<c0077138>] (propagate_rate+0x30/0x50)
[ 0.000000] ---[ end trace 1b75b31a2719ed1c ]---
Will be fixed with this change below :
- CLOCK_CLKSEL0(sgx_clk_mux_sel,
+ CLOCK_CLKSEL_INIT(sgx_clk_mux_sel,
May be CLOCK_CLKSEL0 is not required altogether. I see it used only to
initialise gpu_fck. May be can remove this.
I boot tested it on 4430 sdp. FWIW , you can add
Tested-by: Avinash.H.M. <avinashhm@ti.com>
thanks,
- Avinash
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2011-05-16 6:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-15 21:45 [PATCHv2 0/2] [RFC] Shrink clock data utilizing preprocessor Vladimir Zapolskiy
2011-05-15 21:45 ` Vladimir Zapolskiy
2011-05-15 21:45 ` [PATCHv2 1/2] [RFC] OMAP4: clock data: shrink " Vladimir Zapolskiy
2011-05-15 21:45 ` Vladimir Zapolskiy
2011-05-15 21:45 ` [PATCHv2 2/2] [RFC] OMAP4: clock data: shrink more clock data Vladimir Zapolskiy
2011-05-15 21:45 ` Vladimir Zapolskiy
2011-05-16 6:53 ` Avinash.H.M. [this message]
2011-05-16 6:53 ` Avinash.H.M.
2011-05-16 7:56 ` [PATCHv2 0/2] [RFC] Shrink clock data utilizing preprocessor Sascha Hauer
2011-05-16 7:56 ` Sascha Hauer
2011-05-16 16:25 ` Vladimir Zapolskiy
2011-05-16 16:25 ` Vladimir Zapolskiy
2011-05-17 13:06 ` Kevin Hilman
2011-05-17 13:06 ` Kevin Hilman
2011-05-17 15:47 ` Premi, Sanjeev
2011-05-17 15:47 ` Premi, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516065301.GA12703@avinash-laptop \
--to=avinashhm@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vzapolskiy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.