From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (abituguru) Depend on DMI
Date: Mon, 16 May 2011 14:47:47 +0000 [thread overview]
Message-ID: <20110516144747.GA31057@ericsson.com> (raw)
In-Reply-To: <20110516110612.49ed4204@endymion.delvare>
On Mon, May 16, 2011 at 05:06:12AM -0400, Jean Delvare wrote:
> The abituguru drivers are only built on X86, where DMI support is now
> enabled by default. So let these drivers depend on DMI, for the
> following gains:
> * Robustness and safety. Detection of these devices is weak and uses
> non-standard methods, it should really be limited to Abit boards
> unless the user explicitly asks otherwise.
> * Code simplicity. The code is easier to read without ifdefs.
> * Better build testing coverage. Now there's only one way to build the
> drivers, so no risk of build failure on exotic systems.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Alistair John Strachan <alistair@devzero.co.uk>
> Cc: Hans de Goede <hdegoede@redhat.com>
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-05-16 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 9:06 [lm-sensors] [PATCH] hwmon: (abituguru) Depend on DMI Jean Delvare
2011-05-16 14:47 ` Guenter Roeck [this message]
2011-05-16 21:39 ` Alistair John Strachan
2011-05-17 8:03 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516144747.GA31057@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.