From: Dmitry Artamonow <mad_soft@inbox.ru>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
linux-kernel@vger.kernel.org, Harald Welte <laforge@gnumonks.org>,
Philipp Zabel <philipp.zabel@gmail.com>,
Paul Parsons <lost.distance@yahoo.com>,
linux-arm-kernel@lists.infradead.org,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH v2 1/3] ASoC: Asahi Kasei AK4641 codec driver
Date: Tue, 17 May 2011 08:26:44 +0400 [thread overview]
Message-ID: <20110517042644.GA19254@rainbow> (raw)
In-Reply-To: <20110516212533.GA2570@sirena.org.uk>
On 22:25 Mon 16 May , Mark Brown wrote:
> On Tue, May 17, 2011 at 01:03:23AM +0400, Dmitry Artamonow wrote:
> > A driver for the AK4641 codec used in iPAQ hx4700 and Glofiish M800
> > among others.
>
> This looks pretty good - a few small issues realting to the use of old
> APIs and coding standards below but nothing serious.
>
Hi, Mark! Thanks for review - your comments are really valuable.
It seems that ASoC APIs change faster than I adapt this driver to them, but
I hope that preparing v3 will take less time than v1->v2 took :)
--
Best regards,
Dmitry "MAD" Artamonow
WARNING: multiple messages have this Message-ID (diff)
From: mad_soft@inbox.ru (Dmitry Artamonow)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v2 1/3] ASoC: Asahi Kasei AK4641 codec driver
Date: Tue, 17 May 2011 08:26:44 +0400 [thread overview]
Message-ID: <20110517042644.GA19254@rainbow> (raw)
In-Reply-To: <20110516212533.GA2570@sirena.org.uk>
On 22:25 Mon 16 May , Mark Brown wrote:
> On Tue, May 17, 2011 at 01:03:23AM +0400, Dmitry Artamonow wrote:
> > A driver for the AK4641 codec used in iPAQ hx4700 and Glofiish M800
> > among others.
>
> This looks pretty good - a few small issues realting to the use of old
> APIs and coding standards below but nothing serious.
>
Hi, Mark! Thanks for review - your comments are really valuable.
It seems that ASoC APIs change faster than I adapt this driver to them, but
I hope that preparing v3 will take less time than v1->v2 took :)
--
Best regards,
Dmitry "MAD" Artamonow
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Artamonow <mad_soft@inbox.ru>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
linux-kernel@vger.kernel.org, Harald Welte <laforge@gnumonks.org>,
Philipp Zabel <philipp.zabel@gmail.com>,
Paul Parsons <lost.distance@yahoo.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH v2 1/3] ASoC: Asahi Kasei AK4641 codec driver
Date: Tue, 17 May 2011 08:26:44 +0400 [thread overview]
Message-ID: <20110517042644.GA19254@rainbow> (raw)
In-Reply-To: <20110516212533.GA2570@sirena.org.uk>
On 22:25 Mon 16 May , Mark Brown wrote:
> On Tue, May 17, 2011 at 01:03:23AM +0400, Dmitry Artamonow wrote:
> > A driver for the AK4641 codec used in iPAQ hx4700 and Glofiish M800
> > among others.
>
> This looks pretty good - a few small issues realting to the use of old
> APIs and coding standards below but nothing serious.
>
Hi, Mark! Thanks for review - your comments are really valuable.
It seems that ASoC APIs change faster than I adapt this driver to them, but
I hope that preparing v3 will take less time than v1->v2 took :)
--
Best regards,
Dmitry "MAD" Artamonow
next prev parent reply other threads:[~2011-05-17 4:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 21:03 [PATCH v2 0/3] ASoC: add support for audio on iPaq hx4700 Dmitry Artamonow
2011-05-16 21:03 ` Dmitry Artamonow
2011-05-16 21:03 ` Dmitry Artamonow
2011-05-16 21:03 ` [PATCH v2 1/3] ASoC: Asahi Kasei AK4641 codec driver Dmitry Artamonow
2011-05-16 21:03 ` Dmitry Artamonow
2011-05-16 21:03 ` Dmitry Artamonow
2011-05-16 21:25 ` [alsa-devel] " Mark Brown
2011-05-16 21:25 ` Mark Brown
2011-05-17 4:26 ` Dmitry Artamonow [this message]
2011-05-17 4:26 ` Dmitry Artamonow
2011-05-17 4:26 ` Dmitry Artamonow
2011-05-16 21:03 ` [PATCH v2 2/3] ASoC: add iPAQ hx4700 machine driver Dmitry Artamonow
2011-05-16 21:03 ` Dmitry Artamonow
2011-05-16 21:03 ` Dmitry Artamonow
2011-05-16 21:35 ` [alsa-devel] " Mark Brown
2011-05-16 21:35 ` Mark Brown
2011-05-16 21:03 ` [PATCH v2 3/3] pxa/hx4700: add I2C board info for AK4641 codec Dmitry Artamonow
2011-05-16 21:03 ` Dmitry Artamonow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517042644.GA19254@rainbow \
--to=mad_soft@inbox.ru \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric.y.miao@gmail.com \
--cc=laforge@gnumonks.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=lrg@slimlogic.co.uk \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.