From: "Michael S. Tsirkin" <mst@redhat.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: David Miller <davem@davemloft.net>,
mirqus@gmail.com, shanwei@cn.fujitsu.com,
mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org,
bhutchings@solarflare.com
Subject: Re: tap/bridge: Dropping NETIF_F_GSO/NETIF_F_SG
Date: Tue, 17 May 2011 08:48:23 +0300 [thread overview]
Message-ID: <20110517054823.GB26414@redhat.com> (raw)
In-Reply-To: <20110517052401.GA15198@gondor.apana.org.au>
On Tue, May 17, 2011 at 03:24:01PM +1000, Herbert Xu wrote:
> On Tue, May 17, 2011 at 08:18:45AM +0300, Michael S. Tsirkin wrote:
> >
> > Hmm, we get the warnings about bits dropped on each set_offload
> > call:
> > netdev_update_features is called,
> > that calls netdev_fix_features
> >
> > No?
>
> I presume this has changed recently as the current Linus tree
> does not contain a call to netdev_update_features, it only calls
> netdev_features_change.
>
> If so then this does ensure that the feature bits will be sane.
>
> I still think the warnings should be retained at their previous
> level in the call paths other than set_offload. All we have to
> do is add a parameter to netdev_update_features and co.
>
> Cheers,
You mean like bool quiet?
--
MST
next prev parent reply other threads:[~2011-05-17 5:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 18:18 tap/bridge: Dropping NETIF_F_GSO/NETIF_F_SG Michael S. Tsirkin
2011-05-04 22:34 ` Herbert Xu
2011-05-04 23:28 ` Michał Mirosław
2011-05-05 0:19 ` Herbert Xu
2011-05-05 8:44 ` Michael S. Tsirkin
2011-05-05 9:34 ` Shan Wei
2011-05-05 10:05 ` Herbert Xu
2011-05-16 7:32 ` Michael S. Tsirkin
2011-05-16 8:07 ` Herbert Xu
2011-05-16 8:18 ` Michael S. Tsirkin
2011-05-16 9:38 ` Herbert Xu
2011-05-16 9:48 ` Michael S. Tsirkin
2011-05-16 10:43 ` Herbert Xu
2011-05-16 11:21 ` Michael S. Tsirkin
2011-05-16 12:18 ` Herbert Xu
2011-05-16 12:24 ` Michał Mirosław
2011-05-16 22:46 ` Herbert Xu
2011-05-16 23:06 ` David Miller
2011-05-16 23:45 ` Herbert Xu
2011-05-17 5:18 ` Michael S. Tsirkin
2011-05-17 5:24 ` Herbert Xu
2011-05-17 5:48 ` Michael S. Tsirkin [this message]
2011-05-17 6:25 ` Herbert Xu
2011-05-17 8:08 ` Michał Mirosław
2011-05-17 8:15 ` Michał Mirosław
2011-05-17 8:19 ` [PATCH] net: tuntap: Fix tun_net_fix_features() Michał Mirosław
2011-05-17 14:29 ` Michael S. Tsirkin
2011-05-17 14:46 ` Michał Mirosław
2011-05-17 14:54 ` Michael S. Tsirkin
2011-05-17 15:00 ` Michał Mirosław
2011-05-17 15:11 ` Michael S. Tsirkin
2011-06-01 9:25 ` Michael S. Tsirkin
2011-06-20 19:14 ` [RESENT PATCH] " Michał Mirosław
2011-06-20 19:25 ` Ben Hutchings
2011-06-20 19:44 ` Michał Mirosław
2011-05-16 10:53 ` tap/bridge: Dropping NETIF_F_GSO/NETIF_F_SG Michał Mirosław
2011-05-16 8:28 ` Michael S. Tsirkin
2011-05-05 15:26 ` Michał Mirosław
2011-05-14 6:54 ` Shan Wei
2011-05-16 7:28 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517054823.GB26414@redhat.com \
--to=mst@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shanwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.