From: Joel Becker <jlbec@evilplan.org>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [Ocfs2-users] ocfs or configfs bug ?
Date: Wed, 18 May 2011 03:49:56 -0700 [thread overview]
Message-ID: <20110518104955.GA7330@noexit.corp.google.com> (raw)
In-Reply-To: <4DC9E889.3080008@oracle.com>
On Tue, May 10, 2011 at 06:38:17PM -0700, Sunil Mushran wrote:
> configfs_readdir() is racing configfs_d_delete(). And I cannot
> see how we can use the existing spinlock to prevent the race.
>
> sysfs uses a coarse lock sysfs_mutex to prevent against this.
> I think we should do the same in configfs.
sysfs_mutex is peppered everywhere. It's rather ugly, I think.
I am thinking about how the code reads. I admit I also don't like that
sysfs_mutex serializes all accesses to the sysfs directory tree, but I'd
be OK with that as a stopgap solution if the code only read better.
Joel
--
"The nice thing about egotists is that they don't talk about other
people."
- Lucille S. Harper
http://www.jlbec.org/
jlbec at evilplan.org
next prev parent reply other threads:[~2011-05-18 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4DADA228.5050209@bull.net>
[not found] ` <20110419194840.GA27826@noexit>
2011-04-20 0:20 ` [Ocfs2-devel] [Ocfs2-users] ocfs or configfs bug ? Sunil Mushran
2011-05-11 1:38 ` Sunil Mushran
2011-05-18 10:49 ` Joel Becker [this message]
2011-05-18 11:12 ` Joel Becker
2011-05-18 18:36 ` Sunil Mushran
2011-05-18 19:11 ` Joel Becker
2011-05-18 20:08 ` Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518104955.GA7330@noexit.corp.google.com \
--to=jlbec@evilplan.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.