From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [Ocfs2-users] ocfs or configfs bug ?
Date: Wed, 18 May 2011 13:08:36 -0700 [thread overview]
Message-ID: <4DD42744.1030602@oracle.com> (raw)
In-Reply-To: <20110518191150.GB3723@noexit.corp.google.com>
On 05/18/2011 12:11 PM, Joel Becker wrote:
> Oh, over here.
>
> On Wed, May 18, 2011 at 11:36:59AM -0700, Sunil Mushran wrote:
>> On 05/18/2011 04:12 AM, Joel Becker wrote:
>>> On Wed, May 18, 2011 at 03:49:56AM -0700, Joel Becker wrote:
>>>> sysfs_mutex is peppered everywhere. It's rather ugly, I think.
>>>> I am thinking about how the code reads. I admit I also don't like that
>>>> sysfs_mutex serializes all accesses to the sysfs directory tree, but I'd
>>>> be OK with that as a stopgap solution if the code only read better.
>>> Can you test this?
>>>
>>> Joel
>>
>> So it did run for far longer. But then hit the following.
>>
>> http://oss.oracle.com/~smushran/configfs_oops_20110518.txt
> I got the same result.
>
>> BTW, this is not new. I was running into it earlier too. Albeit
>> less frequently than readdir.
> Do you think this is related, or does my patch fix readdir and
> go upstream with another fix coming for this BUG_ON()?
It does not look directly related. Though it too points to a hole in
the locking. A second patch for this BUG_ON will work.
prev parent reply other threads:[~2011-05-18 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4DADA228.5050209@bull.net>
[not found] ` <20110419194840.GA27826@noexit>
2011-04-20 0:20 ` [Ocfs2-devel] [Ocfs2-users] ocfs or configfs bug ? Sunil Mushran
2011-05-11 1:38 ` Sunil Mushran
2011-05-18 10:49 ` Joel Becker
2011-05-18 11:12 ` Joel Becker
2011-05-18 18:36 ` Sunil Mushran
2011-05-18 19:11 ` Joel Becker
2011-05-18 20:08 ` Sunil Mushran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD42744.1030602@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.